[fix][evaluation]eval online (#327)

* fix TargetConnector

* fix ut

* fix ut

---------

Co-authored-by: tpfz <tpfz@bytedance.com>

Author: tpfz

backend/modules/evaluation/domain/service/expt_manage_execution_impl.go

@@ -120,8 +120,7 @@ func (e *ExptMangerImpl) CheckConnector(ctx context.Context, expt *entity.Experi
 }
 
 func (e *ExptMangerImpl) checkTargetConnector(ctx context.Context, expt *entity.Experiment, session *entity.Session) error {
-	if expt.Target == nil ||
-		expt.Target.EvalTargetType == entity.EvalTargetTypeLoopTrace {
+	if expt.Target == nil || expt.ExptType == entity.ExptType_Online {
 		return nil
 	}
 

backend/modules/evaluation/domain/service/expt_manage_execution_impl_test.go

@@ -1090,6 +1090,16 @@ func TestExptMangerImpl_CheckConnector(t *testing.T) {
 				SpaceID: 789,
 				EvalConf: &entity.EvaluationConfiguration{
 					ConnectorConf: entity.Connector{
+						TargetConf: &entity.TargetConf{
+							TargetVersionID: 1,
+							IngressConf: &entity.TargetIngressConf{
+								EvalSetAdapter: &entity.FieldAdapter{
+									FieldConfs: []*entity.FieldConf{
+										{FromField: "field1"},
+									},
+								},
+							},
+						},
 						EvaluatorsConf: &entity.EvaluatorsConf{
 							EvaluatorConf: []*entity.EvaluatorConf{
 								{
@@ -1108,7 +1118,11 @@ func TestExptMangerImpl_CheckConnector(t *testing.T) {
 				},
 				Target: &entity.EvalTarget{
 					EvalTargetType: entity.EvalTargetTypeLoopTrace,
+					EvalTargetVersion: &entity.EvalTargetVersion{
+						ID: 1,
+					},
 				},
+				TargetVersionID: 1,
 				EvalSet: &entity.EvaluationSet{
 					EvaluationSetVersion: &entity.EvaluationSetVersion{
 						EvaluationSetSchema: &entity.EvaluationSetSchema{

backend/modules/evaluation/domain/service/expt_manage_execution_validation_test.go

@@ -115,24 +115,43 @@ func TestExptMangerImpl_checkTargetConnector_VersionIDValidation(t *testing.T) {
 			expectedError: false,
 		},
 		{
-			name: "loop_trace_target_should_skip_validation",
+			name: "loop_trace_target_should_fail_validation", // 修正测试名称以符合实际行为
 			expt: &entity.Experiment{
 				TargetVersionID: 123,
+				TargetType:      entity.EvalTargetTypeLoopPrompt, // 添加TargetType以触发fixTargetConf
 				Target: &entity.EvalTarget{
 					EvalTargetType: entity.EvalTargetTypeLoopTrace,
 				},
+				EvalSet: &entity.EvaluationSet{
+					EvaluationSetVersion: &entity.EvaluationSetVersion{
+						EvaluationSetSchema: &entity.EvaluationSetSchema{
+							FieldSchemas: []*entity.FieldSchema{
+								{Name: "field1"},
+							},
+						},
+					},
+				},
 				EvalConf: &entity.EvaluationConfiguration{
 					ConnectorConf: entity.Connector{
 						TargetConf: &entity.TargetConf{
-							TargetVersionID: 456, // Different version ID should be ignored
+							TargetVersionID: 456, // Different version ID should cause error
+							IngressConf: &entity.TargetIngressConf{
+								EvalSetAdapter: &entity.FieldAdapter{
+									FieldConfs: []*entity.FieldConf{
+										{FromField: "field1"},
+									},
+								},
+							},
 						},
 					},
 				},
 			},
 			setupMocks: func(mgr *testExptManager) {
-				// No mocks needed as validation should be skipped
+				// No mocks needed
 			},
-			expectedError: false,
+			expectedError:     true,
+			expectedErrorCode: "601204001",
+			expectedErrorMsg:  "target config's version id not match",
 		},
 		{
 			name: "nil_target_should_skip_validation",