Skip to content

Commit 8923077

Browse files
authored
don't use full install target, don't install-binaries (#932)
2 parents 15638ce + 29c31d9 commit 8923077

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/SPC/builder/linux/LinuxBuilder.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ protected function buildEmbed(): void
288288
shell()->cd(SOURCE_PATH . '/php-src')
289289
->exec('sed -i "s|//lib|/lib|g" Makefile')
290290
->exec('sed -i "s|^EXTENSION_DIR = .*|EXTENSION_DIR = /' . basename(BUILD_MODULES_PATH) . '|" Makefile')
291-
->exec("make {$concurrency} INSTALL_ROOT=" . BUILD_ROOT_PATH . " {$vars} install");
291+
->exec("make {$concurrency} INSTALL_ROOT=" . BUILD_ROOT_PATH . " {$vars} install-sapi install-build install-headers install-programs");
292292

293293
$ldflags = getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS') ?: '';
294294
$libDir = BUILD_LIB_PATH;
@@ -377,12 +377,12 @@ private function getMakeExtraVars(): array
377377
$config = (new SPCConfigUtil($this, ['libs_only_deps' => true, 'absolute_libs' => true]))->config($this->ext_list, $this->lib_list, $this->getOption('with-suggested-exts'), $this->getOption('with-suggested-libs'));
378378
$static = SPCTarget::isStatic() ? '-all-static' : '';
379379
$lib = BUILD_LIB_PATH;
380-
return [
380+
return array_filter([
381381
'EXTRA_CFLAGS' => getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS'),
382382
'EXTRA_LIBS' => $config['libs'],
383383
'EXTRA_LDFLAGS' => getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS'),
384384
'EXTRA_LDFLAGS_PROGRAM' => "-L{$lib} {$static} -pie",
385-
];
385+
]);
386386
}
387387

388388
/**

src/SPC/builder/macos/MacOSBuilder.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ protected function buildEmbed(): void
267267
$vars = SystemUtil::makeEnvVarString($this->getMakeExtraVars());
268268
$concurrency = getenv('SPC_CONCURRENCY') ? '-j' . getenv('SPC_CONCURRENCY') : '';
269269
shell()->cd(SOURCE_PATH . '/php-src')
270-
->exec("make {$concurrency} INSTALL_ROOT=" . BUILD_ROOT_PATH . " {$vars} install");
270+
->exec("make {$concurrency} INSTALL_ROOT=" . BUILD_ROOT_PATH . " {$vars} install-sapi install-build install-headers install-programs");
271271

272272
if (getenv('SPC_CMD_VAR_PHP_EMBED_TYPE') === 'static') {
273273
$AR = getenv('AR') ?: 'ar';
@@ -281,10 +281,10 @@ protected function buildEmbed(): void
281281
private function getMakeExtraVars(): array
282282
{
283283
$config = (new SPCConfigUtil($this, ['libs_only_deps' => true]))->config($this->ext_list, $this->lib_list, $this->getOption('with-suggested-exts'), $this->getOption('with-suggested-libs'));
284-
return [
284+
return array_filter([
285285
'EXTRA_CFLAGS' => getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS'),
286286
'EXTRA_LDFLAGS_PROGRAM' => '-L' . BUILD_LIB_PATH,
287287
'EXTRA_LIBS' => $config['libs'],
288-
];
288+
]);
289289
}
290290
}

0 commit comments

Comments
 (0)