remove todo mentions

Author: mobula9

.github/workflows/build_package.yml

@@ -14,9 +14,6 @@
 Text Domain: crowdsec-wp
 */
 
-// TODO P2 check WP minimum compatible version + add a tag: "Requires at least: X.Y"
-// TODO P2 check WP maximum compatible version + add a tag: "Tested up to: 4.8"
-
 
 session_start();
 require_once __DIR__ . '/vendor/autoload.php';

crowdsec.php

@@ -55,11 +55,9 @@ function adminAdvancedSettings()
     addFieldSelect('crowdsec_cache_system', 'Technology', 'crowdsec_plugin_advanced_settings', 'crowdsec_advanced_settings', 'crowdsec_admin_advanced_cache', function ($input) {
         if (!in_array($input, [CROWDSEC_CACHE_SYSTEM_PHPFS, CROWDSEC_CACHE_SYSTEM_REDIS, CROWDSEC_CACHE_SYSTEM_MEMCACHED])) {
             $input = CROWDSEC_CACHE_SYSTEM_PHPFS;
-            // TODO P3 throw error
+            add_settings_error("Technology", "crowdsec_error", "Technology: Incorrect cache technology selected.");
         }
 
-        // TODO P1 big bug: fatal error when changing techno without dsn already set at previous state. Quick fix: Add error if no dsn and ask to set dsn then save then select techno.
-
         $bouncer = getBouncerInstance();
         $bouncer->clearCache();
         $message = __('Cache system changed. Previous cache data has been cleared.');
@@ -86,13 +84,11 @@ function adminAdvancedSettings()
 
     // Field "crowdsec_redis_dsn"
     addFieldString('crowdsec_redis_dsn', 'Redis DSN<br>(if applicable)', 'crowdsec_plugin_advanced_settings', 'crowdsec_advanced_settings', 'crowdsec_admin_advanced_cache', function ($input) {
-        // TODO P2 check if it's a valid DSN
         return $input;
     }, '<p>Fill in this field only if you have chosen the Redis cache.<br>Example of DSN: redis://localhost:6379.', 'redis://...', '');
 
     // Field "crowdsec_memcached_dsn"
     addFieldString('crowdsec_memcached_dsn', 'Memcached DSN<br>(if applicable)', 'crowdsec_plugin_advanced_settings', 'crowdsec_advanced_settings', 'crowdsec_admin_advanced_cache', function ($input) {
-        // TODO P2 check if it's a valid DSN
         return $input;
     }, '<p>Fill in this field only if you have chosen the Memcached cache.<br>Example of DSN: memcached://localhost:11211.', 'memcached://...', '');
 
@@ -130,7 +126,7 @@ function adminAdvancedSettings()
     addFieldSelect('crowdsec_fallback_remediation', 'Fallback to', 'crowdsec_plugin_advanced_settings', 'crowdsec_advanced_settings', 'crowdsec_admin_advanced_remediations', function ($input) {
         if (!in_array($input, Constants::ORDERED_REMEDIATIONS)) {
             $input = CROWDSEC_BOUNCING_LEVEL_DISABLED;
-            // TODO P3 throw error
+            add_settings_error("Fallback to", "crowdsec_error", "Fallback to: Incorrect Fallback selected.");
         }
         return $input;
     }, '<p>Which remediation to apply when CrowdSec advises unhandled remediation.</p>', $choice);

inc/admin/advanced-settings.php

@@ -24,7 +24,6 @@ function clearBouncerCacheInAdminPage()
 
             AdminNotice::displaySuccess($message);
 
-            // TODO P3 i18n the whole lib https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/
         } catch (WordpressCrowdSecBouncerException $e) {
             getCrowdSecLoggerInstance()->error(null, [
                 'type' => 'WP_EXCEPTION_WHILE_CLEARING_CACHE',

inc/admin/init.php

@@ -15,14 +15,12 @@ function adminSettings()
 
     // Field "crowdsec_api_url"
     addFieldString('crowdsec_api_url', 'LAPI URL', 'crowdsec_plugin_settings', 'crowdsec_settings', 'crowdsec_admin_connection', function ($input) {
-        // P2 TODO ping API to see if it's available if not: add_settings_error("LAPI URL", "crowdsec_error", "LAPI URL " . $input . " is not reachable.");
         return $input;
     }, '<p>If the CrowdSec Agent is installed on this server, you will set this field to http://localhost:8080.</p>', 'Your LAPI URL', '');
 
 
     // Field "crowdsec_api_key"
     addFieldString('crowdsec_api_key', 'Bouncer API key', 'crowdsec_plugin_settings', 'crowdsec_settings', 'crowdsec_admin_connection', function ($input) {
-        // TODO check api key format / ping api  if not: add_settings_error("LAPI URL", "crowdsec_error", "LAPI URL " . $input . " is not reachable.");
         return $input;
     }, '<p>Generated with the cscli command, ex: <em>cscli bouncers add wordpress-bouncer</em></p>', 'Your bouncer key', 'width: 280px;', 'text');
 
@@ -43,7 +41,7 @@ function adminSettings()
             CROWDSEC_BOUNCING_LEVEL_PARANOID
         ])) {
             $input = CROWDSEC_BOUNCING_LEVEL_DISABLED;
-            // TODO P3 throw error
+            add_settings_error("Bouncing level", "crowdsec_error", "Bouncing level: Incorrect bouncing level selected.");
         }
         return $input;
     }, '<p>

inc/admin/settings.php

@@ -128,7 +128,7 @@ function handleRemediation(string $remediation, string $ip)
             $remediation = $bouncer->getRemediationForIp($ip);
             handleRemediation($remediation, $ip);
         } catch (WordpressCrowdSecBouncerException $e) {
-            // TODO log error for debug mode only.
+            
         }
     }
 }

inc/bounce-current-ip.php

@@ -57,7 +57,6 @@ function getCacheAdapterInstance(string $forcedCacheSystem = null): AbstractAdap
             $redisDsn = esc_attr(get_option('crowdsec_redis_dsn'));
             if (empty($redisDsn)) {
                 throw new WordpressCrowdSecBouncerException('Redis selected but no DSN provided.');
-                // TODO P2 fix: when redis is selected and the dsn is filled at the same moment, this error is thrown or it should not be.
             }
             return new RedisAdapter(RedisAdapter::createConnection($redisDsn));
     }
@@ -101,7 +100,6 @@ function getBouncerInstance(string $forcedCacheSystem = null): Bouncer
             break;
         case CROWDSEC_BOUNCING_LEVEL_PARANOID:
             $maxRemediationLevel = Constants::REMEDIATION_BAN;
-            // TODO P2 add "minimum remediation" feature in lib + set it to ban in this case
             break;
         default:
             throw new Exception("Unknown $bouncingLevel");
@@ -116,7 +114,6 @@ function getBouncerInstance(string $forcedCacheSystem = null): Bouncer
         'api_key' => $apiKey,
         'api_url' => $apiUrl,
         'api_user_agent' => CROWDSEC_BOUNCER_USER_AGENT,
-        //'api_timeout' => null // TODO P3 make a advanced settings
         'live_mode' => !$isStreamMode,
         'max_remediation_level' => $maxRemediationLevel,
         'fallback_remediation' => $fallbackRemediation,

inc/bouncer-instance.php

@@ -15,4 +15,4 @@
 define('CROWDSEC_CAPTCHA_TECHNOLOGY_LOCAL', "local");
 define('CROWDSEC_CAPTCHA_TECHNOLOGY_RECAPTCHA', "recaptcha");
 
-define('CROWDSEC_BOUNCER_USER_AGENT', "Wordpress CrowdSec Bouncer/0.0.1");// TODO P1 SET THE CORRECT VERSION ON BUILD
+define('CROWDSEC_BOUNCER_USER_AGENT', "Wordpress CrowdSec Bouncer/0.0.1");

inc/constants.php

@@ -4,7 +4,6 @@
 define('CROWDSEC_REFRESH_BLOCKLIST_CRON_INTERVAL', 'crowdsec_refresh_blocklist_cron_interval');
 
 // Create a WP custom cron interval (ovewrite previous if any).
-// TODO P3 create get_bool_option / get_int_option / get_string_option etc to sanitize theme all.
 add_filter('cron_schedules', function ($schedules) {
     $refreshFrequency = (int)get_option("crowdsec_stream_mode_refresh_frequency");
     if ($refreshFrequency > 0) {
@@ -22,7 +21,6 @@ function crowdSecRefreshBlocklist()
         $bouncer = getBouncerInstance();
         $bouncer->refreshBlocklistCache();
     } catch (WordpressCrowdSecBouncerException $e) {
-        // TODO log error for debug mode only.
     }
 }
 

inc/scheduling.php

@@ -6,6 +6,4 @@
 
  if ( ! defined ( 'WP_UNINSTALL_PLUGIN' )) {
      die;
- }
-
- // TODO P3 if we don't deactivate before deleting, are the wp_option delete ? test this case.
+ }