test(e2e): Add end to end test for captcha flow and display error setting

Author: julienloizelet

.github/workflows/end-to-end-auto-prepend-test-suite.yml

@@ -103,6 +103,7 @@ jobs:
       - name: Prepare for playwright test
         run: |
           cd ${{ github.workspace }}
+          cp .ddev/custom_files/crowdsec/php/cache-actions.php cache-actions.php
           cp -r .ddev/custom_files/crowdsec/cfssl/* my-own-modules/${{ env.EXTENSION_PATH }}/tls
           cd my-own-modules/${{ env.EXTENSION_PATH }}
           docker cp "tls" ddev-${{ env.WP_VERSION_CODE }}-playwright://var/www/html/wp-content/plugins/crowdsec

.github/workflows/end-to-end-test-suite.yml

@@ -103,6 +103,7 @@ jobs:
       - name: Prepare for playwright test
         run: |
           cd ${{ github.workspace }}
+          cp .ddev/custom_files/crowdsec/php/cache-actions.php cache-actions.php
           cp -r .ddev/custom_files/crowdsec/cfssl/* my-own-modules/${{ env.EXTENSION_PATH }}/tls
           cd my-own-modules/${{ env.EXTENSION_PATH }}
           docker cp "tls" ddev-${{ env.WP_VERSION_CODE }}-playwright://var/www/html/wp-content/plugins/crowdsec

docs/DEVELOPER.md

@@ -150,6 +150,14 @@ As we use a TLS ready CrowdSec container, you have first to copy some certificat
 cd wp-sources
 cp -r .ddev/custom_files/crowdsec/cfssl/* wp-content/plugins/crowdsec/tls
 ```
+And we use also a custom php script to make some cache test. Thus, you should copy this php script too in the root 
+folder: 
+
+```bash
+cd wp-sources
+cp  .ddev/custom_files/crowdsec/php/cache-actions.php cache-actions.php
+```
+
 
 Then, ensure that `run-tests.sh` and `test-init.sh` files are executable.
 

inc/bounce-current-ip.php

@@ -30,7 +30,7 @@ function safelyBounceCurrentIp()
                               '(line ' . $e->getLine() . ')', true
             ));
         }
-        $displayErrors = $crowdSecConfigs['crowdsec_display_errors'] ?? false;
+        $displayErrors =  (bool)($crowdSecConfigs['crowdsec_display_errors'] ?? false);
         if (true === $displayErrors) {
             throw new BouncerException($e->getMessage(), $e->getCode(), $e);
         }

inc/options-config.php

@@ -1,7 +1,7 @@
 <?php
 require_once __DIR__ . '/Constants.php';
 
-function getCrowdSecOptionsConfig()
+function getCrowdSecOptionsConfig(): array
 {
     return [
         ['name' => 'crowdsec_api_url', 'default' => '', 'autoInit' => true],

inc/standalone-bounce.php

@@ -25,7 +25,7 @@
                           '(line ' . $e->getLine() . ')', true
         ));
     }
-    $displayErrors = $crowdSecConfigs['crowdsec_display_errors'] ?? false;
+    $displayErrors =  (bool)($crowdSecConfigs['crowdsec_display_errors'] ?? false);
     if (true === $displayErrors) {
         throw new BouncerException($e->getMessage(), $e->getCode(), $e);
     }

tests/e2e-ddev/__scripts__/run-tests.sh

@@ -60,10 +60,10 @@ case $TYPE in
     COMMAND="yarn --cwd ${YARN_PATH} cross-env"
     LAPI_URL_FROM_PLAYWRIGHT=https://${CROWDSEC_URL_FROM_HOST}
     CURRENT_IP=$(ddev find-ip host)
-    TIMEOUT=31000
+    TIMEOUT=60000
     HEADLESS=false
     SLOWMO=150
-    PLUGIN_PATH="../../../../wp-content/plugins/crowdsec"
+    PLUGIN_PATH="../../"
     ;;
 
   "docker")
@@ -72,7 +72,7 @@ case $TYPE in
     COMMAND="ddev exec -s playwright yarn --cwd ${YARN_PATH} cross-env"
     LAPI_URL_FROM_PLAYWRIGHT=https://crowdsec:8080
     CURRENT_IP=$(ddev find-ip playwright)
-    TIMEOUT=31000
+    TIMEOUT=60000
     HEADLESS=true
     SLOWMO=0
     PLUGIN_PATH="/var/www/html/wp-content/plugins/crowdsec"