Skip to content

Commit 2b01727

Browse files
authored
Merge pull request #277 from jonashger/main
2 parents fa1cfe4 + 2d8efd3 commit 2b01727

File tree

3 files changed

+34
-10
lines changed

3 files changed

+34
-10
lines changed

package-lock.json

Lines changed: 28 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"@babel/preset-typescript": "^7.22.5",
6969
"@chakra-ui/babel-plugin": "^1.0.8",
7070
"@chakra-ui/form-control": "^2.1.0",
71-
"@chakra-ui/icon": "^3.1.0",
71+
"@chakra-ui/icon": "^3.2.0",
7272
"@chakra-ui/layout": "^2.3.0",
7373
"@chakra-ui/media-query": "^3.3.0",
7474
"@chakra-ui/menu": "^2.2.0",

src/chakra-components/menu.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import React from "react";
2-
import type { IconProps } from "@chakra-ui/icon";
3-
import Icon from "@chakra-ui/icon";
42
import { Box } from "@chakra-ui/layout";
53
import { Menu as ChakraMenu, MenuIcon } from "@chakra-ui/menu";
6-
import type { SystemStyleObject } from "@chakra-ui/system";
4+
import type { PropsOf, SystemStyleObject } from "@chakra-ui/system";
75
import { useColorModeValue, useMultiStyleConfig } from "@chakra-ui/system";
86
import type {
97
CoercedMenuPlacement,
@@ -336,15 +334,15 @@ export const GroupHeading = <
336334
/**
337335
* The `CheckIcon` component from the Chakra UI Menu
338336
*
339-
* @see {@link https://github.com/chakra-ui/chakra-ui/blob/13c6d2e08b61e179773be4722bb81173dd599306/packages/menu/src/menu.tsx#L314}
337+
* @see {@link https://github.com/chakra-ui/chakra-ui/blob/eb0316ddf96dd259433724062e923c33e6eee729/packages/components/menu/src/menu-item-option.tsx#L10-L17}
340338
*/
341-
const CheckIcon = (props: IconProps) => (
342-
<Icon viewBox="0 0 14 14" w="1em" h="1em" {...props}>
339+
const CheckIcon: React.FC<PropsOf<"svg">> = (props) => (
340+
<svg viewBox="0 0 14 14" width="1em" height="1em" {...props}>
343341
<polygon
344342
fill="currentColor"
345343
points="5.5 11.9993304 14 3.49933039 12.5 2 5.5 8.99933039 1.5 4.9968652 0 6.49933039"
346344
/>
347-
</Icon>
345+
</svg>
348346
);
349347

350348
export const Option = <

0 commit comments

Comments
 (0)