Multiple Condition Symbols

[jmseguin]

I like the module.
Would it be possible to allow an array of symbols to be passed?
On complicated projects, esp with more than one contributor, it would be convenient to have an array of symbols that would be parsed.

[cssho]

@jmseguin
Is this the kind of case you are referring to?

md-condition/test.py

Lines 64 to 80 in 6ea0d01

	def test_double(self):
	md_input = """\
	# 1
	<!--- #if DEBUG RELEASE -->
	DEBUG RELEASE
	<!--- #endif -->
	# 2
	<!--- #if RELEASE -->
	RELEASE
	<!--- #endif -->
	# 3"""
	expected_result = """\
	<h1>1</h1>
	<p>DEBUG RELEASE</p>
	<h1>2</h1>
	<h1>3</h1>"""
	self.assertExpectedMarkdown(md_input, expected_result)

[kamal-ahmed-emphysys]

I was looking at this more as similar to conditional compilation of code. So if an array of symbols is defined then each one of them can be used as a condition. So for example, if the configuration is:

markdown_extensions:
  - md_condition:
      symbol: DEBUG RELEASE

Then the following:

#1
<!--- #if DEBUG  --> 
             DEBUG 
<!--- #else -->
             No DEBUG
<!--- #endif --> 
#2
<!--- #if RELEASE --> 
             RELEASE 
<!--- #else -->
             No RELEASE
<!--- #endif -->
#3 

Will result in:

<h1>1</h1> 
<p>DEBUG</p> 
<h1>2</h1> 
<p>RELEASE</p> 
<h1>3</h1>""" 

With DEBUG not defined (symbol: RELEASE) will result in:

<h1>1</h1> 
<p>No DEBUG</p> 
<h1>2</h1> 
<p>RELEASE</p> 
<h1>3</h1>""" 

With RELEASE not defined (symbol: DEBUG) will result in:

<h1>1</h1> 
<p>DEBUG</p> 
<h1>2</h1> 
<p>No RELEASE</p> 
<h1>3</h1>""" 

With both not defined: (symbol: ) will result in:

<h1>1</h1> 
<p>No DEBUG</p> 
<h1>2</h1> 
<p>No RELEASE</p> 
<h1>3</h1>""" 

Unlike conditional compilation of code, I am fine with the limitation that more complex conditional logic (combinatorial logic combining "AND" and "OR" for symbols) is not supported.

[kamal-ahmed-emphysys]

I was looking at this more as similar to conditional compilation of code. So if an array of symbols is defined then each one of them can be used as a condition. So for example, if the configuration is:

markdown_extensions:
  - md_condition:
      symbol: DEBUG RELEASE

Then the following:

#1
<!--- #if DEBUG  --> 
             DEBUG 
<!--- #else -->
             No DEBUG
<!--- #endif --> 
#2
<!--- #if RELEASE --> 
             RELEASE 
<!--- #else -->
             No RELEASE
<!--- #endif -->
#3 

Will result in:

<h1>1</h1> 
<p>DEBUG</p> 
<h1>2</h1> 
<p>RELEASE</p> 
<h1>3</h1>""" 

With DEBUG not defined (symbol: RELEASE) will result in:

<h1>1</h1> 
<p>No DEBUG</p> 
<h1>2</h1> 
<p>RELEASE</p> 
<h1>3</h1>""" 

With RELEASE not defined (symbol: DEBUG) will result in:

<h1>1</h1> 
<p>DEBUG</p> 
<h1>2</h1> 
<p>No RELEASE</p> 
<h1>3</h1>""" 

With both not defined: (symbol: ) will result in:

<h1>1</h1> 
<p>No DEBUG</p> 
<h1>2</h1> 
<p>No RELEASE</p> 
<h1>3</h1>""" 

Unlike conditional compilation of code, I am fine with the limitation that more complex conditional logic (combinatorial logic combining "AND" and "OR" for symbols) is not supported.

I have updated the implementation and unit tests to handle this. LMK if you want me to commit this change and open a pull request. Either way, it works for me.

[cssho]

@kamal-ahmed-emphysys
Thank you for the detailed proposal and especially for going ahead with the implementation and unit tests!
Yes, please definitely commit your changes and open a pull request! I'd be happy to review it.