Skip to content

Commit 1b84b3a

Browse files
committed
ASoC: fsl_sai: replace regmap_write with regmap_update_bits
JIRA: https://issues.redhat.com/browse/RHEL-118908 commit 0e270f3 Author: Shengjiu Wang <shengjiu.wang@nxp.com> Date: Thu Aug 7 10:03:18 2025 +0800 ASoC: fsl_sai: replace regmap_write with regmap_update_bits Use the regmap_write() for software reset in fsl_sai_config_disable would cause the FSL_SAI_CSR_BCE bit to be cleared. Refer to commit 197c53c ("ASoC: fsl_sai: Don't disable bitclock for i.MX8MP") FSL_SAI_CSR_BCE should not be cleared. So need to use regmap_update_bits() instead of regmap_write() for these bit operations. Fixes: dc78f7e ("ASoC: fsl_sai: Force a software reset when starting in consumer mode") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Link: https://patch.msgid.link/20250807020318.2143219-1-shengjiu.wang@nxp.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Jaroslav Kysela <jkysela@redhat.com>
1 parent d8b0fc2 commit 1b84b3a

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

sound/soc/fsl/fsl_sai.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -809,9 +809,9 @@ static void fsl_sai_config_disable(struct fsl_sai *sai, int dir)
809809
* are running concurrently.
810810
*/
811811
/* Software Reset */
812-
regmap_write(sai->regmap, FSL_SAI_xCSR(tx, ofs), FSL_SAI_CSR_SR);
812+
regmap_update_bits(sai->regmap, FSL_SAI_xCSR(tx, ofs), FSL_SAI_CSR_SR, FSL_SAI_CSR_SR);
813813
/* Clear SR bit to finish the reset */
814-
regmap_write(sai->regmap, FSL_SAI_xCSR(tx, ofs), 0);
814+
regmap_update_bits(sai->regmap, FSL_SAI_xCSR(tx, ofs), FSL_SAI_CSR_SR, 0);
815815
}
816816

817817
static int fsl_sai_trigger(struct snd_pcm_substream *substream, int cmd,
@@ -930,11 +930,11 @@ static int fsl_sai_dai_probe(struct snd_soc_dai *cpu_dai)
930930
unsigned int ofs = sai->soc_data->reg_offset;
931931

932932
/* Software Reset for both Tx and Rx */
933-
regmap_write(sai->regmap, FSL_SAI_TCSR(ofs), FSL_SAI_CSR_SR);
934-
regmap_write(sai->regmap, FSL_SAI_RCSR(ofs), FSL_SAI_CSR_SR);
933+
regmap_update_bits(sai->regmap, FSL_SAI_TCSR(ofs), FSL_SAI_CSR_SR, FSL_SAI_CSR_SR);
934+
regmap_update_bits(sai->regmap, FSL_SAI_RCSR(ofs), FSL_SAI_CSR_SR, FSL_SAI_CSR_SR);
935935
/* Clear SR bit to finish the reset */
936-
regmap_write(sai->regmap, FSL_SAI_TCSR(ofs), 0);
937-
regmap_write(sai->regmap, FSL_SAI_RCSR(ofs), 0);
936+
regmap_update_bits(sai->regmap, FSL_SAI_TCSR(ofs), FSL_SAI_CSR_SR, 0);
937+
regmap_update_bits(sai->regmap, FSL_SAI_RCSR(ofs), FSL_SAI_CSR_SR, 0);
938938

939939
regmap_update_bits(sai->regmap, FSL_SAI_TCR1(ofs),
940940
FSL_SAI_CR1_RFW_MASK(sai->soc_data->fifo_depth),
@@ -1824,11 +1824,11 @@ static int fsl_sai_runtime_resume(struct device *dev)
18241824

18251825
regcache_cache_only(sai->regmap, false);
18261826
regcache_mark_dirty(sai->regmap);
1827-
regmap_write(sai->regmap, FSL_SAI_TCSR(ofs), FSL_SAI_CSR_SR);
1828-
regmap_write(sai->regmap, FSL_SAI_RCSR(ofs), FSL_SAI_CSR_SR);
1827+
regmap_update_bits(sai->regmap, FSL_SAI_TCSR(ofs), FSL_SAI_CSR_SR, FSL_SAI_CSR_SR);
1828+
regmap_update_bits(sai->regmap, FSL_SAI_RCSR(ofs), FSL_SAI_CSR_SR, FSL_SAI_CSR_SR);
18291829
usleep_range(1000, 2000);
1830-
regmap_write(sai->regmap, FSL_SAI_TCSR(ofs), 0);
1831-
regmap_write(sai->regmap, FSL_SAI_RCSR(ofs), 0);
1830+
regmap_update_bits(sai->regmap, FSL_SAI_TCSR(ofs), FSL_SAI_CSR_SR, 0);
1831+
regmap_update_bits(sai->regmap, FSL_SAI_RCSR(ofs), FSL_SAI_CSR_SR, 0);
18321832

18331833
ret = regcache_sync(sai->regmap);
18341834
if (ret)

0 commit comments

Comments
 (0)