Skip to content

chore: parameterize persist artifacts #32972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cacieprins wants to merge 6 commits into
base: develop
Choose a base branch
from
+13 −3
Open

chore: parameterize persist artifacts #32972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e7c24f
use pipeline param in pull requests to override artifact persistence
cacieprins Nov 17, 2025
05bafcd
fix jq err when triggering pipeline
cacieprins Nov 18, 2025
de9daa8
simplify parameter usage
cacieprins Nov 18, 2025
dd6e949
Merge branch 'develop' into ci/parameterize-persist-artifacts
cacieprins Nov 19, 2025
b60b46a
Merge branch 'develop' into ci/parameterize-persist-artifacts
cacieprins Nov 24, 2025
1f79368
Update config.yml
cacieprins Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ parameters:
publish-binary-branch:
type: string
default: main
force-persist-artifacts:
type: boolean
default: false

commands:
persist:
Expand Down
13 changes: 10 additions & 3 deletions .circleci/src/pipeline/@pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ parameters:
publish-binary-branch:
type: string
default: main
force-persist-artifacts:
type: boolean
default: false

orbs:
browser-tools: circleci/browser-tools@2.3.1
Expand Down Expand Up @@ -121,9 +124,13 @@ commands:
name: Set environment variable to determine whether or not to persist artifacts
command: |
echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "fix/angular_dep_resolution_windows" ]]; then
export SHOULD_PERSIST_ARTIFACTS=true
fi' >> "$BASH_ENV"
if [[ "<< pipeline.parameters.force-persist-artifacts >>" == "true" ]]; then
echo 'export SHOULD_PERSIST_ARTIFACTS=true' >> "$BASH_ENV"
else
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* ]]; then
export SHOULD_PERSIST_ARTIFACTS=true
fi' >> "$BASH_ENV"
fi
# You must run `setup_should_persist_artifacts` command and be using bash before running this command
verify_should_persist_artifacts:
steps:
Expand Down
Loading