Skip to content

fix: handleInvalidTarget breaks the removeAttribute function (#26206) #33051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-shehane merged 5 commits into from
Dec 8, 2025
+36 −3
Merged

fix: handleInvalidTarget breaks the removeAttribute function (#26206) #33051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b44a4c5
add test for #26206
SteffenDE Dec 2, 2025
09b2c63
fix: handleInvalidTarget breaks the removeAttribute function (#26206)
jodysalt Jul 16, 2023
a011ae5
fix linter and move comment
SteffenDE Dec 3, 2025
d16ac5b
Merge branch 'develop' into pr/33051
jennifer-shehane Dec 8, 2025
212d966
add changelog entry
jennifer-shehane Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ _Released 12/16/2025 (PENDING)_
- Fixed an issue where the browser would freeze when Cypress intercepts a synchronous XHR request and a `routeHandler` is used. Fixes [#32874](https://github.com/cypress-io/cypress/issues/32874). Addressed in [#32925](https://github.com/cypress-io/cypress/pull/32925).
- Fixed an issue where `Next.js` Component Testing would not load correctly without a TypeScript-based Next config in versions 16.0.3 and up. Fixes [#32968](https://github.com/cypress-io/cypress/issues/32968).
- Fixed an issue where the error message for `not.have.length` was not correctly displaying the expected length in the Command Log. Addressed in [#18927](https://github.com/cypress-io/cypress/issues/18927).
- Fixed an issue where `removeAttribute()` would not work for attributes other than `target` on anchor or form elements after clicking links with `target="_top"` or `target="_parent"`. Fixes [#26206](https://github.com/cypress-io/cypress/issues/26206). Addressed in [#33051](https://github.com/cypress-io/cypress/pull/33051).

## 15.7.1

Expand Down
14 changes: 14 additions & 0 deletions packages/driver/cypress/e2e/issues/26206.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// https://github.com/cypress-io/cypress/issues/26206
describe('issue 26206', () => {
beforeEach(() => {
cy.visit('fixtures/issue-26206.html')
})

it('removeAttribute works for non-target attributes after handleInvalidTarget', () => {
// After clicking an anchor with target="_top", the handleInvalidTarget function
// patches the element's removeAttribute. The bug was that removeAttribute
// would not work for attributes other than 'target'.
cy.get('#link').click()
cy.get('#result').should('have.text', 'removed')
})
})
18 changes: 18 additions & 0 deletions packages/driver/cypress/fixtures/issue-26206.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>
<html lang="en">
<head>
</head>
<body>
<script>
function removeNonTargetAttribute(e) {
e.target.removeAttribute('data-bar')
document.getElementById('result').innerHTML = e.target.hasAttribute('data-bar') ? 'has-attribute' : 'removed'
}
</script>

<div>
<a href="#" id="link" target="_top" data-bar="baz" onclick="removeNonTargetAttribute(event)">link</a>
<div id="result"></div>
</div>
</body>
</html>
6 changes: 3 additions & 3 deletions packages/driver/src/cy/top_attr_guards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ export function handleInvalidTarget (el: HTMLFormElement | HTMLAnchorElement) {
if (k === 'target') {
targetSet = false
targetValue = ''

// We're not using `$elements.callNativeMethod` here because it disallows `removeAttribute`.
return removeAttribute.call(this, k)
}

// We're not using `$elements.callNativeMethod` here because it disallows `removeAttribute`.
return removeAttribute.call(this, k)
}

if (!targetDescriptor) {
Expand Down