fix: sonar issues

Author: d0whc3r

src/lib/auth-vue-store-manager.ts

@@ -50,14 +50,14 @@ export default class AuthStoreManager extends VueAuthStore {
   public getToken(): string {
     const token = this.allStores
       .map((store) => store.getToken())
-      .filter((token) => !!token)[0];
+      .filter(Boolean)[0];
     return token || this.options.Vue.$data.token;
   }
 
   public getUser(): AuthUser {
     const user = this.allStores
       .map((store) => store.getUser())
-      .filter((user) => !!user)[0];
+      .filter(Boolean)[0];
     return user || this.options.Vue.$data.user;
   }
 

src/lib/auth.ts

@@ -53,11 +53,11 @@ export default class Auth {
   private readonly http: AuthVueHttp;
   private readonly storeManager: AuthStoreManager;
 
-  constructor(private readonly Vue: any, options: VueAuthOptions = {} as VueAuthOptions) {
+  constructor(private readonly VueInstance: any, options: VueAuthOptions = {} as VueAuthOptions) {
     this.options = {
       ...DEFAULT_OPTIONS,
       ...options,
-      Vue: new this.Vue({
+      Vue: new this.VueInstance({
         data() {
           return {
             user: null,
@@ -66,9 +66,9 @@ export default class Auth {
         },
       }),
     };
-    this.storeManager = new AuthStoreManager(this.Vue, this.options);
-    const router = new AuthVueRouter(this.Vue, this.options, this.storeManager);
-    this.http = new AuthVueHttp(this.Vue, this.options, this.storeManager, router);
+    this.storeManager = new AuthStoreManager(this.VueInstance, this.options);
+    const router = new AuthVueRouter(this.VueInstance, this.options, this.storeManager);
+    this.http = new AuthVueHttp(this.VueInstance, this.options, this.storeManager, router);
   }
 
   public login(loginInfo: VueAuthLogin) {

src/lib/store/store-cookie.ts

@@ -15,7 +15,7 @@ export default class StoreCookie extends VueAuthStore {
       } else if (typeof document.cookie === 'string') {
         this.documentCookie = true;
       }
-    } catch (_) {
+    } catch {
       console.warn('[vue-auth-plugin]: Cookie store not enabled');
       this.enabled = false;
     }
@@ -62,15 +62,16 @@ export default class StoreCookie extends VueAuthStore {
       const cookiePair = document.cookie.replace(/;\s+/g, ';')
         .split(';')
         .map((str) => str.replace(/\s+=\s+/g, '=').split('='))
-        .filter((cookiePair) => cookiePair[0] === name)
+        .filter((cp) => cp[0] === name)
         .pop() || [];
       result = cookiePair[1] || null;
     }
     try {
       return JSON.parse(result);
-    } catch (_) {
-      return result;
+    } catch {
+      console.error('[vue-auth-plugin] Invalid cookie value');
     }
+    return result;
   }
 
   private setCookie(name: string | undefined, value: any) {

tests/integration/customToken.spec.ts

@@ -62,7 +62,7 @@ describe('With customToken', () => {
       const response = await localVue.$auth.login({ username: 'test', password: 'test' });
       expect(response).toBeTruthy();
       expect(localVue.$auth.token()).toEqual(sampleToken);
-    } catch (_) {
+    } catch {
       fail('Login is good');
     }
   });

tests/integration/functions.spec.ts

@@ -108,7 +108,7 @@ describe('Functions', () => {
       try {
         const response = await localVue.$auth.login({ username: 'test', password: 'test' });
         expect(response).toBeTruthy();
-      } catch (_) {
+      } catch {
         fail('Login is good');
       }
     });
@@ -217,7 +217,7 @@ describe('Functions', () => {
       const response = await localVue.$auth.login({ username: 'test', password: 'test' });
       expect(response).toBeTruthy();
       expect(spyFetch).toHaveBeenCalledTimes(1);
-    } catch (_) {
+    } catch {
       fail('Login is good');
     }
   });
@@ -240,7 +240,7 @@ describe('Functions', () => {
         const response = await localVue.$auth.login({ username: 'test', password: 'test' });
         expect(response).toBeTruthy();
         expect(spyFetch).toHaveBeenCalledTimes(1);
-      } catch (_) {
+      } catch {
         fail('Login is good');
       }
     });