Skip to content

Commit 837b912

Browse files
committed
Remove completed todo items.
1 parent fabe587 commit 837b912

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

Todo.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,6 @@
22
The selector string provided by user should be sanitized. Take a look at Ryan's
33
PageService module to get clue on how to properly do that.
44

5-
#### Template name incompatibility
6-
We map ProcessWire templates as types in GraphQL and create fields that corrspond
7-
to them. The name of those fields are the names of the templates. While ProcessWire
8-
allows us to create template names that start with numbers and has '-' symbol in it
9-
while GraphQL does not allows that. Thus we need to make sure user cannot assign
10-
incompatible templates names as legalTemplates in ProcessGraphQL by disabling the
11-
checkbox choice for the incompatible templates and adding some note for user describing
12-
what's happening. We alos need to track the template name change and remove the templates
13-
from legalTemplates when their name change to incompatible ones.
14-
15-
#### Template name collision
16-
We provide additional fields with our GraphQL api like `me`, `debug`, `pages` and
17-
probably more. Those names will be overwritten by template fields that has the same
18-
name. This should be prevented or at least the user should be warned about it.
19-
There probably should be list of reserved words for it, to prevent breaking changes
20-
in the future.
21-
225
#### N+1 Problem
236
It is very convinient to request additional data for Page fields. E.g. request skyscraper'same
247
title, year, height and also request title for each page in architect field. While this works

0 commit comments

Comments
 (0)