Make sure success responses never have errors in them.

Author: dadish

test/Field/Auth/LoginFieldTest.php

@@ -32,7 +32,7 @@ public function testLoginSuccess()
     }";
     $res = self::execute($query);
     assertEquals(200, $res->data->login->statusCode, 'Unable to login via GraphQL');
-    assertFalse(isset($res->errors), 'There are errors.');
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
   public function testLoginFailure()
@@ -47,7 +47,7 @@ public function testLoginFailure()
     }";
     $res = self::execute($query);
     assertEquals(401, $res->data->login->statusCode, 'Unable to login via GraphQL');
-    assertFalse(isset($res->errors), 'There are errors.');
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }

test/Field/Auth/LogoutFieldTest.php

@@ -26,6 +26,7 @@ public function testLogout()
     }';
     $res = self::execute($query);
     assertEquals(200, $res->data->logout->statusCode, 'Unable to logout via GraphQL');
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
   public function testLogoutFailure()

test/Field/Debug/DbQueryCountFieldTest.php

@@ -29,6 +29,7 @@ public function testUnavailable()
     }';
     $res = self::execute($query);
     assertObjectHasAttribute('errors', $res, 'When debug turned off, `dbQueryCount` field must be unavailable.');
+    assertStringContainsString('dbQuery', $res->errors[0]->message, 'Incorrect error message.');
   }
 
   public function testValue()
@@ -39,6 +40,7 @@ public function testValue()
     }';
     $res = self::execute($query);
     assertEquals(count(\ProcessWire\Database::getQueryLog()), count($res->data->dbQuery), '`dbQueryCount` must return the number of db query logs');
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }

test/Field/Mutation/CreatePage/CaseThreeTest.php

@@ -37,6 +37,7 @@ public function testValue()
   	$res = self::execute($query, $variables);
     $newBuildingSky = Utils::pages()->get("name=created-building-sky");
     assertEquals($variables['page']['name'], $res->data->skyscraper->name, 'createSkyscraper returns correct values in response.');
-  	assertEquals($newBuildingSky->id, $res->data->skyscraper->id, 'createSkyscraper creates skyscraper page if everything is ok.');
+		assertEquals($newBuildingSky->id, $res->data->skyscraper->id, 'createSkyscraper creates skyscraper page if everything is ok.');
+		assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 }

test/Field/Mutation/UpdatePage/CaseThreeTest.php

@@ -43,7 +43,8 @@ public function testValue()
   	];
     $res = self::execute($query, $variables);
     assertEquals($variables['page']['title'], $res->data->skyscraper->title, 'updateSkyscraper returns updated value of the `title`.');
-  	assertEquals($variables['page']['title'], $skyscraper->title, 'updateSkyscraper updates value of the `title`.');
+    assertEquals($variables['page']['title'], $skyscraper->title, 'updateSkyscraper updates value of the `title`.');
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }

test/Field/Page/Fieldtype/FieldtypeCheckbox/FieldtypeCheckboxTest.php

@@ -44,6 +44,7 @@ public function testFalsyValue()
     }";
     $res = $this->execute($query);
     assertTrue($res->data->skyscraper->list[0]->featured);
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }

test/Field/Page/Fieldtype/FieldtypeDatetime/CaseOneTest.php

@@ -35,6 +35,7 @@ public function testValue()
     }";
     $res = self::execute($query);
     assertEquals($architect->born, $res->data->architect->list[0]->born, 'Retrieves datetime value.');
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }

test/Field/Page/Fieldtype/FieldtypeDatetime/CaseThreeTest.php

@@ -40,6 +40,7 @@ public function testValue()
       $res->data->architect->list[0]->born,
       'Formats datetime value correctly via format argument.'
     );
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }

test/Field/Page/Fieldtype/FieldtypeDatetime/CaseTwoTest.php

@@ -44,6 +44,7 @@ public function testValue()
       $res->data->architect->list[0]->born,
       'Retrieves correctly formatted datetime value.'
     );
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }

test/Field/Page/Fieldtype/FieldtypeEmail/FieldtypeEmailTest.php

@@ -29,7 +29,8 @@ public function testValue()
   		}
     }";
     $res = self::execute($query);
-  	assertEquals($architect->email, $res->data->architect->list[0]->email, 'Retrieves email value.');
+    assertEquals($architect->email, $res->data->architect->list[0]->email, 'Retrieves email value.');
+    assertObjectNotHasAttribute('errors', $res, 'There are errors.');
   }
 
 }