Windows: PSLP fails to build with MSVC

[ZedongPeng]

On Windows, CMake often picks MSVC by default (e.g., Visual Studio generator). PSLP doesn’t compile with MSVC.

Related issue: MIT-Lu-Lab/cuPDLPx#67

[LucasBoTang]

I can confirm this issue on Windows when building with clang and the MSVC toolchain. The underlying cause is that PSLP relies on POSIX-only APIs such as <pthread.h> and <getopt.h>, which are not available by default on Windows.

[dance858]

Interesting, thank you for reporting this. I'll look into it.

[dance858]

Version 0.0.5 of PSLP should support windows. If not, please reopen this.

[ZedongPeng]

The current build failed.

$ cmake --build build --clean-first
[  2%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Activity.c.o
[  5%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Constraints.c.o
[  7%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/CoreTransformation.c.o
[ 10%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Locks.c.o
[ 12%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Matrix.c.o
[ 15%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Postsolver.c.o
[ 17%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Presolver.c.o
[ 20%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Problem.c.o
[ 23%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/State.c.o
[ 25%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Tags.c.o
[ 28%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/Workspace.c.o
[ 30%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/core/utils.c.o
[ 33%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/explorers/DtonsEq.c.o
[ 35%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/explorers/Parallel_cols.c.o
[ 38%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/explorers/Parallel_rows.c.o
[ 41%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/explorers/Primal_propagation.c.o
[ 43%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/explorers/SimpleReductions.c.o
[ 46%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/explorers/Simple_dual_fix.c.o
[ 48%] Building C object _deps/pslp-build/CMakeFiles/PSLP.dir/src/explorers/StonCols.c.o
[ 51%] Linking C shared library libPSLP.so
[ 51%] Built target PSLP
[ 53%] Building C object CMakeFiles/cupdlpx_core.dir/src/cupdlpx.c.o
In file included from /home/zdpeng/github/cuPDLPx/include/cupdlpx_types.h:19,
                 from /home/zdpeng/github/cuPDLPx/include/cupdlpx.h:19,
                 from /home/zdpeng/github/cuPDLPx/src/cupdlpx.c:17:
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:24:5: error: unknown type name 'size_t'
   24 |     size_t n_rows_original;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:25:5: error: unknown type name 'size_t'
   25 |     size_t n_cols_original;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:26:5: error: unknown type name 'size_t'
   26 |     size_t nnz_original;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:27:5: error: unknown type name 'size_t'
   27 |     size_t n_rows_reduced;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:28:5: error: unknown type name 'size_t'
   28 |     size_t n_cols_reduced;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:29:5: error: unknown type name 'size_t'
   29 |     size_t nnz_reduced;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:32:5: error: unknown type name 'size_t'
   32 |     size_t nnz_removed_trivial;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:33:5: error: unknown type name 'size_t'
   33 |     size_t nnz_removed_fast;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:34:5: error: unknown type name 'size_t'
   34 |     size_t nnz_removed_primal_propagation;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:35:5: error: unknown type name 'size_t'
   35 |     size_t nnz_removed_parallel_rows;
      |     ^~~~~~
/home/zdpeng/github/cuPDLPx/build/_deps/pslp-src/include/PSLP/PSLP_stats.h:36:5: error: unknown type name 'size_t'
   36 |     size_t nnz_removed_parallel_cols;
      |     ^~~~~~
gmake[2]: *** [CMakeFiles/cupdlpx_core.dir/build.make:76: CMakeFiles/cupdlpx_core.dir/src/cupdlpx.c.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:106: CMakeFiles/cupdlpx_core.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2

[ZedongPeng]

I don't have the permission to reopen the issue.

[dance858]

@ZedongPeng

Sorry. That was embarrasing. Can you try again with version 0.0.6?

[dance858]

@ZedongPeng @LucasBoTang

Just checking in to see if you have had time to try PSLP version 0.0.6 yet to see that it builds with windows?

Many thanks

[ZedongPeng]

Hi @dance858 . We are still working on it. You can follow the progress here.
MIT-Lu-Lab/cuPDLPx#75

[dance858]

Thanks for working on it @ZedongPeng.

I'm closing this issue now, because I think it has been fixed (at least according to my workflows). If it still doesn't work, please let me know.

Many thanks!