From 4705d0deed17f3aadb7f84477e0af181fbdea615 Mon Sep 17 00:00:00 2001 From: Anthony Merle <107677848+gsl-anthonymerle@users.noreply.github.com> Date: Wed, 4 Jun 2025 15:22:14 +0200 Subject: [PATCH 1/7] Update File.swift Add xctestplan file extension --- Sources/Danger/File.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/Danger/File.swift b/Sources/Danger/File.swift index 733e98ec..67740898 100644 --- a/Sources/Danger/File.swift +++ b/Sources/Danger/File.swift @@ -19,7 +19,7 @@ public extension File { public enum FileType: String, Equatable, CaseIterable { // swiftlint:disable:next identifier_name - case h, json, m, markdown = "md", mm, pbxproj, plist, storyboard, swift, xcscheme, yaml, yml + case h, json, m, markdown = "md", mm, pbxproj, plist, storyboard, swift, xcscheme, yaml, yml, xctestplan } // MARK: - FileType extensions From 6d2f55b07e5e9a9cfb759ed9bb1cab6198929779 Mon Sep 17 00:00:00 2001 From: Anthony Merle <107677848+gsl-anthonymerle@users.noreply.github.com> Date: Wed, 4 Jun 2025 15:25:15 +0200 Subject: [PATCH 2/7] Update FileTests.swift Add test for xctestplan extension --- Tests/DangerTests/FileTests.swift | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Tests/DangerTests/FileTests.swift b/Tests/DangerTests/FileTests.swift index b58f5fed..f8c0c9f8 100644 --- a/Tests/DangerTests/FileTests.swift +++ b/Tests/DangerTests/FileTests.swift @@ -129,4 +129,12 @@ final class FileTests: XCTestCase { XCTAssertEqual(file.fileType, expectedType) } + + func test_fileType_forXCTestPlan() { + let file: File = "TestPlan.xctestplan" + + let expectedType: FileType = .xctestplan + + XCTassertEqual(file.fileType, expectedType) + } } From 5229a3055e665ea0ead69d04205dcc7c52511c77 Mon Sep 17 00:00:00 2001 From: Anthony Merle <107677848+gsl-anthonymerle@users.noreply.github.com> Date: Wed, 4 Jun 2025 15:44:06 +0200 Subject: [PATCH 3/7] Update CHANGELOG.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4a9a3f77..0979753e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,8 @@ ## Master +- Add `.xctestplan` extension to available file extensions [@gsl-anthonymerle](https://github.com/gsl-anthonymerle) - [653](https://github.com/danger/swift/pull/653) + ## 3.21.2 - Fix Runner's path resolution to enable `--cwd` with relative paths [@Fab1n](https://github.com/Fab1n) - [#650](https://github.com/danger/swift/pull/650) @@ -623,3 +625,4 @@ This release also includes: [@dromerobarria]: https://github.com/dromerobarria [@msnazarow]: https://github.com/msnazarow [@Davarg]https://github.com/Davarg +[@gsl-anthonymerle]: https://github.com/gsl-anthonymerle From a9861855be4a367085aefcf14d6163d80a3075f2 Mon Sep 17 00:00:00 2001 From: Anthony Merle <107677848+gsl-anthonymerle@users.noreply.github.com> Date: Wed, 4 Jun 2025 15:44:50 +0200 Subject: [PATCH 4/7] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0979753e..c8516647 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -624,5 +624,5 @@ This release also includes: [@aserdobintsev]: https://github.com/aserdobintsev [@dromerobarria]: https://github.com/dromerobarria [@msnazarow]: https://github.com/msnazarow -[@Davarg]https://github.com/Davarg +[@Davarg]: https://github.com/Davarg [@gsl-anthonymerle]: https://github.com/gsl-anthonymerle From 7e7890ffbc4012c6bd1b101adc53d9a8c6983666 Mon Sep 17 00:00:00 2001 From: Anthony Merle <107677848+gsl-anthonymerle@users.noreply.github.com> Date: Wed, 4 Jun 2025 15:47:18 +0200 Subject: [PATCH 5/7] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c8516647..8582b356 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,7 @@ ## Master -- Add `.xctestplan` extension to available file extensions [@gsl-anthonymerle](https://github.com/gsl-anthonymerle) - [653](https://github.com/danger/swift/pull/653) +- Add `.xctestplan` extension to available file extensions [@gsl-anthonymerle]() - [#653](https://github.com/danger/swift/pull/653) ## 3.21.2 From e517e7fbdad26ed9ee2c6d833e54e832b79fd537 Mon Sep 17 00:00:00 2001 From: Anthony Merle <107677848+gsl-anthonymerle@users.noreply.github.com> Date: Wed, 4 Jun 2025 15:50:13 +0200 Subject: [PATCH 6/7] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8582b356..f090e6f2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,7 @@ ## Master -- Add `.xctestplan` extension to available file extensions [@gsl-anthonymerle]() - [#653](https://github.com/danger/swift/pull/653) +- Add `.xctestplan` extension to available file extensions [@gsl-anthonymerle][] - [#653](https://github.com/danger/swift/pull/653) ## 3.21.2 From b1352dddc9ebd982a12213914e1cc1b1e34dfa01 Mon Sep 17 00:00:00 2001 From: Anthony Merle <107677848+gsl-anthonymerle@users.noreply.github.com> Date: Tue, 10 Jun 2025 10:37:33 +0200 Subject: [PATCH 7/7] Update Tests/DangerTests/FileTests.swift Co-authored-by: Franco Meloni --- Tests/DangerTests/FileTests.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tests/DangerTests/FileTests.swift b/Tests/DangerTests/FileTests.swift index f8c0c9f8..788e7880 100644 --- a/Tests/DangerTests/FileTests.swift +++ b/Tests/DangerTests/FileTests.swift @@ -135,6 +135,6 @@ final class FileTests: XCTestCase { let expectedType: FileType = .xctestplan - XCTassertEqual(file.fileType, expectedType) + XCTAssertEqual(file.fileType, expectedType) } }