refactor: improve ctcache configuration maintainability

- Move CTCACHE_DIR and CTCACHE_MAXSIZE_MB to ci/test/00_setup_env.sh
- Use command -v instead of hardcoded paths for clang-tidy and clang-tidy-cache
- Store clang-tidy location in CLANG_TIDY_BIN variable for reuse
- Extract cache cleanup logic into cleanup_ctcache() function
- Convert CTCACHE_COMMIT to ARG variable in Dockerfile

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: UdjinM6

.github/workflows/build-src.yml

@@ -126,6 +126,7 @@ jobs:
       - name: Run linters
         if: inputs.build-target == 'linux64_multiprocess'
         run: |
+          CACHE_DIR="/cache"
           export BUILD_TARGET="${{ inputs.build-target }}"
           source ./ci/dash/matrix.sh
           ./ci/dash/lint-tidy.sh

ci/dash/lint-tidy.sh

@@ -11,25 +11,47 @@ set -eo pipefail
 #          only on nor do they set the requisite build parameters. Make sure you do
 #          that *before* running this script.
 
+# Cleanup old ctcache entries to keep cache size under limit
+cleanup_ctcache() {
+  local cache_dir=$1
+  local max_size_mb=$2
+  local cache_size_mb
+
+  cache_size_mb=$(du -sm "${cache_dir}" 2>/dev/null | cut -f1)
+  if [ "${cache_size_mb}" -gt "${max_size_mb}" ]; then
+    echo "Cache size ${cache_size_mb}MB exceeds limit ${max_size_mb}MB, cleaning old entries..."
+    # Remove files older than 7 days, or if still too large, oldest 20% of files
+    find "${cache_dir}" -type f -mtime +7 -delete 2>/dev/null || true
+    cache_size_mb=$(du -sm "${cache_dir}" 2>/dev/null | cut -f1)
+    if [ "${cache_size_mb}" -gt "${max_size_mb}" ]; then
+      local file_count remove_count
+      file_count=$(find "${cache_dir}" -type f | wc -l)
+      remove_count=$((file_count / 5))
+      find "${cache_dir}" -type f -printf '%T+ %p\0' | sort -z | head -z -n "${remove_count}" | cut -z -d' ' -f2- | xargs -0 rm -f 2>/dev/null || true
+      echo "Attempted to remove ${remove_count} oldest cache entries"
+    fi
+    echo "Cache size after cleanup: $(du -sh "${cache_dir}" 2>/dev/null | cut -f1)"
+  fi
+}
+
 # Verify clang-tidy is available
-if ! command -v clang-tidy >/dev/null 2>&1; then
+CLANG_TIDY_BIN=$(command -v clang-tidy)
+if [ -z "${CLANG_TIDY_BIN}" ]; then
   echo "Error: clang-tidy not found in PATH"
   exit 1
 fi
 
 # Setup ctcache for clang-tidy result caching
-export CTCACHE_DIR="/cache/ctcache"
 export CTCACHE_SAVE_OUTPUT=1
-CTCACHE_CLANG_TIDY=$(which clang-tidy)
-export CTCACHE_CLANG_TIDY
+export CTCACHE_CLANG_TIDY="${CLANG_TIDY_BIN}"
 mkdir -p "${CTCACHE_DIR}"
 
-CLANG_TIDY_CACHE="/usr/local/bin/clang-tidy-cache"
+CLANG_TIDY_CACHE=$(command -v clang-tidy-cache)
 CLANG_TIDY_CACHE_PY="/usr/local/bin/src/ctcache/clang_tidy_cache.py"
 
 # Verify ctcache is installed
-if [ ! -x "${CLANG_TIDY_CACHE}" ]; then
-  echo "Error: ctcache binary not found at ${CLANG_TIDY_CACHE}"
+if [ -z "${CLANG_TIDY_CACHE}" ]; then
+  echo "Error: clang-tidy-cache not found in PATH"
   exit 1
 fi
 if [ ! -f "${CLANG_TIDY_CACHE_PY}" ]; then
@@ -54,21 +76,7 @@ du -sh "${CTCACHE_DIR}" 2>/dev/null || echo "Cache directory not found"
 python3 "${CLANG_TIDY_CACHE_PY}" --show-stats 2>&1 || true
 
 # Limit cache size (ctcache has no built-in size management)
-CTCACHE_MAXSIZE_MB=50
-CACHE_SIZE_MB=$(du -sm "${CTCACHE_DIR}" 2>/dev/null | cut -f1)
-if [ "${CACHE_SIZE_MB}" -gt "${CTCACHE_MAXSIZE_MB}" ]; then
-  echo "Cache size ${CACHE_SIZE_MB}MB exceeds limit ${CTCACHE_MAXSIZE_MB}MB, cleaning old entries..."
-  # Remove files older than 7 days, or if still too large, oldest 20% of files
-  find "${CTCACHE_DIR}" -type f -mtime +7 -delete 2>/dev/null || true
-  CACHE_SIZE_MB=$(du -sm "${CTCACHE_DIR}" 2>/dev/null | cut -f1)
-  if [ "${CACHE_SIZE_MB}" -gt "${CTCACHE_MAXSIZE_MB}" ]; then
-    FILE_COUNT=$(find "${CTCACHE_DIR}" -type f | wc -l)
-    REMOVE_COUNT=$((FILE_COUNT / 5))
-    find "${CTCACHE_DIR}" -type f -printf '%T+ %p\0' | sort -z | head -z -n "${REMOVE_COUNT}" | cut -z -d' ' -f2- | xargs -0 rm -f 2>/dev/null || true
-    echo "Attempted to remove ${REMOVE_COUNT} oldest cache entries"
-  fi
-  echo "Cache size after cleanup: $(du -sh "${CTCACHE_DIR}" 2>/dev/null | cut -f1)"
-fi
+cleanup_ctcache "${CTCACHE_DIR}" "${CTCACHE_MAXSIZE_MB}"
 echo "=========================="
 
 cd "${BASE_ROOT_DIR}/build-ci/dashcore-${BUILD_TARGET}"

ci/test/00_setup_env.sh

@@ -61,6 +61,9 @@ export CCACHE_COMPRESS=${CCACHE_COMPRESS:-1}
 # The cache dir.
 # This folder exists on the ci host and ci guest. Changes are propagated back and forth.
 export CCACHE_DIR=${CCACHE_DIR:-$CACHE_DIR/ccache}
+# ctcache (clang-tidy cache) configuration
+export CTCACHE_DIR=${CTCACHE_DIR:-$CACHE_DIR/ctcache}
+export CTCACHE_MAXSIZE_MB=${CTCACHE_MAXSIZE_MB:-50}
 # The depends dir.
 # This folder exists on the ci host and ci guest. Changes are propagated back and forth.
 export DEPENDS_DIR=${DEPENDS_DIR:-$BASE_ROOT_DIR/depends}

contrib/containers/ci/ci.Dockerfile

@@ -67,8 +67,8 @@ RUN set -ex; \
 
 # Install ctcache for clang-tidy result caching
 # Pin to specific commit to ensure patch applies correctly
+ARG CTCACHE_COMMIT=e33c063ca6e52b48bcefbc45d46d8c150ffa81ca
 RUN set -ex; \
-    CTCACHE_COMMIT="e33c063ca6e52b48bcefbc45d46d8c150ffa81ca"; \
     mkdir -p /usr/local/bin/src/ctcache; \
     curl -fsSL "https://raw.githubusercontent.com/matus-chochlik/ctcache/${CTCACHE_COMMIT}/src/ctcache/clang_tidy_cache.py" \
         -o /usr/local/bin/src/ctcache/clang_tidy_cache.py; \