Skip to content

Conversation

@camilesing
Copy link
Contributor

@camilesing camilesing commented Dec 4, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

for #19013

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 4, 2025
@chatgpt-codex-connector
Copy link

💡 Codex Review

pub async fn kill_query(plan: KillPlan) -> Result<bool> {
let session = create_session(Some(plan.tenant.as_str()))?;
let version = GlobalConfig::version();

P0 Badge Flight action plans reference nonexistent tenant field

The flight handlers now call create_session(Some(plan.tenant.as_str())), but the plan types they accept (KillPlan, SetPriorityPlan, TruncateTablePlan) still do not define a tenant field (see planner/plans/kill.rs, planner/plans/set_priority.rs, planner/plans/ddl/table.rs). This makes the changed lines fail to compile, so the build will break and these flight actions cannot run until the plan structs or calls are corrected.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@camilesing camilesing force-pushed the for_issue_19013 branch 7 times, most recently from 183d91b to 4d88077 Compare December 6, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant