refactor: avoid String allocation in extended query handler

iPeluwa · iPeluwa · commit b6cdeb5bd288 · 2025-12-15T14:42:30.000+01:00
Use reference instead of calling .to_string() on query string
as suggested by mjgarton - the query is only used for logging
and doesn't need to be owned.
diff --git a/datafusion-postgres/src/handlers.rs b/datafusion-postgres/src/handlers.rs
@@ -263,7 +263,7 @@ impl ExtendedQueryHandler for DfSessionService {
     where
         C: ClientInfo + Unpin + Send + Sync,
     {
-        let query = portal.statement.statement.0.to_string();
+        let query = &portal.statement.statement.0;
         log::debug!("Received execute extended query: {query}"); // Log for debugging
 
         // Check query hooks first

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ impl ExtendedQueryHandler for DfSessionService {`
`263`	`263`	`where`
`264`	`264`	`C: ClientInfo + Unpin + Send + Sync,`
`265`	`265`	`{`
`266`		`- let query = portal.statement.statement.0.to_string();`
	`266`	`+ let query = &portal.statement.statement.0;`
`267`	`267`	`log::debug!("Received execute extended query: {query}"); // Log for debugging`
`268`	`268`
`269`	`269`	`// Check query hooks first`