history cache for combi-modi or dmenu?

[eiro]

hello rofi people,

I wrote this command that generate menus from files on fly but the whole idea of it was to be able to use MRU (history) to make it more and more productive (as those menus are shared among users, the best topics should emerge naturally)

rofi -combi-modi $(
                cd ${0%/*}; 
                for it in *; do echo $it:$it
                done | paste -sd,
        ) -show combi -no-disable-history -cache-dir ~/.cache/rofi -matching-negate-char \|

but it didn't work, nor with -dmenu. according to the doc, history seems to be limited to the run and drun widgets. is that correct? is there a reason for this ? are patches welcome?

regards
marc

[DaveDavenport]

combi mode is a 'proxy' mode, it does not do anything itself.

So if you execute a drun entry, the drun mode will handle the history.

Architecture wise history would not work when implementing in the proxy. (The proxy does not know that for run it needs to store the executable name, but for drun the desktop file id. )

[DaveDavenport]

For dmenu I think the dmenu script should keep the history.

Rofi does not know what script runs (so what history belongs to what session), what history should be kept, what information it should keep in history, etc (f.e. the visible entry? one of the invisible fields? the index? etc.).
Again implementation wise rofi does not seem to be the right place to implement history.

[eiro]

Hi Dave,

Indeed, making history is something so easy so implement outside of rofi there is no sense to add it inside rofi (just |tee -a $historyfile) so maybe I miss an option for rofi to sort menu items from different rofi-scripts?

If I didn't, the solution would be to have a single rofi-script instead of separated and dedicated ones and and hack the theme to hide the menu name.

thanks a lot for your answers

[DaveDavenport]

so maybe I miss an option for rofi to sort menu items from different rofi-scripts

I am not sure what you are asking here.

[eiro]

I'm really sorry for my broken english.
How about I write a script that workaround my problem, write a blog post about it and post the link here so you can tell me what I missed?

[DaveDavenport]

I am more asking for clarification as I try not to make assumptions. I think your English is fine.
I mention I am not sure, to avoid me giving an answer to something that was not asked, and we both being confused.

To give some information anyway:

Rofi does not sort the shown list. Only when you start 'filtering' the list and when sorting is enabled (based on the selected sorting method) it sorts the result (this is in general based on the distance to the filter query).