Properly yield self when initializing blocks with plain text emoji attributes

Author: davidcelis

lib/block_kit/concerns/plain_text_emoji_assignment.rb

@@ -5,12 +5,12 @@ module Concerns
     module PlainTextEmojiAssignment
       def self.new(*attributes)
         Module.new do
-          define_method(:initialize) do |attrs = {}|
+          define_method(:initialize) do |attrs = {}, &block|
             raise ArgumentError, "expected `attributes' to be a Hash, got #{attrs.class}" unless attrs.is_a?(Hash)
 
             emoji = attrs.delete(:emoji)
 
-            super(attrs)
+            super(attrs, &block)
 
             unless emoji.nil?
               attributes.each do |attribute|

spec/block_kit/base_spec.rb

@@ -24,6 +24,16 @@ def as_json(*)
     end
   end
 
+  it "yields self" do
+    expect { |b| block_class.new(&b) }.to yield_with_args(block_class)
+  end
+
+  it "yields self when other args are passed" do
+    attribute = block_class.attribute_types.keys.sample
+
+    expect { |b| block_class.new(attribute => nil, &b) }.to yield_with_args(block_class)
+  end
+
   context "fixers" do
     it "allows fixing validation errors" do
       block = block_class.new(text: "This is a very long text that exceeds the maximum length", items: [])

spec/block_kit/blocks_spec.rb

@@ -5,13 +5,7 @@
 RSpec.describe BlockKit::Blocks, type: :model do
   subject(:blocks) { described_class.new }
 
-  describe "#initialize" do
-    it "yields self" do
-      described_class.new do |blocks|
-        expect(blocks).to be_a(described_class)
-      end
-    end
-  end
+  it_behaves_like "a class that yields self on initialize"
 
   it_behaves_like "a block that has a DSL method",
     attribute: :blocks,

spec/block_kit/composition/confirmation_dialog_spec.rb

@@ -13,6 +13,8 @@
     }
   end
 
+  it_behaves_like "a class that yields self on initialize"
+
   describe "#as_json" do
     it "serializes to JSON" do
       expect(dialog.as_json).to eq({

spec/block_kit/composition/conversation_filter_spec.rb

@@ -11,6 +11,8 @@
     }
   end
 
+  it_behaves_like "a class that yields self on initialize"
+
   it "declares predicate and mutator methods for each include value" do
     described_class::VALID_INCLUDES.each do |value|
       expect(conversation_filter.public_send(:"include_#{value}?")).to be(false)

spec/block_kit/composition/dispatch_action_config_spec.rb

@@ -5,6 +5,8 @@
 RSpec.describe BlockKit::Composition::DispatchActionConfig, type: :model do
   subject(:config) { described_class.new(trigger_actions_on: ["on_enter_pressed", "on_character_entered"]) }
 
+  it_behaves_like "a class that yields self on initialize"
+
   it "declares predicate and mutator methods for each trigger_actions_on value" do
     config = described_class.new
 

spec/block_kit/composition/input_parameter_spec.rb

@@ -11,6 +11,8 @@
     }
   end
 
+  it_behaves_like "a class that yields self on initialize"
+
   describe "#as_json" do
     it "serializes to JSON" do
       expect(input_parameter.as_json).to eq({

spec/block_kit/composition/mrkdwn_spec.rb

@@ -6,6 +6,8 @@
   subject(:mrkdwn_block) { described_class.new(**attributes) }
   let(:attributes) { {text: "Hello, world!"} }
 
+  it_behaves_like "a class that yields self on initialize"
+
   describe "#truncate" do
     it "copies itself and truncates the copy's text" do
       mrkdwn_block.verbatim = true

spec/block_kit/composition/option_group_spec.rb

@@ -11,6 +11,8 @@
     }
   end
 
+  it_behaves_like "a class that yields self on initialize"
+
   it_behaves_like "a block that has a DSL method",
     attribute: :options,
     as: :option,

spec/block_kit/composition/option_spec.rb

@@ -11,6 +11,8 @@
     }
   end
 
+  it_behaves_like "a class that yields self on initialize"
+
   describe "#as_json" do
     it "serializes to JSON" do
       expect(option.as_json).to eq({