core refactor

Author: dbackowski

lib/polish_validators/iban.ex

@@ -24,7 +24,7 @@ defmodule PolishValidators.Iban do
       { :error, "Invalid length" }
   
   """
-  def validate(iban) do
+  def validate(iban) when is_binary(iban) do
     iban_length = replace_prefix(iban, "PL", "")
                     |> validate_length(26)
 
@@ -36,6 +36,10 @@ defmodule PolishValidators.Iban do
     end
   end
 
+  def validate(_) do
+    throw "IBAN must be a string."
+  end
+
   defp calculate_checksum(iban) do
     "#{slice(iban, 2..-1)}2521#{slice(iban, 0..1)}"
       |> to_integer

lib/polish_validators/nip.ex

@@ -1,5 +1,5 @@
 defmodule PolishValidators.Nip do
-  import Enum, only: [zip: 1, reduce: 3, map: 2]
+  import Enum, only: [zip: 1, reduce: 3]
   import List, only: [last: 1]
   import PolishValidators.Common
 
@@ -24,7 +24,7 @@ defmodule PolishValidators.Nip do
       { :error, "Invalid length" }
   
   """
-  def validate(nip) do
+  def validate(nip) when is_binary(nip) do
     nip_length = validate_length(nip, 10)
 
     case nip_length do
@@ -38,6 +38,10 @@ defmodule PolishValidators.Nip do
     end
   end
 
+  def validate(_) do
+    throw "NIP must be a string."
+  end
+
   defp calculate_checksum(nip) do
     reduce(nip, 0, &reduce_checksum/2)
       |> rem(11)

lib/polish_validators/pesel.ex

@@ -1,5 +1,5 @@
 defmodule PolishValidators.Pesel do
-  import Enum, only: [zip: 1, reduce: 3, map: 2]
+  import Enum, only: [zip: 1, reduce: 3]
   import List, only: [last: 1]
   import PolishValidators.Common
 
@@ -24,8 +24,7 @@ defmodule PolishValidators.Pesel do
       { :error, "Invalid length" }
   
   """
-  #def validate(pesel) do#when is_binary(pesel) do
-  def validate(pesel) do
+  def validate(pesel) when is_binary(pesel) do
     pesel_length = validate_length(pesel, 11)
 
     case pesel_length do
@@ -39,6 +38,10 @@ defmodule PolishValidators.Pesel do
     end
   end
 
+  def validate(_) do
+    throw "Pesel must be a string."
+  end
+
   defp calculate_checksum(pesel) do
     (10 - (reduce(pesel, 0, &reduce_checksum/2) |> rem(10)))
       |> rem(10)
@@ -47,8 +50,4 @@ defmodule PolishValidators.Pesel do
   defp reduce_checksum(pesel, acc) do
     acc + elem(pesel, 0) * elem(pesel, 1)
   end
-
-  #def validate(pesel) do
-  #  throw "Pesel must be a string."
-  #end
 end

lib/polish_validators/regon.ex

@@ -33,7 +33,7 @@ defmodule PolishValidators.Regon do
       { :error, "Invalid length" }
   
   """
-  def validate(regon) do
+  def validate(regon) when is_binary(regon) do
     regon_length = validate_length(regon, [9, 14])
 
     case regon_length do
@@ -47,6 +47,10 @@ defmodule PolishValidators.Regon do
     end
   end
 
+  def validate(_) do
+    throw "Regon must be a string."
+  end
+
   defp weights(regon) do
     case length(regon) do
       9 -> @weights9