code refactor

Author: dbackowski

lib/polish_validators/iban.ex

@@ -14,6 +14,9 @@ defmodule PolishValidators.Iban do
       iex> PolishValidators.Iban.validate("PL61109010140000071219812874")
       { :ok, "Valid" }
 
+      iex> PolishValidators.Iban.validate("61109010140000071219812874")
+      { :ok, "Valid" }
+
       iex> PolishValidators.Iban.validate("PL61109010140000071219812871")
       { :error, "Wrong checksum" }
 

lib/polish_validators/regon.ex

@@ -12,7 +12,7 @@ defmodule PolishValidators.Regon do
   """
 
   @doc """
-  Validate regon number.
+  Validate Regon number.
 
   ## Examples
 

test/polish_validators_iban_test.exs

@@ -1,21 +1,5 @@
 defmodule PolishValidatorsIbanTest do
   use ExUnit.Case
-  doctest PolishValidators
-
-  test "valid iban with PL prefix" do
-    assert PolishValidators.Iban.validate("PL61109010140000071219812874") == { :ok, "Valid" }
-  end
-
-  test "valid iban without PL prefix" do
-    assert PolishValidators.Iban.validate("61109010140000071219812874") == { :ok, "Valid" }
-  end
-
-  test "iban with invalid checksum" do
-    assert PolishValidators.Iban.validate("PL61109010140000071219812871") == { :error, "Wrong checksum" }
-  end
-
-  test "iban with wrong length" do
-    assert PolishValidators.Iban.validate("PL611090101400000712198128") == { :error, "Invalid length" }
-  end
+  doctest PolishValidators.Iban
 end
 

test/polish_validators_nip_test.exs

@@ -1,16 +1,4 @@
 defmodule PolishValidatorsNipTest do
   use ExUnit.Case
-  doctest PolishValidators
-
-  test "valid nip" do
-    assert PolishValidators.Nip.validate("6597068174") == { :ok, "Valid" }
-  end
-  
-  test "nip with invalid checksum" do
-    assert PolishValidators.Nip.validate("6597068172") == { :error, "Wrong checksum" }
-  end
-
-  test "nip with wrong length" do
-    assert PolishValidators.Nip.validate("2") == { :error, "Invalid length" }
-  end
+  doctest PolishValidators.Nip
 end

test/polish_validators_pesel_test.exs

@@ -1,16 +1,4 @@
 defmodule PolishValidatorsPeselTest do
   use ExUnit.Case
-  doctest PolishValidators
-
-  test "valid pesel" do
-    assert PolishValidators.Pesel.validate("44051401359") == { :ok, "Valid" }
-  end
-  
-  test "pesel with invalid checksum" do
-    assert PolishValidators.Pesel.validate("44051401354") == { :error, "Wrong checksum" }
-  end
-
-  test "pesel with wrong length" do
-    assert PolishValidators.Pesel.validate("2") == { :error, "Invalid length" }
-  end
+  doctest PolishValidators.Pesel
 end

test/polish_validators_regon_test.exs

@@ -1,25 +1,5 @@
 defmodule PolishValidatorsRegonTest do
   use ExUnit.Case
-  doctest PolishValidators
-
-  test "valid regon (9 digits)" do
-    assert PolishValidators.Regon.validate("517001918") == { :ok, "Valid" }
-  end
-
-  test "valid regon (14 digits)" do
-    assert PolishValidators.Regon.validate("87515234723651") == { :ok, "Valid" }
-  end
-
-  test "regon (9 digits) with invalid checksum" do
-    assert PolishValidators.Regon.validate("517001912") == { :error, "Wrong checksum" }
-  end
-
-  test "regon (14 digits) with invalid checksum" do
-    assert PolishValidators.Regon.validate("87515234723652") == { :error, "Wrong checksum" }
-  end
-
-  test "regon with wrong length" do
-    assert PolishValidators.Regon.validate("51700191") == { :error, "Invalid length" }
-  end
+  doctest PolishValidators.Regon
 end