Skip to content

Commit 1abf3fb

Browse files
committed
ci(e2e): remove unused LOOP_* secrets from job env to avoid secrets context in expressions; rely only on DEV_REGISTRY_DOCKER_CFG
Signed-off-by: Anton Yachmenev <anton.yachmenev@flant.com>
1 parent 22b75f5 commit 1abf3fb

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/e2e-matrix.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ jobs:
9696
PROFILE: sds-replicated-volume
9797
GO_VERSION: "1.24.6"
9898
TMP_ROOT: ${{ github.workspace }}/ci/dvp-e2e/tmp
99-
LOOP_WEBHOOK: ${{ secrets.LOOP_WEBHOOK_URL || secrets.LOOP_WEBHOOK }}
100-
LOOP_CHANNEL: ${{ secrets.LOOP_CHANNEL || 'test-virtualization-loop-alerts' }} # TODO: replace with channel secret after successful run
10199

102100
outputs:
103101
run_id: ${{ steps.prep.outputs.run_id }}
@@ -200,10 +198,10 @@ jobs:
200198
REGISTRY_DOCKER_CFG="${REGISTRY_DOCKER_CFG}" scripts/inject_registry_cfg.sh -f "$VALS" -v "$REGISTRY_DOCKER_CFG"
201199
202200
- name: Docker login from DEV_REGISTRY_DOCKER_CFG (optional)
203-
if: ${{ secrets.DEV_REGISTRY_DOCKER_CFG != '' }}
201+
if: ${{ env.REGISTRY_DOCKER_CFG != '' }}
204202
run: |
205203
set -euo pipefail
206-
cfg=$(printf '%s' '${{ secrets.DEV_REGISTRY_DOCKER_CFG }}' | base64 -d)
204+
cfg=$(printf '%s' "$REGISTRY_DOCKER_CFG" | base64 -d)
207205
reg_list=$(printf '%s' "$cfg" | jq -r '.auths | keys[]')
208206
for reg in $reg_list; do
209207
auth=$(printf '%s' "$cfg" | jq -r --arg r "$reg" '.auths[$r].auth // ""')

0 commit comments

Comments
 (0)