fix(api, vmop): fix getTargetPodDiskError to check Pending pod directly

kubelet emits FailedAttachVolume/FailedMount events while pod is in
Pending phase — before ContainerCreating state is ever reached.
The previous ContainerCreating guard prevented detection entirely.
Now check events for any Pending pod that is not being deleted.

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/vmop/migration/internal/handler/lifecycle.go

@@ -649,37 +649,26 @@ func (h LifecycleHandler) calculateMigrationProgress(
 }
 
 func (h LifecycleHandler) getTargetPodDiskError(ctx context.Context, pod *corev1.Pod) (string, bool) {
-	if pod == nil {
+	if pod == nil || pod.Status.Phase != corev1.PodPending || pod.DeletionTimestamp != nil {
 		return "", false
 	}
 
-	for _, cs := range pod.Status.InitContainerStatuses {
-		if cs.State.Waiting != nil && cs.State.Waiting.Reason == "ContainerCreating" {
-			break
-		}
+	eventList := &corev1.EventList{}
+	err := h.client.List(ctx, eventList, &client.ListOptions{
+		Namespace: pod.Namespace,
+		FieldSelector: fields.SelectorFromSet(fields.Set{
+			"involvedObject.name": pod.Name,
+			"involvedObject.kind": "Pod",
+		}),
+	})
+	if err != nil {
+		return "", false
 	}
-	for _, cs := range pod.Status.ContainerStatuses {
-		if cs.State.Waiting != nil && cs.State.Waiting.Reason == "ContainerCreating" {
-			eventList := &corev1.EventList{}
-			err := h.client.List(ctx, eventList, &client.ListOptions{
-				Namespace: pod.Namespace,
-				FieldSelector: fields.SelectorFromSet(fields.Set{
-					"involvedObject.name": pod.Name,
-					"involvedObject.kind": "Pod",
-				}),
-			})
-			if err != nil {
-				return "", false
-			}
-			for _, e := range eventList.Items {
-				if e.Type == corev1.EventTypeWarning && (e.Reason == reasonFailedAttachVolume || e.Reason == reasonFailedMount) {
-					return fmt.Sprintf("%s: %s", e.Reason, e.Message), true
-				}
-			}
-			return "", false
+	for _, e := range eventList.Items {
+		if e.Type == corev1.EventTypeWarning && (e.Reason == reasonFailedAttachVolume || e.Reason == reasonFailedMount) {
+			return fmt.Sprintf("%s: %s", e.Reason, e.Message), true
 		}
 	}
-
 	return "", false
 }