Skip to content

Commit 299dc28

Browse files
author
matanper
authored
remove arm/v7 from build (#217)
Ray is not supported on ARMv7. blocking it in the script until we handle this
1 parent 520d645 commit 299dc28

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.github/workflows/e2e-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
with:
6666
context: .
6767
file: ./Dockerfile
68-
platforms: linux/amd64,linux/arm64,linux/arm/v7
68+
platforms: linux/amd64,linux/arm64/v8
6969
tags: ${{ secrets.MON_IMAGE_NAME }}:${{ github.sha }},${{ secrets.MON_IMAGE_NAME }}:latest,${{ secrets.PUBLIC_IMAGE_NAME }}:latest
7070
build-args: |
7171
DEEPCHECKS_CI_TOKEN=${{ secrets.DEEPCHECKS_CI_TOKEN }}

deploy-oss.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ DEEPCHECKS_SECRET=$(head -c 28 /dev/urandom | sha224sum -b | head -c 56)
77
export DEEPCHECKS_SECRET
88

99
OS=$(uname | awk '{print tolower($0)}')
10+
ARCH=$(uname -m)
1011
YUM_CMD=$(which yum || echo '')
1112
APT_GET_CMD=$(which apt-get || echo '')
1213

@@ -15,6 +16,11 @@ if ! [[ "$OS" == *darwin* || "$OS" == *linux* ]]; then
1516
echo "Unfortunately, Deepchecks can only be deployed on MacOS or Linux systems at the moment"
1617
exit 0
1718
fi
19+
# Check if ARMv7, then not supported
20+
if [[ "$ARCH" == "armv7l" ]]; then
21+
echo "Unfortunately, Deepchecks can only be deployed on x86_64 or ARMv8 systems at the moment"
22+
exit 0
23+
fi
1824

1925
# Talk to the user
2026
echo "Welcome to the single instance Deepchecks installer 🚀"

0 commit comments

Comments
 (0)