test login to ecr before build (#219)

Author: matanper

.github/workflows/e2e-tests.yml

@@ -42,7 +42,6 @@ jobs:
         uses: docker/build-push-action@v4
         with:
           context: .
-          file: ./Dockerfile
           tags: ${{ secrets.MON_IMAGE_NAME }}:${{ github.sha }}
           build-args: |
             DEEPCHECKS_CI_TOKEN=${{ secrets.DEEPCHECKS_CI_TOKEN }}
@@ -53,35 +52,13 @@ jobs:
           name: commImage
           path: /tmp/commImage.tar
   docker-push:
-    if: github.event_name != 'pull_request'
     runs-on: ubuntu-latest
-    needs: build
+    if: github.event_name != 'pull_request'
     steps:
       - name: Checkout
         uses: actions/checkout@v2
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v2
-      - name: Download artifact
-        uses: actions/download-artifact@v2
-        with:
-          name: commImage
-          path: /tmp
-      - name: Load Docker image
-        # Loading the image from artifact should reuse it and rebuild only the missing arm64 version
-        run: docker load --input /tmp/commImage.tar
-      - name: Build and push
-        uses: docker/build-push-action@v4
-        with:
-          context: .
-          file: ./Dockerfile
-          platforms: linux/amd64,linux/arm64/v8
-          outputs: type=image,push=false
-          tags: |
-            ${{ secrets.MON_IMAGE_NAME }}:${{ github.sha }}
-            ${{ secrets.MON_IMAGE_NAME }}:latest
-            ${{ secrets.PUBLIC_IMAGE_NAME }}:latest
-          build-args: |
-            DEEPCHECKS_CI_TOKEN=${{ secrets.DEEPCHECKS_CI_TOKEN }}
       - name: Configure AWS credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:
@@ -91,10 +68,6 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
-      - name: Build and push
-        run: |
-          docker push ${{ secrets.MON_IMAGE_NAME }}:${{ github.sha }}
-          docker push ${{ secrets.MON_IMAGE_NAME }}:latest
       - name: Configure AWS credentials (Public)
         uses: aws-actions/configure-aws-credentials@v1
         with:
@@ -106,9 +79,20 @@ jobs:
         uses: aws-actions/amazon-ecr-login@v1
         with:
           registry-type: public
-      - name: Push to public
-        run: |
-          docker push ${{ secrets.PUBLIC_IMAGE_NAME }}:latest
+      # Sadly, buildx does not support loading images from file to reuse the image from the previous step
+      # https://github.com/docker/buildx/issues/847
+      - name: Build and push
+        uses: docker/build-push-action@v4
+        with:
+          context: .
+          platforms: linux/amd64,linux/arm64/v8
+          pull: true
+          tags: |
+            ${{ secrets.MON_IMAGE_NAME }}:${{ github.sha }}
+            ${{ secrets.MON_IMAGE_NAME }}:latest
+            ${{ secrets.PUBLIC_IMAGE_NAME }}:latest
+          build-args: |
+            DEEPCHECKS_CI_TOKEN=${{ secrets.DEEPCHECKS_CI_TOKEN }}
       - name: Logout from Amazon ECR
         if: always()
         run: |