diff --git a/app/api/crimes.js b/app/api/crimes.js index aede93e..82336e6 100644 --- a/app/api/crimes.js +++ b/app/api/crimes.js @@ -59,3 +59,5 @@ router.post('/search', function (req, res){ }); module.exports = router; + +//Muy ordenado, código bien escrito y cumple con sus funcionalidades \ No newline at end of file diff --git a/app/api/index.js b/app/api/index.js index 37bbc90..d5aeab4 100644 --- a/app/api/index.js +++ b/app/api/index.js @@ -14,3 +14,5 @@ apiRouter.get('/', function(req, res) { // set subroutes on the other files apiRouter.use('/crimes', require('./crimes')); module.exports = apiRouter; + +//Bien, bueno que este ordenado con diferentes js, pues permite facil modificabilidad \ No newline at end of file diff --git a/app/npm-debug.log b/app/npm-debug.log new file mode 100644 index 0000000..dfa1a55 --- /dev/null +++ b/app/npm-debug.log @@ -0,0 +1,47 @@ +0 info it worked if it ends with ok +1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe', +1 verbose cli 'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js', +1 verbose cli 'start' ] +2 info using npm@3.10.8 +3 info using node@v6.9.0 +4 verbose run-script [ 'prestart', 'start', 'poststart' ] +5 info lifecycle nocrime@1.0.0~prestart: nocrime@1.0.0 +6 silly lifecycle nocrime@1.0.0~prestart: no script for prestart, continuing +7 info lifecycle nocrime@1.0.0~start: nocrime@1.0.0 +8 verbose lifecycle nocrime@1.0.0~start: unsafe-perm in lifecycle true +9 verbose lifecycle nocrime@1.0.0~start: PATH: C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin;C:\Users\jdani\Documents\Universidad\6to\Web\codeReviewProyecto2\nocrime\node_modules\.bin;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Common Files\lenovo\easyplussdk\bin;C:\Program Files\Intel\WiFi\bin\;C:\Program Files\Common Files\Intel\WirelessCommon\;C:\Program Files\nodejs\;C:\Program Files (x86)\Heroku\bin;C:\Program Files (x86)\git\cmd;C:\Program Files (x86)\Git\cmd;C:\Ruby22-x64\bin;C:\Users\jdani\AppData\Local\Microsoft\WindowsApps;C:\Users\jdani\AppData\Roaming\npm;C:\Program Files\Sublime Text 3;%SUBLIME%;C:\Program Files\MongoDB\Server\3.4\bin +10 verbose lifecycle nocrime@1.0.0~start: CWD: C:\Users\jdani\Documents\Universidad\6to\Web\codeReviewProyecto2\nocrime +11 silly lifecycle nocrime@1.0.0~start: Args: [ '/d /s /c', 'node server.js' ] +12 silly lifecycle nocrime@1.0.0~start: Returned: code: 1 signal: null +13 info lifecycle nocrime@1.0.0~start: Failed to exec start script +14 verbose stack Error: nocrime@1.0.0 start: `node server.js` +14 verbose stack Exit status 1 +14 verbose stack at EventEmitter. (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:255:16) +14 verbose stack at emitTwo (events.js:106:13) +14 verbose stack at EventEmitter.emit (events.js:191:7) +14 verbose stack at ChildProcess. (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:40:14) +14 verbose stack at emitTwo (events.js:106:13) +14 verbose stack at ChildProcess.emit (events.js:191:7) +14 verbose stack at maybeClose (internal/child_process.js:877:16) +14 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) +15 verbose pkgid nocrime@1.0.0 +16 verbose cwd C:\Users\jdani\Documents\Universidad\6to\Web\codeReviewProyecto2\nocrime\app +17 error Windows_NT 10.0.14393 +18 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start" +19 error node v6.9.0 +20 error npm v3.10.8 +21 error code ELIFECYCLE +22 error nocrime@1.0.0 start: `node server.js` +22 error Exit status 1 +23 error Failed at the nocrime@1.0.0 start script 'node server.js'. +23 error Make sure you have the latest version of node.js and npm installed. +23 error If you do, this is most likely a problem with the nocrime package, +23 error not with npm itself. +23 error Tell the author that this fails on your system: +23 error node server.js +23 error You can get information on how to open an issue for this project with: +23 error npm bugs nocrime +23 error Or if that isn't available, you can get their info via: +23 error npm owner ls nocrime +23 error There is likely additional logging output above. +24 verbose exit [ 1, true ] diff --git a/npm-debug.log b/npm-debug.log new file mode 100644 index 0000000..03e6bf0 --- /dev/null +++ b/npm-debug.log @@ -0,0 +1,47 @@ +0 info it worked if it ends with ok +1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe', +1 verbose cli 'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js', +1 verbose cli 'start' ] +2 info using npm@3.10.8 +3 info using node@v6.9.0 +4 verbose run-script [ 'prestart', 'start', 'poststart' ] +5 info lifecycle nocrime@1.0.0~prestart: nocrime@1.0.0 +6 silly lifecycle nocrime@1.0.0~prestart: no script for prestart, continuing +7 info lifecycle nocrime@1.0.0~start: nocrime@1.0.0 +8 verbose lifecycle nocrime@1.0.0~start: unsafe-perm in lifecycle true +9 verbose lifecycle nocrime@1.0.0~start: PATH: C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin;C:\Users\jdani\Documents\Universidad\6to\Web\codeReviewProyecto2\nocrime\node_modules\.bin;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Common Files\lenovo\easyplussdk\bin;C:\Program Files\Intel\WiFi\bin\;C:\Program Files\Common Files\Intel\WirelessCommon\;C:\Program Files\nodejs\;C:\Program Files (x86)\Heroku\bin;C:\Program Files (x86)\git\cmd;C:\Program Files (x86)\Git\cmd;C:\Ruby22-x64\bin;C:\Users\jdani\AppData\Local\Microsoft\WindowsApps;C:\Users\jdani\AppData\Roaming\npm;C:\Program Files\Sublime Text 3;%SUBLIME%;C:\Program Files\MongoDB\Server\3.4\bin +10 verbose lifecycle nocrime@1.0.0~start: CWD: C:\Users\jdani\Documents\Universidad\6to\Web\codeReviewProyecto2\nocrime +11 silly lifecycle nocrime@1.0.0~start: Args: [ '/d /s /c', 'node server.js' ] +12 silly lifecycle nocrime@1.0.0~start: Returned: code: 1 signal: null +13 info lifecycle nocrime@1.0.0~start: Failed to exec start script +14 verbose stack Error: nocrime@1.0.0 start: `node server.js` +14 verbose stack Exit status 1 +14 verbose stack at EventEmitter. (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:255:16) +14 verbose stack at emitTwo (events.js:106:13) +14 verbose stack at EventEmitter.emit (events.js:191:7) +14 verbose stack at ChildProcess. (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:40:14) +14 verbose stack at emitTwo (events.js:106:13) +14 verbose stack at ChildProcess.emit (events.js:191:7) +14 verbose stack at maybeClose (internal/child_process.js:877:16) +14 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5) +15 verbose pkgid nocrime@1.0.0 +16 verbose cwd C:\Users\jdani\Documents\Universidad\6to\Web\codeReviewProyecto2\nocrime +17 error Windows_NT 10.0.14393 +18 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start" +19 error node v6.9.0 +20 error npm v3.10.8 +21 error code ELIFECYCLE +22 error nocrime@1.0.0 start: `node server.js` +22 error Exit status 1 +23 error Failed at the nocrime@1.0.0 start script 'node server.js'. +23 error Make sure you have the latest version of node.js and npm installed. +23 error If you do, this is most likely a problem with the nocrime package, +23 error not with npm itself. +23 error Tell the author that this fails on your system: +23 error node server.js +23 error You can get information on how to open an issue for this project with: +23 error npm bugs nocrime +23 error Or if that isn't available, you can get their info via: +23 error npm owner ls nocrime +23 error There is likely additional logging output above. +24 verbose exit [ 1, true ] diff --git a/pages/crime_form.html b/pages/crime_form.html index 1da5ab1..304b449 100644 --- a/pages/crime_form.html +++ b/pages/crime_form.html @@ -35,3 +35,6 @@

Vertical Crime form

+ + \ No newline at end of file diff --git a/public/app/views/test.html b/public/app/views/test.html index 94ab382..d90cb5b 100644 --- a/public/app/views/test.html +++ b/public/app/views/test.html @@ -21,3 +21,4 @@

Bootstrap Tutorial

+ \ No newline at end of file diff --git a/public/assets/css/landingPageStyle.css b/public/assets/css/landingPageStyle.css index 3e46630..10f7951 100644 --- a/public/assets/css/landingPageStyle.css +++ b/public/assets/css/landingPageStyle.css @@ -136,3 +136,7 @@ body { .skw-page-5 .skw-page__half--right .skw-page__content { background: #292929; } + +/* +Buen orden en las clases de estilo +*/ \ No newline at end of file diff --git a/public/assets/css/style.css b/public/assets/css/style.css index c0233b8..c74df8b 100644 --- a/public/assets/css/style.css +++ b/public/assets/css/style.css @@ -108,4 +108,5 @@ h3 margin-left: 25%; margin-right: 23%; padding-bottom: 20px; -} \ No newline at end of file +} +/* Buen uso de css */ \ No newline at end of file diff --git a/server.js b/server.js index ecff2bc..fd696ad 100644 --- a/server.js +++ b/server.js @@ -10,7 +10,8 @@ var MongoClient = require('mongodb').MongoClient; var db; // app CONFIGURATION -var config = require('./config'); +var config = require('./config');//no supe como generar el config :( Sería bueno poner en el readme.md instrucciones de como hacerlo + // (si, hice npm install --save) // use body parser so we can grab information from POST requests app.use(bodyParser.urlencoded({ extended: true })); @@ -42,6 +43,7 @@ MongoClient.connect(config.database, function(err, database) { module.exports.database = db; app.listen(config.port, function(){ - console.log('listening on 1337') + console.log('listening on 1337') //punto y coma }) }); +//En general bien \ No newline at end of file