Skip to content

[Code scan] ASE trajectory MultiSystems coverage is unconditionally skipped #1001

Description

@njzjz

This issue is part of a Codex global repository code scan.

TestASEtraj1 is unconditionally skipped with "This test is broken". This hides the inherited MultiSystems comparison coverage for loading HeAlO.traj through MultiSystems.from_file(..., fmt="ase/structure"), even in CI where ASE is installed.

Affected code:

@unittest.skip("This test is broken")
class TestASEtraj1(unittest.TestCase, CompLabeledSys, IsPBC):
def setUp(self):
self.multi_systems = dpdata.MultiSystems.from_file(
"ase_traj/HeAlO.traj", fmt="ase/structure"
)
self.system_1 = self.multi_systems.systems["Al0He4O0"]
self.system_2 = dpdata.LabeledSystem("ase_traj/Al0He4O0", fmt="deepmd")
self.places = 6
self.e_places = 6
self.f_places = 6
self.v_places = 4

Reproducer:

cd tests
PYTHONDONTWRITEBYTECODE=1 python -m unittest test_ase_traj.TestASEtraj1 -v

Current result reports the whole class as skipped. The skip should either be removed after fixing the underlying failure, or narrowed to a specific documented condition so CI can catch regressions in ASE trajectory multi-system loading.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions