docs: clarify deno x JSR entry points#3139
Conversation
fibibot
left a comment
There was a problem hiding this comment.
runtime/reference/cli/x.mdis a generated CLI reference page.runtime/contributing/docs.mdsays the individual pages under/runtime/reference/cli/are generated from Deno repository source files and are not directly editable, so this hand-written section will be overwritten on the next generation. Please move the source change upstream indenoland/denoor the generator input, then regenerate this page.
|
Addressed the review by moving the source change upstream to denoland/deno: denoland/deno#34173 This docs PR still shows the generated page output for |
fibibot
left a comment
There was a problem hiding this comment.
- Thanks for opening denoland/deno#34173. This docs PR still cannot merge at
runtime/reference/cli/x.md: the current head is unchanged and still hand-edits a generated CLI reference page. Please wait for the upstream source change to land, then regenerate this page from that source so the docs repo contains generated output instead of a manual edit.
This reverts commit bd67c4f.
|
I reverted the manual generated-page edit from this docs branch, so the PR no longer changes Current blocking state: denoland/deno#34173 carries the upstream source change. After that lands, I will regenerate the CLI reference page in this docs repo and update this PR with generated output only. |
fibibot
left a comment
There was a problem hiding this comment.
The hand edit to runtime/reference/cli/x.md is gone, so the generated-file blocker from the earlier review is cleared. This head has no docs diff left to approve; once denoland/deno#34173 lands and the generated page is updated from upstream, this can be reviewed normally.
Fixes #2845
Closes bartlomieju/orchid-inbox#128
Summary
exportsindeno.jsonorjsr.json, notpackage.jsonbin, fordeno xresolution.Verification
/home/exedev/.deno/bin/deno fmt --check runtime/reference/cli/x.md/home/exedev/.deno/bin/deno task build:lightNote:
deno task build:lightcompleted and generated the page. It logged the existing missingreference_gen/gen/deno.jsonwarning because reference docs were not generated locally.