[BUG] map.set_view_state does not set pitch and bearing

[jwardbond]

After updating to 0.13, map.set_view_state() calls no longer update the bearing or pitch. I looked for the breaking commit and found that it was 2ac3d52

Environment

• OS: Windows 11
• Browser: Edge
• Lonboard Version: 0.13.0

Steps to reproduce the bug

from lonboard import viz
from lonboard.basemap import MaplibreBasemap

m = viz(data=[])
m.set_view_state(longitude=-80, latitude=50, zoom=2, pitch=45, bearing=90)
m

This should produce a map that is 1) at significant pitch and 2) rotated 90 degrees. Instead, it produces

Additionally, changing the pitch/bearing manually and then calling m.view_state does not show the changes to the map.

I have tested this using all MaplibreBasemap modes (except it is difficult to manually change the pitch/bearing using reverse-controlled without getting a context menu lol).

[jwardbond]

Looks like it might be as simple as adding

    pitch: Number.isFinite(viewState.pitch) ? viewState.pitch : 0,
    bearing: Number.isFinite(viewState.bearing) ? viewState.bearing : 0,

after

lonboard/src/util.ts

Line 39 in 41d6e91

zoom: Number.isFinite(viewState.zoom) ? viewState.zoom : 0,

Although I am worried about this fix messing with GlobeView, as I don't think there is a pitch and bearing in that case?

I can submit a PR if requested.

[kylebarron]

Thanks! I've been on vacation and just getting back.

Yes, indeed that looks like the right location to add it. We should probably check that the view is an instance of MapView before setting the pitch and bearing. It would be great if you could make a PR.

It would be great to add a test for this but managing Python-JS tests is hard. I think recent work has enabled testing in a headless browser though. See https://github.com/developmentseed/lonboard/tree/main/tests/ui

[jwardbond]

Done!

I hope you enjoyed your vacation :). Sorry to have an issue waiting for you right when you got back!