From 503362c9fa3b342eb105f1759c1f4f81d33eebd1 Mon Sep 17 00:00:00 2001 From: Marco Walz Date: Sat, 21 Mar 2026 03:18:15 +0100 Subject: [PATCH] fix(icp-cli): add npm versions to bindgen and core references Mentions #100. --- skills/icp-cli/references/binding-generation.md | 4 ++-- skills/icp-cli/references/dfx-migration.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/skills/icp-cli/references/binding-generation.md b/skills/icp-cli/references/binding-generation.md index f075260..8668b91 100644 --- a/skills/icp-cli/references/binding-generation.md +++ b/skills/icp-cli/references/binding-generation.md @@ -1,6 +1,6 @@ # Binding Generation -icp-cli does not have a built-in `dfx generate` command. Use `@icp-sdk/bindgen` to generate TypeScript bindings from `.did` files. +icp-cli does not have a built-in `dfx generate` command. Use `@icp-sdk/bindgen` (>= 0.2.0) to generate TypeScript bindings from `.did` files. It depends on `@icp-sdk/core` (>= 5.0.0). ## Vite plugin (recommended) @@ -58,4 +58,4 @@ npx @icp-sdk/bindgen --did ../backend/backend.did --out ./src/bindings/backend ## Requirements - The `.did` file must exist on disk. If using a recipe with `candid` specified, the file must be committed. If `candid` is omitted, run `icp build` first to auto-generate it. -- `@icp-sdk/bindgen` generates code that depends on `@icp-sdk/core`. Projects using `@dfinity/agent` must upgrade to `@icp-sdk/core` + `@icp-sdk/bindgen`. This is not optional — there is no way to generate TypeScript bindings with icp-cli while staying on `@dfinity/agent`. +- `@icp-sdk/bindgen` (>= 0.2.0) generates code that depends on `@icp-sdk/core` (>= 5.0.0). Projects using `@dfinity/agent` must upgrade to `@icp-sdk/core` + `@icp-sdk/bindgen`. This is not optional — there is no way to generate TypeScript bindings with icp-cli while staying on `@dfinity/agent`. diff --git a/skills/icp-cli/references/dfx-migration.md b/skills/icp-cli/references/dfx-migration.md index 0508bf3..70b8a34 100644 --- a/skills/icp-cli/references/dfx-migration.md +++ b/skills/icp-cli/references/dfx-migration.md @@ -28,7 +28,7 @@ Since `@icp-sdk/bindgen` generates code that depends on `@icp-sdk/core`, project Steps: 1. `npm uninstall @dfinity/agent @dfinity/candid @dfinity/principal vite-plugin-environment` -2. `npm install @icp-sdk/core @icp-sdk/bindgen` +2. `npm install @icp-sdk/core@^5.0.0 @icp-sdk/bindgen@^0.2.0` 3. Delete `src/declarations/` (dfx-generated bindings) 4. Add `**/src/bindings/` to `.gitignore` 5. Commit the `.did` file(s) used by bindgen