From b00b1e027d153b300487b969f47519a95419cef9 Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Mon, 26 Aug 2019 16:11:48 -0700 Subject: [PATCH 01/12] New Tests --- python/test.py | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 python/test.py diff --git a/python/test.py b/python/test.py new file mode 100644 index 000000000..9a94aaf69 --- /dev/null +++ b/python/test.py @@ -0,0 +1,67 @@ +import phonenumbers + +#Fixed by Phonenumbers Cases +valid_strings = ['+6323168971', + '+442083661177', + '+658003211137', + '+20573925008', + '+2057392500', + '+20225777444', + '+84384813220', + '+84357659677', + '+56232512653', # https://switchcomm.atlassian.net/browse/TEL-9285 + '+525547808256'] + +# National Format match +national_format_match = { '+525547808256' : '55 4780 8256'} + +# Number validity check +number_validity_check = { '1932621160' : 'BR' } + +# To be fixed by Dialpad Changes +dialpad_cases = ['+6278033212174', # https://switchcomm.atlassian.net/browse/DP-13742 + '+63283168971', # Philipines + '+8031000000141', # Dialpadistan + ] + +#Invalid Strings +invalid_strings = [ '+4916190899790', # https://switchcomm.atlassian.net/browse/TEL-8824 Not Fixed + '+2022577744', + '+205739250', + '+8412032453', # https://switchcomm.atlassian.net/browse/DP-13742 + ] + +print '######### -NUMBER VALIDITY CHECK - ###############' +for l in number_validity_check: + region = number_validity_check[l] + x = phonenumbers.parse(l, region) + print (x), 'Region : %s -> %10s' % (region, phonenumbers.is_valid_number(x)) + +print '######### -NUMBER FORMAT VALID - ################' +for l in national_format_match: + x = phonenumbers.parse(l, None) + y = phonenumbers.format_number(x, phonenumbers.PhoneNumberFormat.NATIONAL) + if national_format_match[l] == y: + status = 'Success' + else: + status = 'Failed' + + print (l), '-> %10s : %s' % (y, status) + +print '######### - VALID - ################' +for l in valid_strings: + x = phonenumbers.parse(l, None) + print (x), '%10s' % phonenumbers.is_valid_number(x) + +print '######### - DIALPAD - ################' +for l in dialpad_cases: + try: + x = phonenumbers.parse(l, None) + print (x), '%10s' % phonenumbers.is_valid_number(x) + except Exception as e: + print (l), '%10s' % (e) + +print '######### - INVALID - ################' +for l in invalid_strings: + x = phonenumbers.parse(l, None) + print (x), '%10s' % phonenumbers.is_valid_number(x) From 6bdd976025627074b4787d02471561a7af6d304a Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Mon, 26 Aug 2019 16:12:33 -0700 Subject: [PATCH 02/12] New Tests --- python/test.py | 83 +++++++++++++++++++++++++------------------------- 1 file changed, 41 insertions(+), 42 deletions(-) diff --git a/python/test.py b/python/test.py index 9a94aaf69..61819e10b 100644 --- a/python/test.py +++ b/python/test.py @@ -1,6 +1,6 @@ -import phonenumbers +import phonenumbers -#Fixed by Phonenumbers Cases +# Fixed by Phonenumbers Cases valid_strings = ['+6323168971', '+442083661177', '+658003211137', @@ -9,59 +9,58 @@ '+20225777444', '+84384813220', '+84357659677', - '+56232512653', # https://switchcomm.atlassian.net/browse/TEL-9285 + '+56232512653', # https://switchcomm.atlassian.net/browse/TEL-9285 '+525547808256'] -# National Format match -national_format_match = { '+525547808256' : '55 4780 8256'} +print '######### - VALID BY LIBRARY - ################' +for l in valid_strings: + x = phonenumbers.parse(l, None) + print (x), '%10s' % phonenumbers.is_valid_number(x) -# Number validity check -number_validity_check = { '1932621160' : 'BR' } # To be fixed by Dialpad Changes -dialpad_cases = ['+6278033212174', # https://switchcomm.atlassian.net/browse/DP-13742 - '+63283168971', # Philipines - '+8031000000141', # Dialpadistan +dialpad_cases = ['+6278033212174', # https://switchcomm.atlassian.net/browse/DP-13742 + '+63283168971', # Philipines + '+8031000000141', # Dialpadistan ] -#Invalid Strings -invalid_strings = [ '+4916190899790', # https://switchcomm.atlassian.net/browse/TEL-8824 Not Fixed - '+2022577744', - '+205739250', - '+8412032453', # https://switchcomm.atlassian.net/browse/DP-13742 - ] +print '######### - VALID BY DIALPAD - ################' +for l in dialpad_cases: + try: + x = phonenumbers.parse(l, None) + print (x), '%10s' % phonenumbers.is_valid_number(x) + except Exception as e: + print (l), '%10s' % (e) + +# Invalid Strings +invalid_strings = ['+4916190899790', # https://switchcomm.atlassian.net/browse/TEL-8824 Not Fixed + '+2022577744', + '+205739250', + '+8412032453', # https://switchcomm.atlassian.net/browse/DP-13742 + ] -print '######### -NUMBER VALIDITY CHECK - ###############' -for l in number_validity_check: - region = number_validity_check[l] - x = phonenumbers.parse(l, region) - print (x), 'Region : %s -> %10s' % (region, phonenumbers.is_valid_number(x)) +print '######### - INVALID NUMBERS - ################' +for l in invalid_strings: + x = phonenumbers.parse(l, None) + print (x), '%10s' % phonenumbers.is_valid_number(x) -print '######### -NUMBER FORMAT VALID - ################' +# National Format match +national_format_match = {'+525547808256': '55 4780 8256'} + +print '######### - NUMBER FORMAT VALIDITY - ################' for l in national_format_match: x = phonenumbers.parse(l, None) y = phonenumbers.format_number(x, phonenumbers.PhoneNumberFormat.NATIONAL) if national_format_match[l] == y: status = 'Success' else: - status = 'Failed' - - print (l), '-> %10s : %s' % (y, status) + status = 'Failed' + print (l), '-> %10s : %s' % (y, status) -print '######### - VALID - ################' -for l in valid_strings: - x = phonenumbers.parse(l, None) - print (x), '%10s' % phonenumbers.is_valid_number(x) - -print '######### - DIALPAD - ################' -for l in dialpad_cases: - try: - x = phonenumbers.parse(l, None) - print (x), '%10s' % phonenumbers.is_valid_number(x) - except Exception as e: - print (l), '%10s' % (e) - -print '######### - INVALID - ################' -for l in invalid_strings: - x = phonenumbers.parse(l, None) - print (x), '%10s' % phonenumbers.is_valid_number(x) +# Number validity check +number_validity_check = {'1932621160': 'BR'} +print '######### - REGION NUMBER VALIDITY - ###############' +for l in number_validity_check: + region = number_validity_check[l] + x = phonenumbers.parse(l, region) + print (x), 'Region : %s -> %10s' % (region, phonenumbers.is_valid_number(x)) From 664112a8f850553cf837a38c8b24649d67b57cbb Mon Sep 17 00:00:00 2001 From: Corey Burke Date: Tue, 31 Jul 2018 09:09:04 -0700 Subject: [PATCH 03/12] Add Dialpadistan region --- python/phonenumbers/data/__init__.py | 5 +++++ python/phonenumbers/data/region_DP.py | 8 ++++++++ 2 files changed, 13 insertions(+) create mode 100644 python/phonenumbers/data/region_DP.py diff --git a/python/phonenumbers/data/__init__.py b/python/phonenumbers/data/__init__.py index ea15cdee1..23d193572 100644 --- a/python/phonenumbers/data/__init__.py +++ b/python/phonenumbers/data/__init__.py @@ -17,6 +17,7 @@ _AVAILABLE_REGION_CODES = ['AC','AD','AE','AF','AG','AI','AL','AM','AO','AR','AS','AT','AU','AW','AX','AZ','BA','BB','BD','BE','BF','BG','BH','BI','BJ','BL','BM','BN','BO','BQ','BR','BS','BT','BW','BY','BZ','CA','CC','CD','CF','CG','CH','CI','CK','CL','CM','CN','CO','CR','CU','CV','CW','CX','CY','CZ','DE','DJ','DK','DM','DO','DZ','EC','EE','EG','EH','ER','ES','ET','FI','FJ','FK','FM','FO','FR','GA','GB','GD','GE','GF','GG','GH','GI','GL','GM','GN','GP','GQ','GR','GT','GU','GW','GY','HK','HN','HR','HT','HU','ID','IE','IL','IM','IN','IO','IQ','IR','IS','IT','JE','JM','JO','JP','KE','KG','KH','KI','KM','KN','KP','KR','KW','KY','KZ','LA','LB','LC','LI','LK','LR','LS','LT','LU','LV','LY','MA','MC','MD','ME','MF','MG','MH','MK','ML','MM','MN','MO','MP','MQ','MR','MS','MT','MU','MV','MW','MX','MY','MZ','NA','NC','NE','NF','NG','NI','NL','NO','NP','NR','NU','NZ','OM','PA','PE','PF','PG','PH','PK','PL','PM','PR','PS','PT','PW','PY','QA','RE','RO','RS','RU','RW','SA','SB','SC','SD','SE','SG','SH','SI','SJ','SK','SL','SM','SN','SO','SR','SS','ST','SV','SX','SY','SZ','TA','TC','TD','TG','TH','TJ','TK','TL','TM','TN','TO','TR','TT','TV','TW','TZ','UA','UG','US','UY','UZ','VA','VC','VE','VG','VI','VN','VU','WF','WS','XK','YE','YT','ZA','ZM','ZW'] _AVAILABLE_NONGEO_COUNTRY_CODES = [800, 808, 870, 878, 881, 882, 883, 888, 979] +_DIALPADISTAN_NONGEO_REGION_CODES = ['DP'] def _load_region(code): __import__("region_%s" % code, globals(), locals(), @@ -29,6 +30,9 @@ def _load_region(code): for country_code in _AVAILABLE_NONGEO_COUNTRY_CODES: PhoneMetadata.register_nongeo_region_loader(country_code, _load_region) +for region_code in _DIALPADISTAN_NONGEO_REGION_CODES: + PhoneMetadata.register_region_loader(region_code, _load_region) + from .alt_format_255 import PHONE_ALT_FORMAT_255 from .alt_format_27 import PHONE_ALT_FORMAT_27 from .alt_format_30 import PHONE_ALT_FORMAT_30 @@ -298,4 +302,5 @@ def _load_region(code): 995: ("GE",), 996: ("KG",), 998: ("UZ",), + 803: ("DP",), # Dialpadistan } diff --git a/python/phonenumbers/data/region_DP.py b/python/phonenumbers/data/region_DP.py new file mode 100644 index 000000000..832109f9a --- /dev/null +++ b/python/phonenumbers/data/region_DP.py @@ -0,0 +1,8 @@ +"""Auto-generated file, do not edit by hand. 800 metadata""" +from ..phonemetadata import NumberFormat, PhoneNumberDesc, PhoneMetadata + +PHONE_METADATA_DP = PhoneMetadata(id='DP', country_code=803, international_prefix=None, + general_desc=PhoneNumberDesc(national_number_pattern='\\d{10}', possible_length=(10,)), + voip=PhoneNumberDesc(national_number_pattern='\\d{10}', possible_length=(10,)), + number_format=[NumberFormat(pattern='(\\d{3})(\\d{7})', format='\\1\\2')], + leading_zero_possible=False) From cac4a5968ea9c7683e3593ac2eff4c995cbb0e1a Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Tue, 11 Feb 2020 19:46:09 -0800 Subject: [PATCH 04/12] TEL-10934 - Unable To Dialpad Florida Number From Desktop & Mobile App --- python/test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/test.py b/python/test.py index 61819e10b..a39855a5d 100644 --- a/python/test.py +++ b/python/test.py @@ -10,7 +10,8 @@ '+84384813220', '+84357659677', '+56232512653', # https://switchcomm.atlassian.net/browse/TEL-9285 - '+525547808256'] + '+525547808256', + '+16892226575'] print '######### - VALID BY LIBRARY - ################' for l in valid_strings: @@ -36,7 +37,6 @@ invalid_strings = ['+4916190899790', # https://switchcomm.atlassian.net/browse/TEL-8824 Not Fixed '+2022577744', '+205739250', - '+8412032453', # https://switchcomm.atlassian.net/browse/DP-13742 ] print '######### - INVALID NUMBERS - ################' From a3885f4046461813d955510ae8b254a0d63ad36e Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Wed, 1 Jul 2020 14:36:10 -0700 Subject: [PATCH 05/12] Changes for new NPA in Canada --- python/test.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/test.py b/python/test.py index a39855a5d..7c1730532 100644 --- a/python/test.py +++ b/python/test.py @@ -11,6 +11,7 @@ '+84357659677', '+56232512653', # https://switchcomm.atlassian.net/browse/TEL-9285 '+525547808256', + '+13677395285', '+16892226575'] print '######### - VALID BY LIBRARY - ################' From 512facf243c0f103152bfd1b1503fa1498fef748 Mon Sep 17 00:00:00 2001 From: Dana Hoffmann Date: Thu, 20 Sep 2018 10:52:05 -0700 Subject: [PATCH 06/12] DP-13742: Fix to Indonesia toll free numbers --- python/phonenumbers/data/region_ID.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/phonenumbers/data/region_ID.py b/python/phonenumbers/data/region_ID.py index 331041bbb..0b7551b9b 100644 --- a/python/phonenumbers/data/region_ID.py +++ b/python/phonenumbers/data/region_ID.py @@ -5,7 +5,7 @@ general_desc=PhoneNumberDesc(national_number_pattern='(?:(?:00[1-9]|8\\d)\\d{4}|[1-36])\\d{6}|00\\d{10}|[1-9]\\d{8,10}|[2-9]\\d{7}', possible_length=(7, 8, 9, 10, 11, 12, 13), possible_length_local_only=(5, 6)), fixed_line=PhoneNumberDesc(national_number_pattern='2[124]\\d{7,8}|619\\d{8}|2(?:1(?:14|500)|2\\d{3})\\d{3}|61\\d{5,8}|(?:2(?:[35][1-4]|6[0-8]|7[1-6]|8\\d|9[1-8])|3(?:1|[25][1-8]|3[1-68]|4[1-3]|6[1-3568]|7[0-469]|8\\d)|4(?:0[1-589]|1[01347-9]|2[0-36-8]|3[0-24-68]|43|5[1-378]|6[1-5]|7[134]|8[1245])|5(?:1[1-35-9]|2[25-8]|3[124-9]|4[1-3589]|5[1-46]|6[1-8])|6(?:[25]\\d|3[1-69]|4[1-6])|7(?:02|[125][1-9]|[36]\\d|4[1-8]|7[0-36-9])|9(?:0[12]|1[013-8]|2[0-479]|5[125-8]|6[23679]|7[159]|8[01346]))\\d{5,8}', example_number='218350123', possible_length=(7, 8, 9, 10, 11), possible_length_local_only=(5, 6)), mobile=PhoneNumberDesc(national_number_pattern='8[1-35-9]\\d{7,10}', example_number='812345678', possible_length=(9, 10, 11, 12)), - toll_free=PhoneNumberDesc(national_number_pattern='00[17]803\\d{7}|(?:177\\d|800)\\d{5,7}|001803\\d{6}', example_number='8001234567', possible_length=(8, 9, 10, 11, 12, 13)), + toll_free=PhoneNumberDesc(national_number_pattern='00[17]803\\d{7}|(?:177\\d|800)\\d{5,7}|001803\\d{6}|7803\\d{7}', example_number='8001234567', possible_length=(8, 9, 10, 11, 12, 13)), premium_rate=PhoneNumberDesc(national_number_pattern='809\\d{7}', example_number='8091234567', possible_length=(10,)), shared_cost=PhoneNumberDesc(national_number_pattern='804\\d{7}', example_number='8041234567', possible_length=(10,)), uan=PhoneNumberDesc(national_number_pattern='(?:1500|8071\\d{3})\\d{3}', example_number='8071123456', possible_length=(7, 10)), From 4fdf2b7293a2ca452081f481f6c9c518395c39d9 Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Thu, 15 Oct 2020 00:10:57 -0700 Subject: [PATCH 07/12] TEL-12621 - Unable dial new Poland Police prefix +48 47 731 4848 Summary: TEL-12621 - Unable dial new Poland Police prefix +48 47 731 4848 Test Plan: added Reviewers: jerin Differential Revision: https://phabricator.fspot.us/D14990 --- python/test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/test.py b/python/test.py index 7c1730532..237a2f1d5 100644 --- a/python/test.py +++ b/python/test.py @@ -12,7 +12,8 @@ '+56232512653', # https://switchcomm.atlassian.net/browse/TEL-9285 '+525547808256', '+13677395285', - '+16892226575'] + '+16892226575', + '+48477314848'] print '######### - VALID BY LIBRARY - ################' for l in valid_strings: From 773c31483f19028bc0646d26d05592316a254a90 Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Thu, 15 Oct 2020 15:11:44 -0700 Subject: [PATCH 08/12] Rename test file --- python/{test.py => dialpad_tests.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename python/{test.py => dialpad_tests.py} (100%) diff --git a/python/test.py b/python/dialpad_tests.py similarity index 100% rename from python/test.py rename to python/dialpad_tests.py From b539ec2c9a733e54c8451d8938d7c74515d365d0 Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Tue, 26 Jan 2021 23:41:07 -0800 Subject: [PATCH 09/12] TEL-13057 - Supporting new Number format for Ivory Coast Summary: Picked these regex changes from the build branch of Google. https://github.com/google/libphonenumber/blob/bc215578007c2a985a37f20597a5067744dca6b9/javascript/i18n/phonenumbers/metadatalite.js The changes will take time to make it through the google release and the david's phone numbers lib. For the migration on Jan 31st we need to push this lib changes for the numbers to be edited and added on product Test Plan: NA Reviewers: nick, jerin Reviewed By: nick Differential Revision: https://phabricator.fspot.us/D15409 --- python/dialpad_tests.py | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/python/dialpad_tests.py b/python/dialpad_tests.py index 237a2f1d5..54fef0fb0 100644 --- a/python/dialpad_tests.py +++ b/python/dialpad_tests.py @@ -18,22 +18,25 @@ print '######### - VALID BY LIBRARY - ################' for l in valid_strings: x = phonenumbers.parse(l, None) - print (x), '%10s' % phonenumbers.is_valid_number(x) - + print '%15s' % l, '%10s' % phonenumbers.is_valid_number(x), '%25s' % x # To be fixed by Dialpad Changes -dialpad_cases = ['+6278033212174', # https://switchcomm.atlassian.net/browse/DP-13742 - '+63283168971', # Philipines - '+8031000000141', # Dialpadistan +dialpad_cases = ['+6278033212174', # https://switchcomm.atlassian.net/browse/DP-13742 + '+63283168971', # Philipines + '+8031000000141', # Dialpadistan + '+22557715034', # Ivory Coast - Old Format + '+2250757715034', # Ivory Coast - New Format + '+22521214601', # Ivory Coast - Old Format + '+2252721214601', # Ivory Coast - New Format ] print '######### - VALID BY DIALPAD - ################' for l in dialpad_cases: try: x = phonenumbers.parse(l, None) - print (x), '%10s' % phonenumbers.is_valid_number(x) + print '%15s' % l, '%10s' % phonenumbers.is_valid_number(x), '%25s' % x except Exception as e: - print (l), '%10s' % (e) + print '%15s' % l, '%25s' % (e) # Invalid Strings invalid_strings = ['+4916190899790', # https://switchcomm.atlassian.net/browse/TEL-8824 Not Fixed @@ -44,7 +47,7 @@ print '######### - INVALID NUMBERS - ################' for l in invalid_strings: x = phonenumbers.parse(l, None) - print (x), '%10s' % phonenumbers.is_valid_number(x) + print '%15s' % l, '%10s' % phonenumbers.is_valid_number(x), '%25s' % x # National Format match national_format_match = {'+525547808256': '55 4780 8256'} @@ -65,4 +68,5 @@ for l in number_validity_check: region = number_validity_check[l] x = phonenumbers.parse(l, region) - print (x), 'Region : %s -> %10s' % (region, phonenumbers.is_valid_number(x)) + print '%15s' % l, '%10s -> Region : %5s' % (phonenumbers.is_valid_number(x), region) + From 52072a00cbd85f5f4f48639cc1dc8d34f20dc95c Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Tue, 13 Jul 2021 16:09:59 -0700 Subject: [PATCH 10/12] Changes for TEL-14473 --- python/dialpad_tests.py | 23 ++++++++++++----------- python/phonenumbers/data/region_SG.py | 4 ++-- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/python/dialpad_tests.py b/python/dialpad_tests.py index 54fef0fb0..e605bae17 100644 --- a/python/dialpad_tests.py +++ b/python/dialpad_tests.py @@ -1,8 +1,7 @@ import phonenumbers # Fixed by Phonenumbers Cases -valid_strings = ['+6323168971', - '+442083661177', +valid_strings = ['+442083661177', '+658003211137', '+20573925008', '+2057392500', @@ -13,7 +12,11 @@ '+525547808256', '+13677395285', '+16892226575', - '+48477314848'] + '+18404440531', + '+48477314848', + '+6569786318', + '+6560115374', # https://switchcomm.atlassian.net/browse/TEL-14616 + ] print '######### - VALID BY LIBRARY - ################' for l in valid_strings: @@ -21,13 +24,11 @@ print '%15s' % l, '%10s' % phonenumbers.is_valid_number(x), '%25s' % x # To be fixed by Dialpad Changes -dialpad_cases = ['+6278033212174', # https://switchcomm.atlassian.net/browse/DP-13742 - '+63283168971', # Philipines - '+8031000000141', # Dialpadistan - '+22557715034', # Ivory Coast - Old Format - '+2250757715034', # Ivory Coast - New Format - '+22521214601', # Ivory Coast - Old Format - '+2252721214601', # Ivory Coast - New Format +dialpad_cases = ['+6278033212174', # https://switchcomm.atlassian.net/browse/DP-13742 + '+63283168971', # Philipines + '+8031000000141', # Dialpadistan + '+2250757715034', # Ivory Coast - New Format + '+2252721214601', # Ivory Coast - New Format ] print '######### - VALID BY DIALPAD - ################' @@ -36,7 +37,7 @@ x = phonenumbers.parse(l, None) print '%15s' % l, '%10s' % phonenumbers.is_valid_number(x), '%25s' % x except Exception as e: - print '%15s' % l, '%25s' % (e) + print '%15s' % l, '%25s' % e # Invalid Strings invalid_strings = ['+4916190899790', # https://switchcomm.atlassian.net/browse/TEL-8824 Not Fixed diff --git a/python/phonenumbers/data/region_SG.py b/python/phonenumbers/data/region_SG.py index 09a5ad93a..3ac587f58 100644 --- a/python/phonenumbers/data/region_SG.py +++ b/python/phonenumbers/data/region_SG.py @@ -3,8 +3,8 @@ PHONE_METADATA_SG = PhoneMetadata(id='SG', country_code=65, international_prefix='0[0-3]\\d', general_desc=PhoneNumberDesc(national_number_pattern='(?:(?:1\\d|8)\\d\\d|7000)\\d{7}|[3689]\\d{7}', possible_length=(8, 10, 11)), - fixed_line=PhoneNumberDesc(national_number_pattern='662[0-24-9]\\d{4}|6(?:[1-578]\\d|6[013-57-9]|9[0-35-9])\\d{5}', example_number='61234567', possible_length=(8,)), - mobile=PhoneNumberDesc(national_number_pattern='(?:8(?:0(?:[13]\\d|2[013-9]|4[015-7])|[1-8]\\d\\d|9(?:[0-4]\\d|5[0-2]))|9[0-8]\\d\\d)\\d{4}', example_number='81234567', possible_length=(8,)), + fixed_line=PhoneNumberDesc(national_number_pattern='662[0-24-9]\\d{4}|6(?:[0-578]\\d|6[013-57-9]|9[0-35-9])\\d{5}', example_number='61234567', possible_length=(8,)), + mobile=PhoneNumberDesc(national_number_pattern='(?:8(?:0(?:[13]\\d|2[013-9]|4[015])|[1-8]\\d\\d|9(?:[0-4]\\d|5[0-2]))|9[0-8]\\d\\d)\\d{4}', example_number='81234567', possible_length=(8,)), toll_free=PhoneNumberDesc(national_number_pattern='(?:18|8)00\\d{7}', example_number='18001234567', possible_length=(10, 11)), premium_rate=PhoneNumberDesc(national_number_pattern='1900\\d{7}', example_number='19001234567', possible_length=(11,)), voip=PhoneNumberDesc(national_number_pattern='(?:3[12]\\d|666)\\d{5}', example_number='31234567', possible_length=(8,)), From a21ee1087e44aca51fb70fc7c3b65f53f39bb280 Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Mon, 6 Sep 2021 23:51:52 -0700 Subject: [PATCH 11/12] New Colombia format --- python/dialpad_tests.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/python/dialpad_tests.py b/python/dialpad_tests.py index e605bae17..60462dbe5 100644 --- a/python/dialpad_tests.py +++ b/python/dialpad_tests.py @@ -16,6 +16,8 @@ '+48477314848', '+6569786318', '+6560115374', # https://switchcomm.atlassian.net/browse/TEL-14616 + '+576015088865', # https://switchcomm.atlassian.net/browse/TEL-14616 + '+5715088865', # https://switchcomm.atlassian.net/browse/TEL-14616 ] print '######### - VALID BY LIBRARY - ################' From 0987a62f52caf719cc8200d76b5adeb7213f60e4 Mon Sep 17 00:00:00 2001 From: Rajesh Panicker Date: Mon, 13 Sep 2021 23:10:33 -0700 Subject: [PATCH 12/12] Fixing the Unit Tests for Region Dialpadistan --- python/phonenumbers/data/region_DP.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/phonenumbers/data/region_DP.py b/python/phonenumbers/data/region_DP.py index 832109f9a..b4b7e94cc 100644 --- a/python/phonenumbers/data/region_DP.py +++ b/python/phonenumbers/data/region_DP.py @@ -2,7 +2,7 @@ from ..phonemetadata import NumberFormat, PhoneNumberDesc, PhoneMetadata PHONE_METADATA_DP = PhoneMetadata(id='DP', country_code=803, international_prefix=None, - general_desc=PhoneNumberDesc(national_number_pattern='\\d{10}', possible_length=(10,)), - voip=PhoneNumberDesc(national_number_pattern='\\d{10}', possible_length=(10,)), + general_desc=PhoneNumberDesc(national_number_pattern='\\d{10}', example_number='1000000141', possible_length=(10,)), + voip=PhoneNumberDesc(national_number_pattern='\\d{10}', example_number='1000000141', possible_length=(10,)), number_format=[NumberFormat(pattern='(\\d{3})(\\d{7})', format='\\1\\2')], leading_zero_possible=False)