Merge pull request #14 from dicoding-dev/feature/upgrade-doctrine-dbal

Upgrade `doctrine/dbal` from `2.x` to `3.x`

Author: rizqyhi

src/Illuminate/Database/Connection.php

@@ -822,7 +822,13 @@ public function getDoctrineColumn($table, $column)
 	 */
 	public function getDoctrineSchemaManager()
 	{
-		return $this->getDoctrineDriver()->getSchemaManager($this->getDoctrineConnection());
+        $connection = $this->getDoctrineConnection();
+
+        // Doctrine v2 expects one parameter while v3 expects two. 2nd will be ignored on v2...
+        return $this->getDoctrineDriver()->getSchemaManager(
+            $connection,
+            $connection->getDatabasePlatform()
+        );
 	}
 
 	/**
@@ -834,9 +840,14 @@ public function getDoctrineConnection()
 	{
 		$driver = $this->getDoctrineDriver();
 
-		$data = array('pdo' => $this->pdo, 'dbname' => $this->getConfig('database'));
-
-		return new DoctrineConnection($data, $driver);
+		return new DoctrineConnection([
+            'host' => $this->getConfig('host'),
+            'port' => $this->getConfig('port'),
+            'user' => $this->getConfig('username'),
+            'password' => $this->getConfig('password'),
+            'dbname' => $this->getDatabaseName(),
+            'charset' => $this->getConfig('charset'),
+        ], $driver);
 	}
 
 	/**

src/Illuminate/Database/MySqlConnection.php

@@ -1,7 +1,7 @@
 <?php namespace Illuminate\Database;
 
 use Illuminate\Database\Schema\MySqlBuilder;
-use Doctrine\DBAL\Driver\PDOMySql\Driver as DoctrineDriver;
+use Doctrine\DBAL\Driver\PDO\MySQL\Driver as DoctrineDriver;
 use Illuminate\Database\Query\Grammars\MySqlGrammar as QueryGrammar;
 use Illuminate\Database\Schema\Grammars\MySqlGrammar as SchemaGrammar;
 
@@ -52,7 +52,7 @@ protected function getDefaultPostProcessor()
 	/**
 	 * Get the Doctrine DBAL driver.
 	 *
-	 * @return \Doctrine\DBAL\Driver\PDOMySql\Driver
+	 * @return \Doctrine\DBAL\Driver\PDO\MySQL\Driver
 	 */
 	protected function getDoctrineDriver()
 	{

src/Illuminate/Database/PostgresConnection.php

@@ -1,6 +1,6 @@
 <?php namespace Illuminate\Database;
 
-use Doctrine\DBAL\Driver\PDOPgSql\Driver as DoctrineDriver;
+use Doctrine\DBAL\Driver\PDO\PgSQL\Driver as DoctrineDriver;
 use Illuminate\Database\Query\Processors\PostgresProcessor;
 use Illuminate\Database\Query\Grammars\PostgresGrammar as QueryGrammar;
 use Illuminate\Database\Schema\Grammars\PostgresGrammar as SchemaGrammar;
@@ -40,7 +40,7 @@ protected function getDefaultPostProcessor()
 	/**
 	 * Get the Doctrine DBAL driver.
 	 *
-	 * @return \Doctrine\DBAL\Driver\PDOPgSql\Driver
+	 * @return \Doctrine\DBAL\Driver\PDO\PgSQL\Driver
 	 */
 	protected function getDoctrineDriver()
 	{

src/Illuminate/Database/SQLiteConnection.php

@@ -1,6 +1,6 @@
 <?php namespace Illuminate\Database;
 
-use Doctrine\DBAL\Driver\PDOSqlite\Driver as DoctrineDriver;
+use Doctrine\DBAL\Driver\PDO\SQLite\Driver as DoctrineDriver;
 use Illuminate\Database\Query\Grammars\SQLiteGrammar as QueryGrammar;
 use Illuminate\Database\Schema\Grammars\SQLiteGrammar as SchemaGrammar;
 
@@ -39,7 +39,7 @@ protected function getDefaultPostProcessor()
 	/**
 	 * Get the Doctrine DBAL driver.
 	 *
-	 * @return \Doctrine\DBAL\Driver\PDOSqlite\Driver
+	 * @return \Doctrine\DBAL\Driver\PDO\SQLite\Driver
 	 */
 	protected function getDoctrineDriver()
 	{

src/Illuminate/Database/Schema/Grammars/Grammar.php

@@ -63,13 +63,22 @@ protected function getRenamedDiff(Blueprint $blueprint, Fluent $command, Column
 	 */
 	protected function setRenamedColumns(TableDiff $tableDiff, Fluent $command, Column $column)
 	{
-		$newColumn = new Column($command->to, $column->getType(), $column->toArray());
-
-		$tableDiff->renamedColumns = array($command->from => $newColumn);
+		$tableDiff->renamedColumns = array(
+            $command->from => new Column($command->to, $column->getType(), self::getWritableColumnOptions($column))
+        );
 
 		return $tableDiff;
 	}
 
+    private static function getWritableColumnOptions(Column $column): array
+    {
+        return array_filter(
+            $column->toArray(),
+            fn (string $name) => method_exists($column, 'set'.$name),
+            ARRAY_FILTER_USE_KEY
+        );
+    }
+
 	/**
 	 * Compile a foreign key command.
 	 *

src/Illuminate/Database/SqlServerConnection.php

@@ -1,7 +1,7 @@
 <?php namespace Illuminate\Database;
 
 use Closure;
-use Doctrine\DBAL\Driver\PDOSqlsrv\Driver as DoctrineDriver;
+use Doctrine\DBAL\Driver\PDO\SQLSrv\Driver as DoctrineDriver;
 use Illuminate\Database\Query\Processors\SqlServerProcessor;
 use Illuminate\Database\Query\Grammars\SqlServerGrammar as QueryGrammar;
 use Illuminate\Database\Schema\Grammars\SqlServerGrammar as SchemaGrammar;
@@ -87,7 +87,7 @@ protected function getDefaultPostProcessor()
 	/**
 	 * Get the Doctrine DBAL Driver.
 	 *
-	 * @return \Doctrine\DBAL\Driver\PDOSqlsrv\Driver
+	 * @return \Doctrine\DBAL\Driver\PDO\SQLSrv\Driver
 	 */
 	protected function getDoctrineDriver()
 	{