Skip to content

Commit 10537fa

Browse files
authored
fix: search in this folder only crashes (500) (#1366)
* Fix search in this folder only bug * Typo fix
1 parent 548cb3f commit 10537fa

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

filer/admin/folderadmin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,16 +297,16 @@ def directory_listing(self, request, folder_id=None, viewtype=None):
297297

298298
if len(search_terms) > 0:
299299
if folder and limit_search_to_folder and not folder.is_root:
300+
desc_folder_ids = folder.get_descendants_ids()
300301
# Do not include current folder itself in search results.
301-
folder_qs = folder.get_descendants(include_self=False)
302+
folder_qs = Folder.objects.filter(pk__in=desc_folder_ids)
302303
# Limit search results to files in the current folder or any
303304
# nested folder.
304-
file_qs = File.objects.filter(
305-
folder__in=folder.get_descendants(include_self=True))
305+
file_qs = File.objects.filter(folder_id__in=desc_folder_ids + [folder.pk])
306306
else:
307307
folder_qs = self.get_queryset(request)
308308
file_qs = File.objects.all()
309-
folder_qs = self.filter_folder(folder_qs, search_terms)
309+
folder_qs = self.filter_folder(folder_qs, search_terms).prefetch_related("children", "all_files")
310310
file_qs = self.filter_file(file_qs, search_terms)
311311

312312
show_result_count = True

filer/templates/admin/filer/folder/directory_listing.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ <h2>&nbsp;</h2>
146146
<input type="text" placeholder="{% trans 'Search' %}" class="filter-files-field js-filter-files" value="{{ search_string }}" name="q">
147147
<div class="filer-dropdown-container filer-dropdown-container-down">
148148
<a href="#" data-toggle="filer-dropdown" aria-expanded="false">
149-
<span class="fa fa-caret-down cms-icon cms-filer-icon-caret-down"></span>
149+
<span class="filer-icon filer-icon-caret-down fa fa-caret-down"></span>
150150
</a>
151151
</div>
152152
<ul class="filer-dropdown-menu filer-dropdown-menu-checkboxes">

0 commit comments

Comments
 (0)