drop python 3.8 - fix #130

Author: bckohan

.github/workflows/lint.yml

@@ -18,21 +18,21 @@ jobs:
     strategy:
       matrix:
         # run static analysis on bleeding and trailing edges
-        python-version: [ '3.8', '3.10', '3.13' ]
+        python-version: [ '3.9', '3.10', '3.13' ]
         django-version:
           - '3.2' # LTS April 2024
           - '4.2' # LTS April 2026
           - '5.1' # December 2025
         exclude:
-          - python-version: '3.8'
+          - python-version: '3.9'
             django-version: '4.2'
           - python-version: '3.13'
             django-version: '4.2'
           - python-version: '3.13'
             django-version: '3.2'
           - python-version: '3.10'
             django-version: '3.2'
-          - python-version: '3.8'
+          - python-version: '3.9'
             django-version: '5.1'
           - python-version: '3.10'
             django-version: '5.1'

.github/workflows/test.yml

@@ -19,23 +19,19 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
+        python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
         django-version:
           - '3.2' # LTS April 2024
           - '4.2' # LTS April 2026
           - '5.0' # April 2025
           - '5.1' # December 2025
         exclude:
-          - python-version: '3.8'
-            django-version: '5.0'
           - python-version: '3.9'
             django-version: '5.0'
           - python-version: '3.11'
             django-version: '3.2'
           - python-version: '3.12'
             django-version: '3.2'
-          - python-version: '3.8'
-            django-version: '5.1'
           - python-version: '3.9'
             django-version: '5.1'
           - python-version: '3.13'
@@ -93,12 +89,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ['3.8', '3.13']
+        python-version: ['3.9', '3.13']
         django-version:
           - '3.2' # LTS April 2024
           - '5.1' # December 2025
         exclude:
-          - python-version: '3.8'
+          - python-version: '3.9'
             django-version: '5.1'
           - python-version: '3.13'
             django-version: '3.2'
@@ -150,12 +146,12 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        python-version: ['3.8', '3.13']
+        python-version: ['3.9', '3.13']
         django-version:
           - '3.2' # LTS April 2024
           - '5.1' # December 2025
         exclude:
-          - python-version: '3.8'
+          - python-version: '3.9'
             django-version: '5.1'
           - python-version: '3.13'
             django-version: '3.2'
@@ -234,12 +230,12 @@ jobs:
   #   runs-on: windows-latest
   #   strategy:
   #     matrix:
-  #       python-version: ['3.8', '3.13']
+  #       python-version: ['3.9', '3.13']
   #       django-version:
   #         - '3.2' # LTS April 2024
   #         - '5.0' # April 2025
   #       exclude:
-  #         - python-version: '3.8'
+  #         - python-version: '3.9'
   #           django-version: '5.0'
   #         - python-version: '3.13'
   #           django-version: '3.2'

README.md

@@ -71,7 +71,7 @@ Please refer to the [full documentation](https://django-typer.readthedocs.io/) f
 
 ## Basic Example
 
-[TyperCommand](https://django-typer.readthedocs.io/en/latest/reference.html#django_typer.TyperCommand) is a very simple drop in replacement for [BaseCommand](https://docs.djangoproject.com/en/stable/howto/custom-management-commands/#django.core.management.BaseCommand). All of the documented features of [BaseCommand](https://docs.djangoproject.com/en/stable/howto/custom-management-commands/#django.core.management.BaseCommand) work the same way!
+[TyperCommand](https://django-typer.readthedocs.io/en/latest/reference.html#django_typer.TyperCommand) is a drop in extension to [BaseCommand](https://docs.djangoproject.com/en/stable/howto/custom-management-commands/#django.core.management.BaseCommand). All of the documented features of [BaseCommand](https://docs.djangoproject.com/en/stable/howto/custom-management-commands/#django.core.management.BaseCommand) work the same way!
 
 ```python
 from django_typer.management import TyperCommand

django_typer/management/__init__.py

@@ -775,11 +775,6 @@ class Command(
             else:
                 return Typer(**kwargs)
 
-        if sys.version_info < (3, 9):
-            # this is a workaround for a bug in python 3.8 that causes multiple
-            # values for cls error. 3.8 support is sun setting soon so we just punt
-            # on this one - REMOVE when 3.8 support is dropped
-            kwargs.pop("cls", None)
         return super().__call__(*args, **kwargs)
 
 
@@ -1875,7 +1870,7 @@ def __new__(
         bases,
         attrs,
         name: t.Optional[str] = Default(None),
-        # cls: t.Optional[t.Type[DTGroup]] = DTGroup,
+        cls: t.Optional[t.Type[DTGroup]] = DTGroup,
         invoke_without_command: bool = Default(False),
         no_args_is_help: bool = Default(False),
         subcommand_metavar: t.Optional[str] = Default(None),
@@ -1941,7 +1936,7 @@ def command_bases() -> t.Generator[t.Type[TyperCommand], None, None]:
 
             typer_app = Typer(
                 name=name or attrs.get("__module__", "").rsplit(".", maxsplit=1)[-1],
-                cls=kwargs.pop("cls", DTGroup),
+                cls=cls,
                 help=help or attr_help,  # pyright: ignore[reportArgumentType]
                 invoke_without_command=invoke_without_command,
                 no_args_is_help=no_args_is_help,

django_typer/management/commands/shellcompletion.py

@@ -28,14 +28,8 @@
 import os
 import sys
 import typing as t
-from pathlib import Path
-
-if sys.version_info < (3, 9):
-    from typing_extensions import Annotated
-else:
-    from typing import Annotated
-
 from functools import cached_property
+from pathlib import Path
 
 from click.parser import split_arg_string
 from click.shell_completion import (
@@ -270,15 +264,15 @@ def replace(s: str, old: str, new: str, occurrences: t.List[int]) -> str:
     )
     def install(
         self,
-        shell: Annotated[
+        shell: t.Annotated[
             t.Optional[Shells],
             Argument(
                 help=t.cast(
                     str, _("Specify the shell to install or remove autocompletion for.")
                 )
             ),
         ] = DETECTED_SHELL,
-        manage_script: Annotated[
+        manage_script: t.Annotated[
             t.Optional[str],
             Option(
                 help=t.cast(
@@ -290,7 +284,7 @@ def install(
                 )
             ),
         ] = None,
-        fallback: Annotated[
+        fallback: t.Annotated[
             t.Optional[str],
             Option(
                 help=t.cast(
@@ -337,7 +331,7 @@ def install(
     )
     def remove(
         self,
-        shell: Annotated[
+        shell: t.Annotated[
             t.Optional[Shells],
             Argument(
                 help=t.cast(
@@ -346,7 +340,7 @@ def remove(
                 )
             ),
         ] = DETECTED_SHELL,
-        manage_script: Annotated[
+        manage_script: t.Annotated[
             t.Optional[str],
             Option(
                 help=t.cast(
@@ -444,7 +438,7 @@ def remove(
     )
     def complete(
         self,
-        cmd_str: Annotated[
+        cmd_str: t.Annotated[
             t.Optional[str],
             Argument(
                 metavar="command",
@@ -453,7 +447,7 @@ def complete(
                 ),
             ),
         ] = None,
-        shell: Annotated[
+        shell: t.Annotated[
             t.Optional[Shells],
             Option(
                 help=t.cast(
@@ -464,7 +458,7 @@ def complete(
                 )
             ),
         ] = None,
-        fallback: Annotated[
+        fallback: t.Annotated[
             t.Optional[str],
             Option(
                 help=t.cast(

django_typer/types.py

@@ -6,12 +6,7 @@
 
 import sys
 from pathlib import Path
-from typing import Optional, cast
-
-if sys.version_info < (3, 9):
-    from typing_extensions import Annotated
-else:
-    from typing import Annotated
+from typing import Annotated, Optional, cast
 
 from django.core.management import CommandError
 from django.utils.translation import gettext_lazy as _

doc/source/changelog.rst

@@ -5,6 +5,7 @@ Change Log
 v2.2.3 (2024-10-xx)
 ===================
 
+* Implemented `Drop python 3.8 support. <https://github.com/django-commons/django-typer/issues/130>`_
 * Implemented `Command help order should respect definition order for class based commands. <https://github.com/django-commons/django-typer/issues/129>`_
 * Fixed `Overriding the command group class does not work. <https://github.com/django-commons/django-typer/issues/128>`_
 * Completed `Add project to test PyPI <https://github.com/django-commons/django-typer/issues/126>`_

doc/source/index.rst

@@ -82,9 +82,9 @@ developers will be familiar with. All of the BaseCommand_ functionality is prese
 
 :big:`Basic Example`
 
-:class:`~django_typer.management.TyperCommand` is a very simple drop in replacement for
-BaseCommand_. All of the documented features of BaseCommand_ work the same way! Or, you may also
-use an interface identical to Typer_'s. Simply import Typer_ from django_typer instead of typer.
+:class:`~django_typer.management.TyperCommand` is a drop in extension to BaseCommand_. All of the
+documented features of BaseCommand_ work the same way! Or, you may also use an interface identical
+to Typer_'s. Simply import Typer_ from django_typer instead of typer.
 
 .. tabs::
 

doc/source/refs.rst

@@ -13,7 +13,6 @@
 .. _fish: https://fishshell.com/
 .. _zsh: https://www.zsh.org/
 .. _bash: https://www.gnu.org/software/bash/
-.. _typing_extensions: https://pypi.org/project/typing-extensions/
 .. _Arguments: https://typer.tiangolo.com/tutorial/arguments/
 .. _Options: https://typer.tiangolo.com/tutorial/options/
 .. _call_command: https://docs.djangoproject.com/en/5.0/ref/django-admin/#running-management-commands-from-your-code

doc/source/tutorial.rst

@@ -181,12 +181,6 @@ markup the docstring may be the more appropriate place to put it.
 
 |
 
-.. note::
-
-    On Python <=3.8 you will need to import Annotated from typing_extensions_ instead of the standard
-    library.
-
-
 Defining custom and reusable parameter types
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~