Skip to content

Commit 84144e4

Browse files
committed
ICM: Timeout tests added.
1 parent a9ee656 commit 84144e4

File tree

4 files changed

+25
-1
lines changed

4 files changed

+25
-1
lines changed

src/WithoutOverlapping.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public function setMutexStrategy($strategy)
3737

3838
public function getMutexTimeout()
3939
{
40-
return (isset($this->mutexTimeout) ? $this->mutexTimeout : 0);
40+
return (property_exists($this, 'mutexTimeout') ? $this->mutexTimeout : 0);
4141
}
4242

4343
public function setMutexTimeout($timeout)

tests/WithoutOverlappingTraitTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,12 @@ public function mutex_timeout_can_be_overloaded_by_protected_field()
3535
$this->assertEquals(3000, (new TimeoutCommand)->getMutexTimeout());
3636
}
3737

38+
/** @test */
39+
public function mutex_timeout_can_be_set_to_null_by_protected_field()
40+
{
41+
$this->assertNull((new NullTimeoutCommand)->getMutexTimeout());
42+
}
43+
3844
/** @test */
3945
public function it_generates_mutex_name_based_on_the_command_name_and_arguments()
4046
{
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?php
2+
3+
use Illuminate\Console\Command;
4+
use Illuminated\Console\WithoutOverlapping;
5+
6+
class NullTimeoutCommand extends Command
7+
{
8+
use WithoutOverlapping;
9+
10+
protected $signature = 'icm:null-timeout-command';
11+
protected $mutexTimeout = null;
12+
13+
public function handle()
14+
{
15+
$this->info('Done!');
16+
}
17+
}

tests/fixture/app/Console/Kernel.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ class Kernel extends \Orchestra\Testbench\Console\Kernel
55
protected $commands = [
66
GenericCommand::class,
77
MysqlStrategyCommand::class,
8+
NullTimeoutCommand::class,
89
TimeoutCommand::class,
910
];
1011
}

0 commit comments

Comments
 (0)