Skip to content

Commit 6199b1d

Browse files
RomanBachaloSigmaSoftwareRomanBachaloSigmaSoftware
committed
updated tests to use env variables
1 parent 580b697 commit 6199b1d

File tree

9 files changed

+147
-86
lines changed

9 files changed

+147
-86
lines changed

‎.github/workflows/node.js.yml‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
2+
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-nodejs
3+
4+
name: Node.js CI
5+
6+
on:
7+
push:
8+
branches: [ "master" ]
9+
pull_request:
10+
branches: [ "master" ]
11+
12+
jobs:
13+
build:
14+
15+
runs-on: ubuntu-latest
16+
17+
strategy:
18+
matrix:
19+
node-version: [14.x, 16.x, 18.x]
20+
21+
steps:
22+
- uses: actions/checkout@v3
23+
- name: Use Node.js ${{ matrix.node-version }}
24+
uses: actions/setup-node@v3
25+
with:
26+
node-version: ${{ matrix.node-version }}
27+
cache: 'npm'
28+
29+
- name: Run clean install
30+
run: npm ci
31+
32+
- name: Run build
33+
run: npm run build --if-present
34+
35+
- name: Run tests
36+
run: npm test
37+
env:
38+
CLIENT_ID: ${{ secrets.CLIENT_ID }}
39+
USER_ID: ${{ secrets.USER_ID }}
40+
APP_URL: ${{ secrets.APP_URL }}
41+
SIGNER_EMAIL: ${{ secrets.SIGNER_EMAIL }}
42+
SIGNER_NAME: ${{ secrets.SIGNER_NAME }}
43+
PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}

‎test/accountTests.js‎

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ const chaiExclude = require('chai-exclude');
55
const expect = chai.expect;
66
const should = chai.should();
77

8-
const settings = require('../config/appsettings.json');
98
const { createBrand } = require('../lib/eSignature/examples/createBrand');
109
const {
1110
applyBrandToEnvelope,
@@ -14,7 +13,7 @@ const {
1413
getBrands
1514
} = require('../lib/eSignature/examples/applyBrandToEnvelope');
1615
const { createPermission } = require('../lib/eSignature/examples/createPermission');
17-
const { TEST_TIMEOUT_MS, authenticate } = require('./testHelpers');
16+
const { TEST_TIMEOUT_MS, authenticate, config } = require('./testHelpers');
1817

1918
const {
2019
TEST_PDF_FILE,
@@ -69,8 +68,8 @@ describe ('AccountsApi tests:', function() {
6968
this.timeout(TEST_TIMEOUT_MS);
7069

7170
const envelopeArgs = {
72-
signerEmail: settings.signerEmail,
73-
signerName: settings.signerName,
71+
signerEmail: config.signerEmail,
72+
signerName: config.signerName,
7473
brandId: BRAND_ID,
7574
status: "sent",
7675
doc2File: path.resolve(TEST_DOCX_FILE),
@@ -92,8 +91,8 @@ describe ('AccountsApi tests:', function() {
9291
this.timeout(TEST_TIMEOUT_MS);
9392

9493
const envelopeArgs = {
95-
signerEmail: settings.signerEmail,
96-
signerName: settings.signerName,
94+
signerEmail: config.signerEmail,
95+
signerName: config.signerName,
9796
brandId: BRAND_ID,
9897
status: "sent",
9998
doc2File: path.resolve(TEST_DOCX_FILE),
@@ -112,8 +111,8 @@ describe ('AccountsApi tests:', function() {
112111
<h2 style="font-family: 'Trebuchet MS', Helvetica, sans-serif;
113112
margin-top: 0px;margin-bottom: 3.5em;font-size: 1em;
114113
color: darkblue;">Order Processing Division</h2>
115-
<h4>Ordered by ${settings.signerName}</h4>
116-
<p style="margin-top:0em; margin-bottom:0em;">Email: ${settings.signerEmail}</p>
114+
<h4>Ordered by ${config.signerName}</h4>
115+
<p style="margin-top:0em; margin-bottom:0em;">Email: ${config.signerEmail}</p>
117116
<p style="margin-top:3em;">
118117
Candy bonbon pastry jujubes lollipop wafer biscuit biscuit. Topping brownie sesame snaps sweet roll pie. Croissant danish biscuit soufflé caramels jujubes jelly. Dragée danish caramels lemon drops dragée. Gummi bears cupcake biscuit tiramisu sugar plum pastry. Dragée gummies applicake pudding liquorice. Donut jujubes oat cake jelly-o. Dessert bear claw chocolate cake gummies lollipop sugar plum ice cream gummies cheesecake.
119118
</p>
@@ -148,8 +147,8 @@ describe ('AccountsApi tests:', function() {
148147
recipients: {
149148
signers: [
150149
{
151-
email: settings.signerEmail,
152-
name: settings.signerName,
150+
email: config.signerEmail,
151+
name: config.signerName,
153152
recipientId: '1',
154153
routingOrder: '1',
155154
tabs: {
@@ -185,8 +184,8 @@ describe ('AccountsApi tests:', function() {
185184
this.timeout(TEST_TIMEOUT_MS);
186185

187186
const args = {
188-
signerEmail: settings.signerEmail,
189-
signerName: settings.signerName,
187+
signerEmail: config.signerEmail,
188+
signerName: config.signerName,
190189
brandId: BRAND_ID,
191190
status: "sent",
192191
doc2File: path.resolve(TEST_DOCX_FILE),
@@ -205,8 +204,8 @@ describe ('AccountsApi tests:', function() {
205204
<h2 style="font-family: 'Trebuchet MS', Helvetica, sans-serif;
206205
margin-top: 0px;margin-bottom: 3.5em;font-size: 1em;
207206
color: darkblue;">Order Processing Division</h2>
208-
<h4>Ordered by ${settings.signerName}</h4>
209-
<p style="margin-top:0em; margin-bottom:0em;">Email: ${settings.signerEmail}</p>
207+
<h4>Ordered by ${config.signerName}</h4>
208+
<p style="margin-top:0em; margin-bottom:0em;">Email: ${config.signerEmail}</p>
210209
<p style="margin-top:3em;">
211210
Candy bonbon pastry jujubes lollipop wafer biscuit biscuit. Topping brownie sesame snaps sweet roll pie. Croissant danish biscuit soufflé caramels jujubes jelly. Dragée danish caramels lemon drops dragée. Gummi bears cupcake biscuit tiramisu sugar plum pastry. Dragée gummies applicake pudding liquorice. Donut jujubes oat cake jelly-o. Dessert bear claw chocolate cake gummies lollipop sugar plum ice cream gummies cheesecake.
212211
</p>

‎test/bulkEnvelopesTests.js‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ const chai = require('chai');
33
const chaiExclude = require('chai-exclude');
44
const should = chai.should();
55

6-
const settings = require('../config/appsettings.json');
76
const { bulkSendEnvelopes } = require('../lib/eSignature/examples/bulkSendEnvelope');
8-
const { TEST_TIMEOUT_MS, authenticate } = require('./testHelpers');
7+
const { TEST_TIMEOUT_MS, authenticate, config } = require('./testHelpers');
98

109
const {
1110
TEST_PDF_FILE,
@@ -41,8 +40,8 @@ describe ('BulkEnvelopesApi tests:', function() {
4140

4241
const list1 = {
4342
signer: {
44-
name: settings.signerName,
45-
email: settings.signerEmail,
43+
name: config.signerName,
44+
email: config.signerEmail,
4645
},
4746
cc: {
4847
name: CC_NAME,

‎test/clickTests.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ const chaiExclude = require('chai-exclude');
55
const expect = chai.expect;
66
const should = chai.should();
77

8-
const settings = require('../config/appsettings.json');
98
const { createClickwrap } = require('../lib/click/examples/createClickwrap');
109
const {
1110
getInactiveClickwraps,

‎test/constants.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
const settings = require('../config/appsettings.json')
1+
const config = require('./testConfig').getConfiguration();
22

33
const signerClientId = '1000';
4-
const returnUrl = settings.appUrl + "/ds-return";
5-
const pingUrl = settings.appUrl + "/";
4+
const returnUrl = config.appUrl + "/ds-return";
5+
const pingUrl = config.appUrl + "/";
66
const PRIVATE_KEY_FILENAME = "../config/private.key";
77
const BASE_PATH = 'https://demo.docusign.net/restapi';
88
const CLICK_BASE_PATH = 'https://demo.docusign.net/clickapi';

‎test/envelopeTests.js‎

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ const chaiExclude = require('chai-exclude');
55
const expect = chai.expect;
66
const should = chai.should();
77

8-
const settings = require('../config/appsettings.json');
98
const {
109
sendEnvelopeForEmbeddedSigning,
1110
makeEnvelope: makeEnvelopeForEmbeddedSigning,
@@ -16,7 +15,7 @@ const {
1615
makeEnvelope: makeEnvelopeForSigningViaEmail,
1716
document1
1817
} = require('../lib/eSignature/examples/signingViaEmail')
19-
const { TEST_TIMEOUT_MS, authenticate } = require('./testHelpers');
18+
const { TEST_TIMEOUT_MS, authenticate, config } = require('./testHelpers');
2019

2120
const {
2221
signerClientId,
@@ -51,8 +50,8 @@ describe ('EnvelopesApi tests:', function() {
5150
this.timeout(TEST_TIMEOUT_MS);
5251

5352
const envelopeArgs = {
54-
signerEmail: settings.signerEmail,
55-
signerName: settings.signerName,
53+
signerEmail: config.signerEmail,
54+
signerName: config.signerName,
5655
signerClientId: signerClientId,
5756
dsReturnUrl: returnUrl,
5857
dsPingUrl: pingUrl,
@@ -75,8 +74,8 @@ describe ('EnvelopesApi tests:', function() {
7574
this.timeout(TEST_TIMEOUT_MS);
7675

7776
const envelopeArgs = {
78-
signerEmail: settings.signerEmail,
79-
signerName: settings.signerName,
77+
signerEmail: config.signerEmail,
78+
signerName: config.signerName,
8079
signerClientId: signerClientId,
8180
dsReturnUrl: returnUrl,
8281
dsPingUrl: pingUrl,
@@ -96,8 +95,8 @@ describe ('EnvelopesApi tests:', function() {
9695
recipients: {
9796
signers: [
9897
{
99-
email: settings.signerEmail,
100-
name: settings.signerName,
98+
email: config.signerEmail,
99+
name: config.signerName,
101100
clientUserId: signerClientId,
102101
recipientId: '1',
103102
tabs: {
@@ -126,8 +125,8 @@ describe ('EnvelopesApi tests:', function() {
126125
this.timeout(TEST_TIMEOUT_MS);
127126

128127
const envelopeArgs = {
129-
signerEmail: settings.signerEmail,
130-
signerName: settings.signerName,
128+
signerEmail: config.signerEmail,
129+
signerName: config.signerName,
131130
signerClientId: signerClientId,
132131
dsReturnUrl: returnUrl,
133132
dsPingUrl: pingUrl,
@@ -136,8 +135,8 @@ describe ('EnvelopesApi tests:', function() {
136135
const expected = {
137136
returnUrl: `${returnUrl}?state=123`,
138137
authenticationMethod: 'none',
139-
email: settings.signerEmail,
140-
userName: settings.signerName,
138+
email: config.signerEmail,
139+
userName: config.signerName,
141140
clientUserId: signerClientId,
142141
pingFrequency: 600,
143142
pingUrl: pingUrl
@@ -153,8 +152,8 @@ describe ('EnvelopesApi tests:', function() {
153152
this.timeout(TEST_TIMEOUT_MS);
154153

155154
const envelopeArgs = {
156-
signerEmail: settings.signerEmail,
157-
signerName: settings.signerName,
155+
signerEmail: config.signerEmail,
156+
signerName: config.signerName,
158157
ccEmail: CC_EMAIL,
159158
ccName: CC_NAME,
160159
status: 'sent',
@@ -188,8 +187,8 @@ describe ('EnvelopesApi tests:', function() {
188187
<h2 style="font-family: 'Trebuchet MS', Helvetica, sans-serif;
189188
margin-top: 0px;margin-bottom: 3.5em;font-size: 1em;
190189
color: darkblue;">Order Processing Division</h2>
191-
<h4>Ordered by ${settings.signerName}</h4>
192-
<p style="margin-top:0em; margin-bottom:0em;">Email: ${settings.signerEmail}</p>
190+
<h4>Ordered by ${config.signerName}</h4>
191+
<p style="margin-top:0em; margin-bottom:0em;">Email: ${config.signerEmail}</p>
193192
<p style="margin-top:0em; margin-bottom:0em;">Copy to: ${CC_NAME}, ${CC_EMAIL}</p>
194193
<p style="margin-top:3em;">
195194
Candy bonbon pastry jujubes lollipop wafer biscuit biscuit. Topping brownie sesame snaps sweet roll pie. Croissant danish biscuit soufflé caramels jujubes jelly. Dragée danish caramels lemon drops dragée. Gummi bears cupcake biscuit tiramisu sugar plum pastry. Dragée gummies applicake pudding liquorice. Donut jujubes oat cake jelly-o. Dessert bear claw chocolate cake gummies lollipop sugar plum ice cream gummies cheesecake.
@@ -201,8 +200,8 @@ describe ('EnvelopesApi tests:', function() {
201200
`;
202201

203202
const envelopeArgs = {
204-
signerEmail: settings.signerEmail,
205-
signerName: settings.signerName,
203+
signerEmail: config.signerEmail,
204+
signerName: config.signerName,
206205
ccEmail: CC_EMAIL,
207206
ccName: CC_NAME,
208207
status: 'sent',
@@ -235,8 +234,8 @@ describe ('EnvelopesApi tests:', function() {
235234
recipients: {
236235
signers: [
237236
{
238-
email: settings.signerEmail,
239-
name: settings.signerName,
237+
email: config.signerEmail,
238+
name: config.signerName,
240239
recipientId: '1',
241240
routingOrder: '1',
242241
tabs: {
@@ -279,8 +278,8 @@ describe ('EnvelopesApi tests:', function() {
279278
this.timeout(TEST_TIMEOUT_MS);
280279

281280
const envelopeArgs = {
282-
signerEmail: settings.signerEmail,
283-
signerName: settings.signerName,
281+
signerEmail: config.signerEmail,
282+
signerName: config.signerName,
284283
ccEmail: CC_EMAIL,
285284
ccName: CC_NAME,
286285
};
@@ -297,8 +296,8 @@ describe ('EnvelopesApi tests:', function() {
297296
<h2 style="font-family: 'Trebuchet MS', Helvetica, sans-serif;
298297
margin-top: 0px;margin-bottom: 3.5em;font-size: 1em;
299298
color: darkblue;">Order Processing Division</h2>
300-
<h4>Ordered by ${settings.signerName}</h4>
301-
<p style="margin-top:0em; margin-bottom:0em;">Email: ${settings.signerEmail}</p>
299+
<h4>Ordered by ${config.signerName}</h4>
300+
<p style="margin-top:0em; margin-bottom:0em;">Email: ${config.signerEmail}</p>
302301
<p style="margin-top:0em; margin-bottom:0em;">Copy to: ${CC_NAME}, ${CC_EMAIL}</p>
303302
<p style="margin-top:3em;">
304303
Candy bonbon pastry jujubes lollipop wafer biscuit biscuit. Topping brownie sesame snaps sweet roll pie. Croissant danish biscuit soufflé caramels jujubes jelly. Dragée danish caramels lemon drops dragée. Gummi bears cupcake biscuit tiramisu sugar plum pastry. Dragée gummies applicake pudding liquorice. Donut jujubes oat cake jelly-o. Dessert bear claw chocolate cake gummies lollipop sugar plum ice cream gummies cheesecake.
@@ -312,8 +311,8 @@ describe ('EnvelopesApi tests:', function() {
312311
const document = await document1(envelopeArgs);
313312

314313
should.exist(document);
315-
expect(document).to.contain(settings.signerEmail);
316-
expect(document).to.contain(settings.signerName);
314+
expect(document).to.contain(config.signerEmail);
315+
expect(document).to.contain(config.signerName);
317316
expect(document).to.contain(CC_EMAIL);
318317
expect(document).to.contain(CC_NAME);
319318
expect(document).to.be.equal(expected);

0 commit comments

Comments
 (0)