fixes for linter

Author: annahileta

src/Controllers/ConnectedFieldsApiBaseController.php

@@ -33,7 +33,7 @@ abstract protected function getTemplateArgs(): array;
      * @param null $eg
      * @return void
      */
-    public function controller($eg = null, $args = null): void
+    public function controller($args = null): void
     {
         if (empty($eg)) {
             $eg = static::EG;
@@ -44,7 +44,6 @@ public function controller($eg = null, $args = null): void
 
         if ($this->isMethodGet()) {
             $this->getController(
-                $eg,
                 $args,
                 basename(static::FILE)
             );
@@ -67,8 +66,7 @@ public function controller($eg = null, $args = null): void
      * @return void
      */
     protected function getController(
-        $eg,
-        $args = null,
+        $args,
         ?string $basename
     ): void {
         if ($this->isHomePage(static::EG)) {
@@ -77,7 +75,7 @@ protected function getController(
                 'show_doc' => false,
                 'common_texts' => $this->getCommonText()
             ]);
-        } else { 
+        } else {
             $currentAPI = ManifestService::getAPIByLink(static::EG);
             if ($this->routerService->dsTokenOk() && $currentAPI === $_SESSION['api_type']) {
                 $displayOptions = [

src/Controllers/Examples/ConnectedFields/Cf001SetConnectedFields.php

@@ -40,7 +40,7 @@ public function __construct()
             );
         } else {
             $_SESSION["apps"] = $filteredAppsJson;
-            parent::controller(null, ['apps' => $filteredAppsJson]);
+            parent::controller(['apps' => $filteredAppsJson]);
         }
     }
 
@@ -105,7 +105,7 @@ private function getAppById(string $selectedAppId): array
      * @return array
      */
     public function getTemplateArgs(): array
-    {   
+    {
         return [
             'signer_email' => $this->checkInputValues($_POST['signer_email']),
             'signer_name' => $this->checkInputValues($_POST['signer_name']),

src/Services/Examples/ConnectedFields/SetConnectedFieldsService.php

@@ -49,10 +49,9 @@ public static function filterData(array $data): string
             }
 
             foreach ($item['tabs'] as $tab) {
-                if (
-                    (isset($tab['extensionData']['actionContract']) && str_contains($tab['extensionData']['actionContract'], "Verify")) ||
-                    (isset($tab['tabLabel']) && str_contains($tab['tabLabel'], "connecteddata"))
-                ) {
+                if ((isset($tab['extensionData']['actionContract'])
+                        && str_contains($tab['extensionData']['actionContract'], "Verify")) ||
+                    (isset($tab['tabLabel']) && str_contains($tab['tabLabel'], "connecteddata"))) {
                     return true;
                 }
             }
@@ -85,15 +84,17 @@ public static function sendEnvelope(
             $signerName,
             $signerEmail,
             $pdfDoc,
-            $demoPath);
+            $demoPath
+        );
 
         $options = new \DocuSign\eSign\Api\EnvelopesApi\CreateEnvelopeOptions();
         $results = $envelopesApi->createEnvelope($accountId, $envelope, $options);
 
         return $results->getEnvelopeId();
     }
 
-    public static function makeEnvelopes($app, $signerName, $signerEmail, $pdfDoc, $demoPath): EnvelopeDefinition {
+    public static function makeEnvelopes($app, $signerName, $signerEmail, $pdfDoc, $demoPath): EnvelopeDefinition
+    {
         $appId = $app['appId'] ?? null;
         $extensionGroupId = $app['tabs'][0]['extensionData']['extensionGroupId'] ?? null;
         $publisherName = $app['tabs'][0]['extensionData']['publisherName'] ?? null;
@@ -194,4 +195,3 @@ public static function makeEnvelopes($app, $signerName, $signerEmail, $pdfDoc, $
         return $envelope;
     }
 }
-