Skip to content
This repository was archived by the owner on Dec 11, 2022. It is now read-only.

Commit 50f4123

Browse files
author
Tamir Klein
authored
Merge pull request #266 from doitintl/queryBuilder_metric
Query builder metric
2 parents 2b65112 + 255aaa3 commit 50f4123

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

dist/module.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/module.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/bigquery_query.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export default class BigQueryQuery {
247247
return (
248248
"CAST (" +
249249
BigQueryQuery.quoteFiledName(this.target.metricColumn) +
250-
"AS String ) AS metric"
250+
" AS String ) AS metric"
251251
);
252252
}
253253

src/specs/bigquery_query.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ describe("BigQueryQuery", () => {
5252
const query = new BigQueryQuery({}, templateSrv);
5353
expect(query.buildMetricColumn()).toBe("");
5454
query.target.metricColumn = "host";
55-
expect(query.buildMetricColumn()).toBe("CAST (`host`AS String ) AS metric");
55+
expect(query.buildMetricColumn()).toBe("CAST (`host` AS String ) AS metric");
5656
query.target.metricColumn = '"host"';
57-
expect(query.buildMetricColumn()).toBe( "CAST (`\"host\"`AS String ) AS metric");
57+
expect(query.buildMetricColumn()).toBe( "CAST (`\"host\"` AS String ) AS metric");
5858
});
5959

6060
describe("When generating value column SQL", () => {
@@ -225,7 +225,7 @@ describe("BigQueryQuery", () => {
225225

226226
query.target.metricColumn = "m";
227227
result =
228-
"#standardSQL\nSELECT\n `t` AS time,\n CAST (`m`AS String ) AS metric,\n `value`\nFROM `undefined.undefined.table`\nGROUP BY 1,2,3 \nORDER BY 1,2";
228+
"#standardSQL\nSELECT\n `t` AS time,\n CAST (`m` AS String ) AS metric,\n `value`\nFROM `undefined.undefined.table`\nGROUP BY 1,2,3 \nORDER BY 1,2";
229229
expect(query.buildQuery()).toBe(result);
230230
});
231231

0 commit comments

Comments
 (0)