Math.round causes overflow in timegroups, we should ceil instead

ptomasroos · ptomasroos · commit a1f5fba47ebe · 2020-04-22T08:09:51.000+02:00
diff --git a/src/bigquery_query.ts b/src/bigquery_query.ts
@@ -693,7 +693,7 @@ export default class BigQueryQuery {
     const seconds =
       (this.templateSrv.timeRange.to._d - this.templateSrv.timeRange.from._d) /
       1000;
-    return Math.round(seconds / options.maxDataPoints) + "s";
+    return Math.ceil(seconds / options.maxDataPoints) + "s";
   }
   private _getDateRangePart(part) {
     if (this.target.timeColumnType === "DATE") {

Original file line number	Diff line number	Diff line change
`@@ -693,7 +693,7 @@ export default class BigQueryQuery {`
`693`	`693`	`const seconds =`
`694`	`694`	`(this.templateSrv.timeRange.to._d - this.templateSrv.timeRange.from._d) /`
`695`	`695`	`1000;`
`696`		`- return Math.round(seconds / options.maxDataPoints) + "s";`
	`696`	`+ return Math.ceil(seconds / options.maxDataPoints) + "s";`
`697`	`697`	`}`
`698`	`698`	`private _getDateRangePart(part) {`
`699`	`699`	`if (this.target.timeColumnType === "DATE") {`