Skip to content
This repository was archived by the owner on Dec 11, 2022. It is now read-only.

Commit bf6c8a4

Browse files
authored
ResponseParser: Do not conver null values to 0
Merge pull request #347 from dprokop/handle-null-values
2 parents 4504971 + f36716d commit bf6c8a4

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/response_parser.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ export default class ResponseParser {
172172
targetName = metricName;
173173
}
174174
const bucket = ResponseParser.findOrCreateBucket(data, targetName, metricName);
175-
bucket.datapoints.push([Number(row.f[valueIndexes[i]].v), epoch]);
175+
const value = row.f[valueIndexes[i]].v === null ? null : Number(row.f[valueIndexes[i]].v)
176+
bucket.datapoints.push([value, epoch]);
176177
}
177178
}
178179
}

src/specs/datasource.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,7 +1097,7 @@ describe('BigQueryDatasource', () => {
10971097
v: '1.521578851E9',
10981098
},
10991099
{
1100-
v: '37.7753058',
1100+
v: null,
11011101
},
11021102
],
11031103
},
@@ -1130,7 +1130,7 @@ describe('BigQueryDatasource', () => {
11301130
results = ResponseParser.parseDataQuery(response, 'time_series');
11311131
it('should return a time_series', () => {
11321132
expect(results[0].datapoints.length).toBe(3);
1133-
expect(results[0].datapoints[0][0]).toBe(37.7753058);
1133+
expect(results[0].datapoints[0][0]).toBe(null);
11341134
expect(results[0].datapoints[0][1]).toBe(1521578851000);
11351135
expect(results[0].datapoints[2][0]).toBe(37.781752);
11361136
expect(results[0].datapoints[2][1]).toBe(1521578927000);

0 commit comments

Comments
 (0)