Skip to content
This repository was archived by the owner on Dec 11, 2022. It is now read-only.

Commit ca6bb85

Browse files
committed
more test casse
1 parent bc84784 commit ca6bb85

File tree

6 files changed

+242
-176
lines changed

6 files changed

+242
-176
lines changed

dist/module.js

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33620,11 +33620,11 @@ function () {
3362033620
this.interpolateQueryStr = this.interpolateQueryStr.bind(this);
3362133621
}
3362233622

33623-
BigQueryQuery.prototype.quoteLiteral = function (value) {
33623+
BigQueryQuery.quoteLiteral = function (value) {
3362433624
return "'" + String(value).replace(/'/g, "''") + "'";
3362533625
};
3362633626

33627-
BigQueryQuery.prototype.escapeLiteral = function (value) {
33627+
BigQueryQuery.escapeLiteral = function (value) {
3362833628
return String(value).replace(/'/g, "''");
3362933629
};
3363033630

@@ -33641,14 +33641,14 @@ function () {
3364133641
BigQueryQuery.prototype.interpolateQueryStr = function (value, variable, defaultFormatFn) {
3364233642
// if no multi or include all do not regexEscape
3364333643
if (!variable.multi && !variable.includeAll) {
33644-
return this.escapeLiteral(value);
33644+
return BigQueryQuery.escapeLiteral(value);
3364533645
}
3364633646

3364733647
if (typeof value === 'string') {
33648-
return this.quoteLiteral(value);
33648+
return BigQueryQuery.quoteLiteral(value);
3364933649
}
3365033650

33651-
var escapedValues = _lodash2.default.map(value, this.quoteLiteral);
33651+
var escapedValues = _lodash2.default.map(value, BigQueryQuery.quoteLiteral);
3365233652

3365333653
return escapedValues.join(',');
3365433654
};
@@ -34153,8 +34153,6 @@ var BigQueryDatasource =
3415334153
function () {
3415434154
/** @ngInject */
3415534155
function BigQueryDatasource(instanceSettings, backendSrv, $q, templateSrv, timeSrv) {
34156-
var _this = this;
34157-
3415834156
this.backendSrv = backendSrv;
3415934157
this.$q = $q;
3416034158
this.templateSrv = templateSrv;
@@ -34163,7 +34161,7 @@ function () {
3416334161
this.interpolateVariable = function (value, variable) {
3416434162
if (typeof value === 'string') {
3416534163
if (variable.multi || variable.includeAll) {
34166-
return _this.queryModel.quoteLiteral(value);
34164+
return _bigquery_query2.default.quoteLiteral(value);
3416734165
} else {
3416834166
return value;
3416934167
}
@@ -34174,7 +34172,7 @@ function () {
3417434172
}
3417534173

3417634174
var quotedValues = _lodash2.default.map(value, function (v) {
34177-
return _this.queryModel.quoteLiteral(v);
34175+
return _bigquery_query2.default.quoteLiteral(v);
3417834176
});
3417934177

3418034178
return quotedValues.join(',');
@@ -34503,6 +34501,8 @@ function () {
3450334501
return tslib_1.__generator(this, function (_a) {
3450434502
switch (_a.label) {
3450534503
case 0:
34504+
status = 'error';
34505+
message = 'BigQuery: ';
3450634506
defaultErrorMessage = 'Cannot connect to BigQuery API';
3450734507
_a.label = 1;
3450834508

@@ -34525,9 +34525,8 @@ function () {
3452534525

3452634526
if (response.status === 200) {
3452734527
status = 'success';
34528-
message = 'Successfully queried the BigQuery API.';
34528+
message += 'Successfully queried the BigQuery API.';
3452934529
} else {
34530-
status = 'error';
3453134530
message = response.statusText ? response.statusText : defaultErrorMessage;
3453234531
}
3453334532

@@ -34537,8 +34536,6 @@ function () {
3453734536

3453834537
case 4:
3453934538
error_2 = _a.sent();
34540-
status = 'error';
34541-
message = 'BigQuery: ';
3454234539
message += error_2.statusText ? error_2.statusText : defaultErrorMessage;
3454334540

3454434541
if (error_2.data && error_2.data.error && error_2.data.error.code) {

dist/module.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/bigquery_query.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ export default class BigQueryQuery {
3535
this.interpolateQueryStr = this.interpolateQueryStr.bind(this);
3636
}
3737

38-
quoteLiteral(value) {
38+
static quoteLiteral(value) {
3939
return "'" + String(value).replace(/'/g, "''") + "'";
4040
}
4141

42-
escapeLiteral(value) {
42+
static escapeLiteral(value) {
4343
return String(value).replace(/'/g, "''");
4444
}
4545

@@ -54,14 +54,14 @@ export default class BigQueryQuery {
5454
interpolateQueryStr(value, variable, defaultFormatFn) {
5555
// if no multi or include all do not regexEscape
5656
if (!variable.multi && !variable.includeAll) {
57-
return this.escapeLiteral(value);
57+
return BigQueryQuery.escapeLiteral(value);
5858
}
5959

6060
if (typeof value === 'string') {
61-
return this.quoteLiteral(value);
61+
return BigQueryQuery.quoteLiteral(value);
6262
}
6363

64-
const escapedValues = _.map(value, this.quoteLiteral);
64+
const escapedValues = _.map(value, BigQueryQuery.quoteLiteral);
6565
return escapedValues.join(',');
6666
}
6767

src/datasource.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ export class BigQueryDatasource {
112112
interpolateVariable = (value, variable) => {
113113
if (typeof value === 'string') {
114114
if (variable.multi || variable.includeAll) {
115-
return this.queryModel.quoteLiteral(value);
115+
return BigQueryQuery.quoteLiteral(value);
116116
} else {
117117
return value;
118118
}
@@ -123,7 +123,7 @@ export class BigQueryDatasource {
123123
}
124124

125125
const quotedValues = _.map(value, v => {
126-
return this.queryModel.quoteLiteral(v);
126+
return BigQueryQuery.quoteLiteral(v);
127127
});
128128
return quotedValues.join(',');
129129
}
@@ -223,21 +223,20 @@ export class BigQueryDatasource {
223223

224224
async testDatasource() {
225225
let status, message;
226+
status = 'error';
227+
message = 'BigQuery: ';
226228
const defaultErrorMessage = 'Cannot connect to BigQuery API';
227229
try {
228230
const projectName = await this.getDefaultProject();
229231
const path = `v2/projects/${projectName}/datasets`;
230232
const response = await this.doRequest(`${this.baseUrl}${path}`);
231233
if (response.status === 200) {
232234
status = 'success';
233-
message = 'Successfully queried the BigQuery API.';
235+
message += 'Successfully queried the BigQuery API.';
234236
} else {
235-
status = 'error';
236237
message = response.statusText ? response.statusText : defaultErrorMessage;
237238
}
238239
} catch (error) {
239-
status = 'error';
240-
message = 'BigQuery: ';
241240
message += error.statusText ? error.statusText : defaultErrorMessage;
242241
if (error.data && error.data.error && error.data.error.code) {
243242
message += ': ' + error.data.error.code + '. ' + error.data.error.message;

0 commit comments

Comments
 (0)