Skip to content
This repository was archived by the owner on Dec 11, 2022. It is now read-only.

Commit f880268

Browse files
authored
Merge pull request #24 from doitintl/avivl/some-refactors
Refactor response parser
2 parents 505aaa7 + 59dd8d5 commit f880268

File tree

3 files changed

+59
-69
lines changed

3 files changed

+59
-69
lines changed

dist/module.js

Lines changed: 34 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -35772,58 +35772,50 @@ function () {
3577235772
this.$q = $q;
3577335773
}
3577435774

35775-
ResponseParser.parseProjects = function (results) {
35776-
var projects = [];
35775+
ResponseParser.parseData = function (results, text, value) {
35776+
var data = [];
3577735777

3577835778
if (!results || results.length === 0) {
35779-
return projects;
35779+
return data;
3578035780
}
3578135781

35782-
for (var _i = 0, results_1 = results; _i < results_1.length; _i++) {
35783-
var prj = results_1[_i];
35784-
projects.push({
35785-
text: prj.id,
35786-
value: prj.id
35787-
});
35788-
}
35782+
var objectTextList = text.split(".");
35783+
var objectValueList = value.split(".");
35784+
var itemValue, itemText;
3578935785

35790-
return projects;
35791-
};
35786+
for (var _i = 0, results_1 = results; _i < results_1.length; _i++) {
35787+
var item = results_1[_i];
35788+
itemText = item[objectTextList[0]];
35789+
itemValue = item[objectValueList[0]];
3579235790

35793-
ResponseParser.parseDatasets = function (results) {
35794-
var datasets = [];
35791+
for (var i = 1; i < objectTextList.length; i++) {
35792+
itemText = itemText[objectTextList[i]];
35793+
}
3579535794

35796-
if (!results || results.length === 0) {
35797-
return datasets;
35798-
}
35795+
for (var i = 1; i < objectValueList.length; i++) {
35796+
itemValue = itemValue[objectValueList[i]];
35797+
}
3579935798

35800-
for (var _i = 0, results_2 = results; _i < results_2.length; _i++) {
35801-
var ds = results_2[_i];
35802-
datasets.push({
35803-
value: ds.datasetReference.datasetId,
35804-
text: ds.datasetReference.datasetId
35799+
data.push({
35800+
text: itemText,
35801+
value: itemValue
3580535802
});
35806-
}
35803+
} //console.log(data)
3580735804

35808-
return datasets;
35809-
};
3581035805

35811-
ResponseParser.prototype.parseTabels = function (results) {
35812-
var tables = [];
35806+
return data;
35807+
};
3581335808

35814-
if (!results || results.length === 0) {
35815-
return tables;
35816-
}
35809+
ResponseParser.parseProjects = function (results) {
35810+
return ResponseParser.parseData(results, "id", "id");
35811+
};
3581735812

35818-
for (var _i = 0, results_3 = results; _i < results_3.length; _i++) {
35819-
var tbl = results_3[_i];
35820-
tables.push({
35821-
value: tbl.tableReference.tableId,
35822-
text: tbl.tableReference.tableId
35823-
});
35824-
}
35813+
ResponseParser.parseDatasets = function (results) {
35814+
return ResponseParser.parseData(results, "datasetReference.datasetId", "datasetReference.datasetId");
35815+
};
3582535816

35826-
return this._handelWildCardTables(tables);
35817+
ResponseParser.prototype.parseTabels = function (results) {
35818+
return this._handelWildCardTables(ResponseParser.parseData(results, "tableReference.tableId", "tableReference.tableId"));
3582735819
};
3582835820

3582935821
ResponseParser.prototype._handelWildCardTables = function (tables) {
@@ -35850,8 +35842,8 @@ function () {
3585035842
};
3585135843

3585235844
ResponseParser._handleRecordFileds = function (results, res) {
35853-
for (var _i = 0, results_4 = results; _i < results_4.length; _i++) {
35854-
var fl = results_4[_i];
35845+
for (var _i = 0, results_2 = results; _i < results_2.length; _i++) {
35846+
var fl = results_2[_i];
3585535847

3585635848
if (fl.type === "RECORD") {
3585735849
for (var _a = 0, _b = fl.fields; _a < _b.length; _a++) {
@@ -35892,8 +35884,8 @@ function () {
3589235884
var res = [];
3589335885
results = ResponseParser._handleRecordFileds(results, res);
3589435886

35895-
for (var _i = 0, results_5 = results; _i < results_5.length; _i++) {
35896-
var fl = results_5[_i];
35887+
for (var _i = 0, results_3 = results; _i < results_3.length; _i++) {
35888+
var fl = results_3[_i];
3589735889

3589835890
if (filter.length > 0) {
3589935891
for (var i = 0; i < filter.length; i++) {

dist/module.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/response_parser.ts

Lines changed: 24 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -19,41 +19,39 @@ export default class ResponseParser {
1919
constructor(private $q) {
2020
}
2121

22-
static parseProjects(results): ResultFormat[] {
23-
const projects: ResultFormat[] = [];
22+
static parseData(results, text, value): ResultFormat[] {
23+
const data: ResultFormat[] = [];
2424
if (!results || results.length === 0) {
25-
return projects;
26-
}
27-
for (let prj of results) {
28-
projects.push({text: prj.id, value: prj.id});
25+
return data;
26+
}
27+
let objectTextList = text.split(".");
28+
let objectValueList = value.split(".");
29+
let itemValue, itemText;
30+
for (let item of results) {
31+
itemText = item[objectTextList[0]];
32+
itemValue = item[objectValueList[0]];
33+
for (let i = 1; i < objectTextList.length; i++) {
34+
itemText = itemText[objectTextList[i]];
35+
}
36+
for (let i = 1; i < objectValueList.length; i++) {
37+
itemValue = itemValue[objectValueList[i]];
38+
}
39+
data.push({text: itemText, value: itemValue});
2940
}
30-
return projects;
41+
//console.log(data)
42+
return data;
43+
}
44+
static parseProjects(results): ResultFormat[] {
45+
return ResponseParser.parseData(results,"id" ,"id");
3146
}
3247

3348
static parseDatasets(results): ResultFormat[] {
34-
const datasets: ResultFormat[] = [];
35-
if (!results || results.length === 0) {
36-
return datasets;
37-
}
38-
for (let ds of results) {
39-
datasets.push({value: ds.datasetReference.datasetId, text: ds.datasetReference.datasetId});
40-
}
41-
return datasets;
49+
return ResponseParser.parseData(results,"datasetReference.datasetId" ,"datasetReference.datasetId");
4250
}
4351

4452

4553
parseTabels(results): ResultFormat[] {
46-
let tables: ResultFormat[] = [];
47-
if (!results || results.length === 0) {
48-
return tables;
49-
}
50-
for (let tbl of results) {
51-
tables.push({
52-
value: tbl.tableReference.tableId,
53-
text: tbl.tableReference.tableId
54-
});
55-
}
56-
return this._handelWildCardTables(tables);
54+
return this._handelWildCardTables(ResponseParser.parseData(results,"tableReference.tableId" ,"tableReference.tableId"));
5755
}
5856

5957
_handelWildCardTables(tables) {

0 commit comments

Comments
 (0)