Upgrades Dev Proxy to .NET 10. Closes #1445 (#1449)

* Upgrades Dev Proxy to .NET 10. Closes #1445

* Updates workflows to .NET 10

Author: waldekmastykarz

.editorconfig

@@ -236,6 +236,8 @@ dotnet_diagnostic.CA1303.severity = none
 dotnet_diagnostic.CA1308.severity = none
 # Avoid uninstantiated internal classes
 dotnet_diagnostic.CA1812.severity = none
+# Avoid potentially expensive logging
+dotnet_diagnostic.CA1873.severity = none
 # Use the LoggerMessage delegates
 dotnet_diagnostic.CA1848.severity = none
 # Possible multiple enumerations of IEnumerable collection

.github/workflows/codeql-analysis.yml

@@ -49,7 +49,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@2016bd2012dba4e32de620c46fe006a3ac9f0602 # v5.0.1
       with:
-        dotnet-version: 9.0.x
+        dotnet-version: 10.0.x
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL

.github/workflows/create-release.yml

@@ -34,7 +34,7 @@ jobs:
       - name: Setup .NET
         uses: actions/setup-dotnet@2016bd2012dba4e32de620c46fe006a3ac9f0602 # v5.0.1
         with:
-          dotnet-version: 9.0.x
+          dotnet-version: 10.0.x
       - name: Rename executable for beta
         if: contains(github.ref_name, '-beta')
         run: |
@@ -59,7 +59,7 @@ jobs:
         if: matrix.architecture == 'win-x64'
         run: dotnet build ./DevProxy.Abstractions/DevProxy.Abstractions.csproj -p:InformationalVersion=$("${{ github.ref_name }}".Substring(1)) -c Release --no-self-contained
       - name: Add plugins to output
-        run: cp ./DevProxy/bin/Release/net9.0/${{ matrix.architecture }}/plugins ./${{ env.release }} -r
+        run: cp ./DevProxy/bin/Release/net10.0/${{ matrix.architecture }}/plugins ./${{ env.release }} -r
       - name: Remove unnecessary files
         run: |
           pushd
@@ -112,7 +112,7 @@ jobs:
         shell: pwsh
         run: >
           ./sign code azure-key-vault
-          ./DevProxy.Abstractions/bin/Release/net9.0/DevProxy.Abstractions.dll
+          ./DevProxy.Abstractions/bin/Release/net10.0/DevProxy.Abstractions.dll
           --publisher-name "${{ env.APP_PUBLISHER }}"
           --description "${{ env.APP_DESCRIPTION }}"
           --description-url "${{ env.APP_DESCRIPTION_URL }}"
@@ -127,7 +127,7 @@ jobs:
         uses: thedoctor0/zip-release@b57d897cb5d60cb78b51a507f63fa184cfe35554 # master
         with:
           filename: '../../../../DevProxy.Abstractions-${{ github.ref_name }}.zip'
-          directory: './DevProxy.Abstractions/bin/Release/net9.0'
+          directory: './DevProxy.Abstractions/bin/Release/net10.0'
           exclusions: '*.json'
       - name: Upload abstractions
         if: matrix.architecture == 'win-x64'

.github/workflows/dotnet.yml

@@ -22,7 +22,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@2016bd2012dba4e32de620c46fe006a3ac9f0602 # v5.0.1
       with:
-        dotnet-version: 9.0.x
+        dotnet-version: 10.0.x
     - name: Restore workloads
       run: dotnet workload restore
     - name: Restore dependencies

.vscode/launch.json

@@ -10,9 +10,9 @@
       "request": "launch",
       "preLaunchTask": "build",
       // If you have changed target frameworks, make sure to update the program path.
-      "program": "${workspaceFolder}/DevProxy/bin/Debug/net9.0/devproxy.dll",
+      "program": "${workspaceFolder}/DevProxy/bin/Debug/net10.0/devproxy.dll",
       "args": [],
-      "cwd": "${workspaceFolder}/DevProxy/bin/Debug/net9.0",
+      "cwd": "${workspaceFolder}/DevProxy/bin/Debug/net10.0",
       // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console
       "console": "integratedTerminal",
       "stopAtEntry": false,

DevProxy.Abstractions/DevProxy.Abstractions.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net9.0</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>
     <RootNamespace>DevProxy.Abstractions</RootNamespace>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>

DevProxy.Abstractions/LanguageModel/OllamaLanguageModelClient.cs

@@ -54,7 +54,10 @@ public sealed class OllamaLanguageModelClient(
 
         if (Configuration.CacheResponses && _cacheChatCompletion.TryGetCacheValue(messages, out var cachedResponse))
         {
-            Logger.LogDebug("Returning cached response for message: {LastMessage}", messages.Last().Content);
+            if (Logger.IsEnabled(LogLevel.Debug))
+            {
+                Logger.LogDebug("Returning cached response for message: {LastMessage}", messages.Last().Content);
+            }
             return cachedResponse;
         }
 
@@ -181,7 +184,10 @@ protected override async Task<bool> IsEnabledCoreAsync(CancellationToken cancell
         try
         {
             var url = $"{Configuration.Url?.TrimEnd('/')}/api/chat";
-            Logger.LogDebug("Requesting chat completion. Message: {LastMessage}", messages.Last().Content);
+            if (Logger.IsEnabled(LogLevel.Debug))
+            {
+                Logger.LogDebug("Requesting chat completion. Message: {LastMessage}", messages.Last().Content);
+            }
 
             var response = await _httpClient.PostAsJsonAsync(url,
                 new

DevProxy.Abstractions/LanguageModel/OpenAILanguageModelClient.cs

@@ -62,7 +62,10 @@ public sealed class OpenAILanguageModelClient(
 
         if (Configuration.CacheResponses && _cacheChatCompletion.TryGetCacheValue(messages, out var cachedResponse))
         {
-            _logger.LogDebug("Returning cached response for message: {LastMessage}", messages.Last().Content);
+            if (_logger.IsEnabled(LogLevel.Debug))
+            {
+                _logger.LogDebug("Returning cached response for message: {LastMessage}", messages.Last().Content);
+            }
             return cachedResponse;
         }
 
@@ -148,7 +151,10 @@ protected override async Task<bool> IsEnabledCoreAsync(CancellationToken cancell
         try
         {
             var url = $"{Configuration.Url?.TrimEnd('/')}/chat/completions";
-            _logger.LogDebug("Requesting chat completion. Message: {LastMessage}", messages.Last().Content);
+            if (_logger.IsEnabled(LogLevel.Debug))
+            {
+                _logger.LogDebug("Requesting chat completion. Message: {LastMessage}", messages.Last().Content);
+            }
 
             var payload = new OpenAIChatCompletionRequest
             {

DevProxy.Abstractions/Models/MockResponse.cs

@@ -21,6 +21,8 @@ public object Clone()
 
     public static MockResponse FromHttpResponse(string httpResponse, ILogger logger)
     {
+        ArgumentNullException.ThrowIfNull(logger);
+
         logger.LogTrace("{Method} called", nameof(FromHttpResponse));
 
         if (string.IsNullOrWhiteSpace(httpResponse))
@@ -40,7 +42,10 @@ public static MockResponse FromHttpResponse(string httpResponse, ILogger logger)
         for (var i = 0; i < lines.Length; i++)
         {
             var line = lines[i];
-            logger.LogTrace("Processing line {LineNumber}: {LineContent}", i + 1, line);
+            if (logger.IsEnabled(LogLevel.Trace))
+            {
+                logger.LogTrace("Processing line {LineNumber}: {LineContent}", i + 1, line);
+            }
 
             if (i == 0)
             {

DevProxy.Abstractions/Plugins/BaseLoader.cs

@@ -91,7 +91,10 @@ private async Task<bool> ValidateFileContentsAsync(string fileContents, Cancella
 
         if (!IsValid)
         {
-            Logger.LogError("Schema validation failed for {File} with the following errors: {Errors}", FilePath, string.Join(", ", ValidationErrors));
+            if (Logger.IsEnabled(LogLevel.Error))
+            {
+                Logger.LogError("Schema validation failed for {File} with the following errors: {Errors}", FilePath, string.Join(", ", ValidationErrors));
+            }
         }
 
         return IsValid;