From 1c323c15297ef0839eab3f2fc519aa3ca82f0c68 Mon Sep 17 00:00:00 2001 From: Chuli jimmi Manurung Date: Wed, 24 Jul 2019 15:58:35 +0700 Subject: [PATCH 1/3] update build to sdk 28 --- android/build.gradle | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 53a1a73..742e274 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -1,8 +1,8 @@ apply plugin: "com.android.library" android { - compileSdkVersion 25 - buildToolsVersion "25.0.1" + compileSdkVersion 28 + buildToolsVersion "28.0.1" defaultConfig { minSdkVersion 16 @@ -14,7 +14,7 @@ android { dependencies { compile "com.facebook.react:react-native:+" // From node_modules - compile 'com.android.support:customtabs:25.0.1' + compile 'com.android.support:customtabs:28.0.1' compile ('com.github.droibit.customtabslauncher:launcher:1.0.8') { exclude module: 'customtabs' } From fdfacc01884d093d45897f463368e7f899936694 Mon Sep 17 00:00:00 2001 From: Chuli jimmi Manurung Date: Wed, 24 Jul 2019 18:51:50 +0700 Subject: [PATCH 2/3] change compile to implementation --- android/build.gradle | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 742e274..70ee2d4 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -13,11 +13,11 @@ android { } dependencies { - compile "com.facebook.react:react-native:+" // From node_modules - compile 'com.android.support:customtabs:28.0.1' - compile ('com.github.droibit.customtabslauncher:launcher:1.0.8') { + implementation "com.facebook.react:react-native:+" // From node_modules + implementation 'com.android.support:customtabs:28.0.1' + implementation ('com.github.droibit.customtabslauncher:launcher:1.0.8') { exclude module: 'customtabs' } - testCompile 'junit:junit:4.12' + testImplementation 'junit:junit:4.12' } \ No newline at end of file From 1bf9e04bc66adb85801dcadfa68ec777901ec12c Mon Sep 17 00:00:00 2001 From: Chuli jimmi Manurung Date: Wed, 7 Aug 2019 16:18:19 +0700 Subject: [PATCH 3/3] change compile to implementation --- android/build.gradle | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 70ee2d4..53a1a73 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -1,8 +1,8 @@ apply plugin: "com.android.library" android { - compileSdkVersion 28 - buildToolsVersion "28.0.1" + compileSdkVersion 25 + buildToolsVersion "25.0.1" defaultConfig { minSdkVersion 16 @@ -13,11 +13,11 @@ android { } dependencies { - implementation "com.facebook.react:react-native:+" // From node_modules - implementation 'com.android.support:customtabs:28.0.1' - implementation ('com.github.droibit.customtabslauncher:launcher:1.0.8') { + compile "com.facebook.react:react-native:+" // From node_modules + compile 'com.android.support:customtabs:25.0.1' + compile ('com.github.droibit.customtabslauncher:launcher:1.0.8') { exclude module: 'customtabs' } - testImplementation 'junit:junit:4.12' + testCompile 'junit:junit:4.12' } \ No newline at end of file