Skip to content

Commit 1737bd8

Browse files
authored
Version catalog migration (#502)
1 parent 42c4988 commit 1737bd8

File tree

7 files changed

+55
-47
lines changed

7 files changed

+55
-47
lines changed

dropbox-sdk-android/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ plugins {
88
}
99

1010
android {
11-
compileSdk 33
11+
compileSdk dropboxJavaSdkLibs.versions.android.compile.sdk.get().toInteger()
1212
defaultConfig {
13-
minSdk 21
14-
targetSdk 33
13+
minSdk dropboxJavaSdkLibs.versions.android.min.sdk.get().toInteger()
14+
targetSdk dropboxJavaSdkLibs.versions.android.target.sdk.get().toInteger()
1515
}
1616

1717
kotlinOptions {

dropbox-sdk-java/build.gradle

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -39,26 +39,25 @@ sourceSets {
3939
dependencies {
4040
api(dropboxJavaSdkLibs.jackson.core)
4141

42-
// Android
43-
compileOnly 'com.google.android:android:4.1.1.4' // Until 6.x when we have an Android Artifact
44-
compileOnly(dropboxJavaSdkLibs.kotlin.stdlib) // Only used in Android Code
45-
compileOnly(dropboxJavaSdkLibs.jakarta.servlet.api)
46-
compileOnly(dropboxJavaSdkLibs.okhttp2) // support both v2 and v3 to avoid
47-
compileOnly(dropboxJavaSdkLibs.okhttp3) // method count bloat
48-
compileOnly(dropboxJavaSdkLibs.appengine.api)
49-
50-
testImplementation 'org.testng:testng:6.9.10'
51-
testImplementation 'org.mockito:mockito-core:5.4.0'
52-
testImplementation 'org.openjdk.jmh:jmh-core:1.12'
53-
testImplementation 'org.openjdk.jmh:jmh-generator-annprocess:1.12'
54-
testImplementation 'com.google.appengine:appengine-api-1.0-sdk:1.9.38'
55-
testImplementation 'com.google.appengine:appengine-api-labs:1.9.38'
56-
testImplementation 'com.google.appengine:appengine-api-stubs:1.9.38'
57-
testImplementation 'com.google.appengine:appengine-testing:1.9.38'
58-
testImplementation 'com.squareup.okhttp:okhttp:2.7.5'
59-
testImplementation 'com.squareup.okhttp3:okhttp:4.0.0'
60-
testImplementation 'com.google.guava:guava:19.0'
61-
testImplementation "com.google.truth:truth:1.1.2"
42+
compileOnly dropboxJavaSdkLibs.android.jar
43+
compileOnly dropboxJavaSdkLibs.appengine.api
44+
compileOnly dropboxJavaSdkLibs.jakarta.servlet.api
45+
compileOnly dropboxJavaSdkLibs.kotlin.stdlib
46+
compileOnly dropboxJavaSdkLibs.okhttp2
47+
compileOnly dropboxJavaSdkLibs.okhttp3
48+
49+
testImplementation dropboxJavaSdkLibs.appengine.api
50+
testImplementation dropboxJavaSdkLibs.appengine.api.labs
51+
testImplementation dropboxJavaSdkLibs.appengine.api.stubs
52+
testImplementation dropboxJavaSdkLibs.appengine.testing
53+
testImplementation dropboxJavaSdkLibs.guava
54+
testImplementation dropboxJavaSdkLibs.jmh.core
55+
testImplementation dropboxJavaSdkLibs.jmh.generator
56+
testImplementation dropboxJavaSdkLibs.mockito.core
57+
testImplementation dropboxJavaSdkLibs.okhttp2
58+
testImplementation dropboxJavaSdkLibs.okhttp3
59+
testImplementation dropboxJavaSdkLibs.testng
60+
testImplementation dropboxJavaSdkLibs.truth
6261
}
6362

6463
configurations {

examples/android/build.gradle

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ plugins {
55
}
66

77
android {
8-
compileSdkVersion 33
9-
buildToolsVersion "33.0.0"
8+
compileSdkVersion dropboxJavaSdkLibs.versions.android.compile.sdk.get().toInteger()
9+
buildToolsVersion "33.0.1"
1010

1111
defaultConfig {
1212
applicationId "com.dropbox.core.examples.android"
13-
minSdkVersion 21
14-
targetSdkVersion 33
13+
minSdkVersion dropboxJavaSdkLibs.versions.android.min.sdk.get()
14+
targetSdkVersion dropboxJavaSdkLibs.versions.android.target.sdk.get()
1515
versionCode 1
1616
versionName "1.0"
1717

@@ -60,25 +60,21 @@ android {
6060

6161
dependencies {
6262
implementation(project(":dropbox-sdk-java"))
63-
64-
implementation(dropboxJavaSdkLibs.kotlin.stdlib)
65-
implementation(dropboxJavaSdkLibs.kotlin.coroutines)
66-
63+
implementation(dropboxJavaSdkLibs.android.material)
6764
implementation(dropboxJavaSdkLibs.androidx.appcompat)
68-
implementation(dropboxJavaSdkLibs.androidx.recyclerview)
69-
implementation(dropboxJavaSdkLibs.androidx.core.ktx)
7065
implementation(dropboxJavaSdkLibs.androidx.constraintlayout)
66+
implementation(dropboxJavaSdkLibs.androidx.core.ktx)
7167
implementation(dropboxJavaSdkLibs.androidx.lifecycle.runtime.ktx)
72-
implementation(dropboxJavaSdkLibs.android.material)
73-
68+
implementation(dropboxJavaSdkLibs.androidx.recyclerview)
7469
implementation(dropboxJavaSdkLibs.glide)
75-
70+
implementation(dropboxJavaSdkLibs.kotlin.coroutines)
71+
implementation(dropboxJavaSdkLibs.kotlin.stdlib)
7672
implementation(dropboxJavaSdkLibs.okhttp3)
7773

7874
testImplementation(dropboxJavaSdkLibs.test.junit)
7975

80-
androidTestImplementation(dropboxJavaSdkLibs.androidx.test.junit)
8176
androidTestImplementation(dropboxJavaSdkLibs.androidx.test.espresso.core)
77+
androidTestImplementation(dropboxJavaSdkLibs.androidx.test.junit)
8278
}
8379

8480
def getLocalProperties() {

examples/examples/build.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ java {
1212

1313
dependencies {
1414
implementation(project(":dropbox-sdk-java"))
15-
implementation("org.eclipse.jetty:jetty-server:11.0.15")
16-
implementation(dropboxJavaSdkLibs.jakarta.servlet.api)
17-
implementation("org.apache.commons:commons-lang3:3.4")
15+
implementation(dropboxJavaSdkLibs.apache.commons.lang)
1816
implementation(dropboxJavaSdkLibs.jackson.core)
19-
implementation("com.fasterxml.jackson.core:jackson-databind:2.15.0")
17+
implementation(dropboxJavaSdkLibs.jackson.databind)
18+
implementation(dropboxJavaSdkLibs.jakarta.servlet.api)
19+
implementation(dropboxJavaSdkLibs.jetty.server)
20+
implementation(dropboxJavaSdkLibs.json)
2021
implementation(dropboxJavaSdkLibs.okhttp3)
21-
implementation("org.json:json:20230618")
2222

2323
testImplementation(dropboxJavaSdkLibs.test.junit)
2424
}

gradle.properties

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# POM
22
GROUP = com.dropbox.core
3-
VERSION_NAME=5.4.6-SNAPSHOT
3+
VERSION_NAME=6.0.0-SNAPSHOT
44

55
POM_NAME = Dropbox SDK Java
66
POM_DESCRIPTION = A Java library to access Dropbox's HTTP-based Core API v2.
@@ -21,7 +21,6 @@ POM_DEVELOPER_EMAIL = api-support@dropbox.com
2121

2222
org.gradle.unsafe.configuration-cache=true
2323
org.gradle.caching=true
24-
#org.gradle.unsafe.isolated-projects=true
2524

2625
# Use AndroidX
2726
android.useAndroidX=true

gradle/dropboxJavaSdkLibs.versions.toml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,22 @@ kotlin-coroutines = "1.6.4"
1212

1313
[libraries]
1414
android-gradle-plugin = { module = "com.android.tools.build:gradle", version.ref = "android-gradle-plugin" }
15+
android-jar = 'com.google.android:android:4.1.1.4'
1516
android-material = 'com.google.android.material:material:1.6.1'
1617
androidx-activity = { module = "androidx.activity:activity", version.ref = "androidx-activity" }
1718
androidx-appcompat = 'androidx.appcompat:appcompat:1.4.2'
1819
androidx-constraintlayout = 'androidx.constraintlayout:constraintlayout:2.1.4'
1920
androidx-core-ktx = 'androidx.core:core-ktx:1.8.0'
2021
androidx-lifecycle-runtime-ktx = "androidx.lifecycle:lifecycle-runtime-ktx:2.5.1"
2122
androidx-recyclerview = 'androidx.recyclerview:recyclerview:1.2.1'
23+
apache-commons-lang = "org.apache.commons:commons-lang3:3.4"
2224
appengine-api = 'com.google.appengine:appengine-api-1.0-sdk:1.9.38'
2325
glide = 'com.github.bumptech.glide:glide:4.12.0'
26+
guardsquare-proguard-gradle = 'com.guardsquare:proguard-gradle:7.3.1'
2427
jackson-core = 'com.fasterxml.jackson.core:jackson-core:2.15.0'
28+
jackson-databind = 'com.fasterxml.jackson.core:jackson-databind:2.15.0'
29+
jetty-server = "org.eclipse.jetty:jetty-server:11.0.15"
30+
json = "org.json:json:20230618"
2531
jakarta-servlet-api = 'jakarta.servlet:jakarta.servlet-api:5.0.0'
2632
kotlin-gradle-plugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
2733
kotlin-stdlib = { module = "org.jetbrains.kotlin:kotlin-stdlib", version.ref = "kotlin" }
@@ -36,8 +42,16 @@ okhttp3 = 'com.squareup.okhttp3:okhttp:4.0.0'
3642

3743
androidx-test-junit = 'androidx.test.ext:junit:1.1.3'
3844
androidx-test-espresso-core = 'androidx.test.espresso:espresso-core:3.4.0'
45+
appengine-api-labs = 'com.google.appengine:appengine-api-labs:1.9.38'
46+
appengine-api-stubs = 'com.google.appengine:appengine-api-stubs:1.9.38'
47+
appengine-testing = 'com.google.appengine:appengine-testing:1.9.38'
48+
guava = 'com.google.guava:guava:19.0'
49+
jmh-core = 'org.openjdk.jmh:jmh-core:1.12'
50+
jmh-generator = 'org.openjdk.jmh:jmh-generator-annprocess:1.12'
51+
mockito-core = 'org.mockito:mockito-core:5.4.0'
3952
test-junit = 'junit:junit:4.13.2'
40-
53+
testng = 'org.testng:testng:6.9.10'
54+
truth = "com.google.truth:truth:1.1.2"
4155

4256
[plugins]
4357
binary-compatibility-validator = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version.ref = "binary-compatibility-validator" }

proguard/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ buildscript {
1717
}
1818

1919
dependencies {
20-
classpath 'com.guardsquare:proguard-gradle:7.3.1'
20+
classpath dropboxJavaSdkLibs.guardsquare.proguard.gradle
2121
}
2222
}
2323

@@ -29,7 +29,7 @@ repositories {
2929

3030
dependencies {
3131
implementation(project(":dropbox-sdk-java"))
32-
implementation("org.testng:testng:6.9.10")
32+
implementation(dropboxJavaSdkLibs.testng)
3333
}
3434

3535
tasks.named("compileJava", JavaCompile).configure {

0 commit comments

Comments
 (0)