feat(condition): add tests for empty and not empty condition handling with constants

Author: lihq1403

src/Kernel/RuleEngine/PHPSandbox/PHPSandboxRuleEngineClient.php

@@ -94,6 +94,20 @@ public function getConditionItemCode(ConditionItem $conditionItem): string
                     $eq = '==';
                     $notEq = '!=';
                 }
+
+                // Handle Empty and NotEmpty comparisons specially for constant values
+                if (in_array($conditionItem->getCompareType(), [CompareType::Empty, CompareType::NotEmpty, CompareType::Valuable, CompareType::NoValuable], true)
+                    && ! (str_starts_with($left, '($') || str_starts_with($left, '$'))) {
+                    // Determine if the constant value is empty
+                    $isEmpty = ($left === null || $left === 'null' || $left === '' || $left === '0' || $left === 'false' || $left === '[]');
+
+                    return match ($conditionItem->getCompareType()) {
+                        CompareType::Empty, CompareType::Valuable => $isEmpty ? 'true' : 'false',
+                        CompareType::NotEmpty, CompareType::NoValuable => $isEmpty ? 'false' : 'true',
+                        default => 'false',
+                    };
+                }
+
                 return match ($conditionItem->getCompareType()) {
                     CompareType::Equals => "{$left} {$eq} {$right}",
                     CompareType::NoEquals => "{$left} {$notEq} {$right}",

tests/Structure/Api/ApiSendTest.php

@@ -7,9 +7,6 @@
 
 namespace Dtyq\FlowExprEngine\Test\Structure\Api;
 
-use Dtyq\FlowExprEngine\Structure\Api\ApiRequestOptions;
-use Dtyq\FlowExprEngine\Structure\Api\ApiSend;
-use Dtyq\FlowExprEngine\Structure\Api\Safe\DefenseAgainstSSRFOptions;
 use Dtyq\FlowExprEngine\Test\BaseTestCase;
 
 /**

tests/Structure/Api/ApiTest.php

@@ -7,13 +7,6 @@
 
 namespace Dtyq\FlowExprEngine\Test\Structure\Api;
 
-use Dtyq\FlowExprEngine\Builder\ApiBuilder;
-use Dtyq\FlowExprEngine\ComponentFactory;
-use Dtyq\FlowExprEngine\Structure\Api\Api;
-use Dtyq\FlowExprEngine\Structure\Api\Safe\DefenseAgainstSSRFOptions;
-use Dtyq\FlowExprEngine\Structure\Api\StandardIO\Request as StandardRequest;
-use Dtyq\FlowExprEngine\Structure\Api\StandardIO\Response as StandardResponse;
-use Dtyq\FlowExprEngine\Structure\StructureType;
 use Dtyq\FlowExprEngine\Test\BaseTestCase;
 
 /**

tests/Structure/Condition/ConditionTest.php

@@ -104,6 +104,114 @@ public function testNumberCompatible()
         $this->assertTrue($condition->getResult(['518002981345849344' => ['content' => 1]]));
     }
 
+    public function testErrorInput()
+    {
+        $conditionArray = json_decode(
+            <<<'JSON'
+{
+    "ops": "AND",
+    "children": [
+            {
+                "type": "compare",
+                "left_operands": {
+                    "type": "const",
+                    "const_value": [
+                        {
+                            "type": "input",
+                            "uniqueId": "727422814327410688",
+                            "value": "1"
+                        }
+                    ],
+                    "expression_value": []
+                },
+                "condition": "not_empty",
+                "right_operands": {
+                    "type": "const",
+                    "const_value": [],
+                    "expression_value": []
+                }
+            }
+        ]
+}
+JSON,
+            true
+        );
+        $condition = $this->builder->build($conditionArray);
+        $this->assertEquals('((true))', $condition->getCode());
+        $this->assertTrue($condition->getResult());
+    }
+
+    public function testEmptyConditionWithConstant()
+    {
+        // Test with non-empty constant
+        $conditionArray = json_decode(
+            <<<'JSON'
+{
+    "ops": "AND",
+    "children": [
+        {
+            "type": "compare",
+            "left_operands": {
+                "type": "const",
+                "const_value": [
+                    {
+                        "type": "input",
+                        "value": "1"
+                    }
+                ],
+                "expression_value": []
+            },
+            "condition": "empty",
+            "right_operands": {
+                "type": "const",
+                "const_value": [],
+                "expression_value": []
+            }
+        }
+    ]
+}
+JSON,
+            true
+        );
+        $condition = $this->builder->build($conditionArray);
+        $this->assertEquals('((false))', $condition->getCode());
+        $this->assertFalse($condition->getResult());
+
+        // Test with empty constant
+        $conditionArray = json_decode(
+            <<<'JSON'
+{
+    "ops": "AND",
+    "children": [
+        {
+            "type": "compare",
+            "left_operands": {
+                "type": "const",
+                "const_value": [
+                    {
+                        "type": "input",
+                        "value": ""
+                    }
+                ],
+                "expression_value": []
+            },
+            "condition": "empty",
+            "right_operands": {
+                "type": "const",
+                "const_value": [],
+                "expression_value": []
+            }
+        }
+    ]
+}
+JSON,
+            true
+        );
+        $condition = $this->builder->build($conditionArray);
+        $this->assertEquals('((false))', $condition->getCode());
+        $this->assertFalse($condition->getResult());
+    }
+
     public function testNumberCondition()
     {
         $conditionArray = json_decode(