Fix OpenSUSE upload, make mount point fionding more robust (#467)

Change order of tests to favor /run/media over /media. Parse output of udiskctl mount to find mount path

Author: gsexton

tools/uf2conv.py

@@ -236,9 +236,9 @@ def get_drives():
             if len(words) >= 3 and words[1] == "2" and words[2] == "FAT":
                 drives.append(words[0])
     else:
-        rootpath = "/media"
+        rootpath = "/run/media"
         if not os.path.isdir(rootpath):
-            rootpath = "/run/media"
+            rootpath = "/media"
         if not os.path.isdir(rootpath):
             rootpath = "/opt/media"
         if sys.platform == "darwin":
@@ -318,17 +318,16 @@ def error(msg):
     if args.serial:
         if str(args.serial).startswith("/dev/tty") or str(args.serial).startswith("COM") or str(args.serial).startswith("/dev/cu"):
             try:
-                print("Resetting "+str(args.serial))
+                print("Resetting " + str(args.serial))
                 try:
                     ser = serial.Serial(args.serial, 1200)
                     ser.dtr = False
                 except:
-                    pass
+                    print("Caught exception during reset!")
                 # Probably should be smart and check for device appearance or something
                 time.sleep(10)
             except:
                 pass
-
     if args.list:
         list_drives()
     else:
@@ -359,12 +358,31 @@ def error(msg):
         else:
             drives = get_drives()
             if (len(drives) == 0) and (sys.platform == "linux"):
-                rpidisk = glob.glob("/dev/disk/by-id/usb-RPI_RP2*-part1")
-                try:
-                    subprocess.run(["udisksctl", "mount", "--block-device", os.path.realpath(rpidisk[0])])
-                    drives = get_drives()
-                except:
-                    pass # If it fails, no problem since it was a heroic attempt
+                globexpr = "/dev/disk/by-id/usb-RPI_RP2*-part1"
+                rpidisk = glob.glob(globexpr)
+                if len(rpidisk) == 0:
+                    print("Unable to find disk by ID using expression: {}".format(globexpr))
+                else:
+                    try:
+                        cmd = ["udisksctl", "mount", "--block-device", os.path.realpath(rpidisk[0])]
+                        proc_out = subprocess.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+                        if proc_out.returncode == 0:
+                            stdoutput = proc_out.stdout.decode("UTF-8")
+                            match = re.search(r'Mounted\s+.*\s+at\s+([^\.]*)', stdoutput)
+                            if match is None:
+                                print("Warn: {} did not print mount point. Attempting to locate mounted drive in file system. StdOut={}".format(cmd[0], stdoutput))
+                                drives = get_drives()
+                            else:
+                                drives = [match.group(1)]
+                        else:
+                            print("Error executing command {}. Return Code: {} Std Output: {} StdError: {}".format(" ".join(cmd), 
+                                                                                                                   proc_out.returncode,
+                                                                                                                   proc_out.stdout.decode("UTF-8"),
+                                                                                                                   proc_out.stderr.decode("UTF-8")))
+
+                    except Exception as ex:
+                        print("Exception executing udisksctl. Exception: {}".format(ex))
+                        # If it fails, no problem since it was a heroic attempt
 
         if args.output:
             write_file(args.output, outbuf)