Skip to content

Commit 3cd0a65

Browse files
committed
saving this thing
1 parent 0300733 commit 3cd0a65

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

packages/react-components/src/trace-explorer/trace-explorer-opened-traces-widget.tsx

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ export class ReactOpenTracesWidget extends React.Component<ReactOpenTracesWidget
124124
<AutoSizer>
125125
{({ width }) =>
126126
<List
127-
key={key}
128127
height={totalHeight}
129128
width={width}
130129
rowCount={this.state.openedExperiments.length}
@@ -159,6 +158,7 @@ export class ReactOpenTracesWidget extends React.Component<ReactOpenTracesWidget
159158
traces={this.state.openedExperiments[props.index].traces}
160159
experimentName={traceName}
161160
experimentUUID={traceUUID}
161+
key={traceUUID}
162162
index={props.index}
163163
handleContextMenuEvent={this.handleContextMenuEvent}
164164
handleClickEvent={this.handleClickEvent}
@@ -248,11 +248,16 @@ export class ReactOpenTracesWidget extends React.Component<ReactOpenTracesWidget
248248
}
249249

250250
protected handleTabNameUpdate(tabEditingOpen: string, index: number): void {
251-
const exp = this.state.openedExperiments[index];
252-
exp.name = tabEditingOpen;
253-
const experimentOpenNew = this.state.openedExperiments;
254-
experimentOpenNew[index] = exp;
255-
this.setState({openedExperiments: experimentOpenNew});
251+
this.setState(({openedExperiments}) => ({
252+
openedExperiments: [
253+
...openedExperiments.slice(0,index),
254+
{
255+
...openedExperiments[index],
256+
name: tabEditingOpen,
257+
},
258+
...openedExperiments.slice(index + 1)
259+
]
260+
}));
256261
}
257262

258263
protected handleShareButtonClick = (index: number): void => this.doHandleShareButtonClick(index);

0 commit comments

Comments
 (0)