Skip to content

--params option not sufficient for global configuration #93

@bhufmann

Description

@bhufmann

Bug Description:

--params option not sufficient for global configuration because it's only for the parameters passed as parameters map in the ConfigurationQueryParameters. There is no way to add the name to ConfigurationQueryParameters which is passed in the post_configuration() method of the TspClient. The "post_configuration" method() creates the query parameters without name:

def post_configuration(self, type_id, params):
        api_url = '{0}config/types/{1}/configs'.format(self.base_url, type_id)
        parameters = {'parameters': params}
        response = requests.post(api_url, json=parameters, headers=headers)
...

The handwritten python client doesn't verify if name is passed to the body of HTTP post call. However, generated clients will verify it because it's a required field.

Moreover, backend implemenation of a configuration source will rely on it because it's required. Note, that the XMLConfigurationSource of the Trace Compass server is the sole implementation in Trace Compass so far and it doesn't require a name and ignores it. The filename of the xml file configured in the path variable is assigned as name.

Change python code to pass a user defined name similarly when posting output configurations using a json file.

Steps to Reproduce:

No easy way to reproduce. Just debug the client code (TspClient.post_configuration()) and see that the name is not passed.

Additional Information

  • Operating System:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions