Skip to content

Commit efc74e3

Browse files
Remove on-close events from json-config-editor
This will force the user to use the button commands in the nav bar. Signed-off-by: Will Yang <william.yang@ericsson.com>
1 parent 70eed83 commit efc74e3

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

vscode-trace-extension/src/json-editor/json-editor.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -287,20 +287,13 @@ export class JsonConfigEditor {
287287
const validation = await this.schemaService.validateJsonFile(this.tempFileUri, schema);
288288

289289
if (validation.isValid && validation.content) {
290-
const submit = this.userClickedSubmit
291-
? 'Yes'
292-
: await vscode.window.showInformationMessage(
293-
'Do you want to submit this configuration?',
294-
'Yes',
295-
'No'
296-
);
297-
298-
if (submit === 'Yes') {
290+
291+
if (this.userClickedSubmit) {
299292
vscode.window.showInformationMessage('Configuration submitted successfully');
300293
return validation.content;
301294
}
302295

303-
return undefined; // User chose not to submit
296+
return undefined; // User closed the window without submitting
304297
} else if (validation.errors) {
305298
this.displayValidationErrorDialogue(
306299
`Your configuration was not submitted because it had errors`,

0 commit comments

Comments
 (0)